From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22895 invoked by alias); 29 Nov 2012 19:06:14 -0000 Received: (qmail 22866 invoked by uid 22791); 29 Nov 2012 19:06:12 -0000 X-SWARE-Spam-Status: No, hits=-5.1 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE X-Spam-Check-By: sourceware.org Received: from mail-we0-f175.google.com (HELO mail-we0-f175.google.com) (74.125.82.175) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 29 Nov 2012 19:05:32 +0000 Received: by mail-we0-f175.google.com with SMTP id z53so4412277wey.20 for ; Thu, 29 Nov 2012 11:05:31 -0800 (PST) MIME-Version: 1.0 Received: by 10.180.88.99 with SMTP id bf3mr36819211wib.22.1354215930940; Thu, 29 Nov 2012 11:05:30 -0800 (PST) Received: by 10.216.116.67 with HTTP; Thu, 29 Nov 2012 11:05:30 -0800 (PST) In-Reply-To: References: <20121122203747.GA4264@gmail.com> <50B79D18.6050601@net-b.de> <50B7A866.4050804@oracle.com> Date: Thu, 29 Nov 2012 19:26:00 -0000 Message-ID: Subject: Re: [PATCH] Add --with-build-config=bootstrap-asan support From: Andrew Pinski To: "H.J. Lu" Cc: Paolo Carlini , Tobias Burnus , gcc-patches@gcc.gnu.org Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2012-11/txt/msg02495.txt.bz2 On Thu, Nov 29, 2012 at 11:03 AM, H.J. Lu wrote: > On Thu, Nov 29, 2012 at 10:32 AM, H.J. Lu wrote: >> On Thu, Nov 29, 2012 at 10:24 AM, Paolo Carlini >> wrote: >>> On 11/29/2012 06:36 PM, Tobias Burnus wrote: >>>> >>>> H.J. Lu wrote: >>>>> >>>>> This patch adds --with-build-config=bootstrap-asan support. Tested on >>>>> Linux/x86-64. OK to install? >>>> >>>> >>>> I think that patch has broken bootstrap for me. If I do a normal >>>> bootstrap, Stage1 fails with: >>>> >>>> libtool: compile: unrecognized option `-D_GNU_SOURCE' >>>> libtool: compile: Try `libtool --help' for more information. >>>> make[4]: *** [interception_linux.lo] Error 1 >>>> make[4]: Leaving directory >>>> `/home/burnus/gcc/build/x86_64-unknown-linux-gnu/libsanitizer/interception' >>> >>> Likewise here. Would it be possible to revert the offending commit, in the >>> meanwhile? >>> >> >> This is a known problem. Please try: >> >> http://gcc.gnu.org/ml/gcc-patches/2012-11/msg02480.html >> >> I updated my patch for the newly added tsan. It fixed >> bootstrap on Linux/ia32. >> > > I checked in my patch to restore bootstrap after tested > on Linux/ia32 and Linux/x86-64. I will revert both patches > if my fix is incorrect. This is not how patch review is supposed to work. Thanks, Andrew