From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x530.google.com (mail-pg1-x530.google.com [IPv6:2607:f8b0:4864:20::530]) by sourceware.org (Postfix) with ESMTPS id 73D183858C52 for ; Fri, 14 Jul 2023 19:15:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 73D183858C52 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pg1-x530.google.com with SMTP id 41be03b00d2f7-55be1ce1669so1449799a12.1 for ; Fri, 14 Jul 2023 12:15:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1689362156; x=1691954156; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=g25L8rdHdsfP+6xhwSXSOzn8HWS7WYezvtTrrp72xyw=; b=hAlD9MHT3BOCn3W2RXDaJcgZYV8rhIx4P5B5jdcFcno+QQgNhOC1TndJXCo3Vz3Zf0 JUR+pWZOsYJkY7BW6lHZRkxV3I9O3Jrv0vhVtDH8iJvPpSBD/RerEyodoypeBsSYtBtz Bb/a6Ukp8UnFYSbGSRZdLC+R9vJgdloosKrbKpCFQP3uxX95xJQmOYn5pEwFu9UNzrcC 7/IstjWthEsIDuWFUA47V1UxDKS1DlSt0BhT7slaToCp+66zxIJUyCVa+K+GY0EQ7/g/ dq/z41zsIkrzB6sbpUgCYv2YmPoLTudRNxtgUdaxsX04goxlFX+Kouihl0vynyWYpz+F UL+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689362156; x=1691954156; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=g25L8rdHdsfP+6xhwSXSOzn8HWS7WYezvtTrrp72xyw=; b=D1M/3rbt1FRe73F3xL4N6PP5A58WPobuUklYtyDFuqPUsXUuODuHbJm1jJnb2zNjsB 7mkLFEhNC9a3R8/6YAmVpXg382tPfi9yo9bpDsmc1nwVPEAZpGZ7fmbXpQmjemHJg+ZL lx6B6H77syvAxFqbt6GdEbLzedLULQq977/GD19PZEY9g23gRC7eSqSy1+fi5ZPOs2rr F5FBWKjh9/NY226u8ITQPuFsCsAkIJDnIMtqQU9tOxoYOadp8uVsdWTyRiDJqBe6RZ+w kCkRRMbLk71i0IdDsaMj5mDBWBgGr8gb/P4UNXfjQxFiwwF2NOOm6Cg7EXGOAXVyrfPR HyyA== X-Gm-Message-State: ABy/qLYT7aqJtBPAmd0fh+0l1eLWOUTOJtQOqFbfgmz63bECT0J4rFWK pEP5IYRqdyBXWC8HrmLZ4ZnDBZMknpH6VT51U7o= X-Google-Smtp-Source: APBJJlG6lnlg0IWOB6ejj1Ax30PoUXu166qLZ+QpxMbUOejFnZSlqK18fpiLr/5437pqlCvV/AWVs+TjMfiNnRKY6Ic= X-Received: by 2002:a17:90a:660f:b0:263:72d2:18dd with SMTP id l15-20020a17090a660f00b0026372d218ddmr3686465pjj.3.1689362156524; Fri, 14 Jul 2023 12:15:56 -0700 (PDT) MIME-Version: 1.0 References: <001201d9b684$e319fdd0$a94df970$@nextmovesoftware.com> In-Reply-To: <001201d9b684$e319fdd0$a94df970$@nextmovesoftware.com> From: Andrew Pinski Date: Fri, 14 Jul 2023 12:15:44 -0700 Message-ID: Subject: Re: [PATCH] Fix bootstrap failure (with g++ 4.8.5) in tree-if-conv.cc. To: Roger Sayle Cc: gcc-patches@gcc.gnu.org, Tamar Christina Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, Jul 14, 2023 at 11:56=E2=80=AFAM Roger Sayle wrote: > > > > This patch fixes the bootstrap failure I'm seeing using gcc 4.8.5 as > > the host compiler. Ok for mainline? [I might be missing something] I think adding const here makes this well defined C++20 too. See http://cplusplus.github.io/LWG/lwg-defects.html#3031 . Also see https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D107850 . (I could be reading these wrong too). Thanks, Andrew > > > > > > 2023-07-14 Roger Sayle > > > > gcc/ChangeLog > > * tree-if-conv.cc (predicate_scalar_phi): Make the arguments > > to the std::sort comparison lambda function const. > > > > > > Cheers, > > Roger > > -- > > >