public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Andrew Pinski <pinskia@gmail.com>
To: Thomas Preudhomme <thomas.preudhomme@foss.arm.com>
Cc: Rainer Orth <ro@cebitec.uni-bielefeld.de>,
	Mike Stump <mikestump@comcast.net>,
	 "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH, GCC/testsuite] Fix dump-noaddr dumpbase
Date: Wed, 9 Nov 2022 19:00:05 -0800	[thread overview]
Message-ID: <CA+=Sn1mWMNaeFviwFHvxqX5sfY1n=vA=jh5AQ7YBWHWwfU3joA@mail.gmail.com> (raw)
In-Reply-To: <eb22aac6-891c-7c92-896d-831ccdc12047@foss.arm.com>

On Tue, Dec 5, 2017 at 9:50 AM Thomas Preudhomme
<thomas.preudhomme@foss.arm.com> wrote:
>
> Hi,
>
> dump-noaddr test FAILS when $tmpdir is not the same as the directory
> where runtest is called from. Note that this does not happen when
> running make check because tmpdir is set to srcdir.
>
> In that case, file mkdir will create the directory in the current
> directory while GCC is invoked from tmpdir and hence -dumpbase look
> for dump1 and dump2 relative to tmpdir. This patch forces dumpbase to
> be relative to tmpdir which will work in all case.

I filed https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107602 for this
since it seems like this patch keeps on getting lost in the discussion
and never being fixed fully.

Thanks,
Andrew


>
> ChangeLog entry is as follows:
>
> *** gcc/testsuite/ChangeLog ***
>
> 2017-12-05  Thomas Preud'homme  <thomas.preudhomme@arm.com>
>
>         * gcc.c-torture/unsorted/dump-noaddr.x (dump_compare): Set dump base
>         relative to tmpdir.
>
> Testing: Successfully ran unsorted.exp via make check and out of tree
> testing using runtest from <path>/test with tmpdir set in
> <path>/test/site.exp to <path>.
>
> Is this ok for stage3?
>
> Best regards,
>
> Thomas

      parent reply	other threads:[~2022-11-10  3:00 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-05 17:50 Thomas Preudhomme
2017-12-05 17:54 ` Andrew Pinski
2017-12-05 19:11   ` Thomas Preudhomme
2017-12-05 19:27     ` Mike Stump
2017-12-05 20:56       ` Thomas Preudhomme
2017-12-05 21:26         ` Mike Stump
2018-03-01 16:41           ` Thomas Preudhomme
2019-12-02  4:52       ` Andrew Pinski
2017-12-05 19:25   ` Mike Stump
2022-11-10  3:00 ` Andrew Pinski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CA+=Sn1mWMNaeFviwFHvxqX5sfY1n=vA=jh5AQ7YBWHWwfU3joA@mail.gmail.com' \
    --to=pinskia@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=mikestump@comcast.net \
    --cc=ro@cebitec.uni-bielefeld.de \
    --cc=thomas.preudhomme@foss.arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).