From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 128046 invoked by alias); 22 Aug 2015 08:47:34 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 128036 invoked by uid 89); 22 Aug 2015 08:47:34 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-lb0-f181.google.com Received: from mail-lb0-f181.google.com (HELO mail-lb0-f181.google.com) (209.85.217.181) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Sat, 22 Aug 2015 08:47:32 +0000 Received: by lbbpu9 with SMTP id pu9so55932443lbb.3 for ; Sat, 22 Aug 2015 01:47:29 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.152.120.198 with SMTP id le6mr11802795lab.38.1440233249149; Sat, 22 Aug 2015 01:47:29 -0700 (PDT) Received: by 10.25.158.69 with HTTP; Sat, 22 Aug 2015 01:47:28 -0700 (PDT) In-Reply-To: <20150819160834.GB37938@e107456-lin.cambridge.arm.com> References: <20150819160834.GB37938@e107456-lin.cambridge.arm.com> Date: Sat, 22 Aug 2015 10:36:00 -0000 Message-ID: Subject: Re: [PATCHv2/AARCH64] Remove index from AARCH64_EXTRA_TUNING_OPTION From: Andrew Pinski To: James Greenhalgh Cc: GCC Patches Content-Type: multipart/mixed; boundary=089e01176905360b03051de26f6d X-IsSubscribed: yes X-SW-Source: 2015-08/txt/msg01357.txt.bz2 --089e01176905360b03051de26f6d Content-Type: text/plain; charset=UTF-8 Content-length: 1992 On Thu, Aug 20, 2015 at 12:08 AM, James Greenhalgh wrote: > On Wed, Aug 19, 2015 at 05:00:14PM +0100, Andrew Pinski wrote: >> Just like the patch for AARCH64_FUSION_PAIR, this is a patch for >> AARCH64_EXTRA_TUNING_OPTION. Note I tested this patch on top of the >> patch for AARCH64_EXTRA_TUNING_OPTION. >> >> Changes in v2: >> Remove the hack for AARCH64_EXTRA_TUNE_ALL. >> >> Remove index from AARCH64_EXTRA_TUNING_OPTION >> >> Instead of doing an explict index in aarch64-tuning-flags.def, we >> should have an enum which does the index instead. This allows >> you to add/remove them without worrying about the order being >> correct and having holes or worry about merge conficts. >> >> OK? Bootstrapped and tested on aarch64-linux-gnu with no regressions. > > -ENOPATCH, but assuming this is along the same lines as the one I just > acked, I'm happy for you to consider this preapproved (after checking > the comments below). Please send a copy to the list for the archives. Attached. Yes I just had forgot to attach it when I sent this one out. > >> ChangeLog: >> * config/aarch64/aarch64-tuning-flags.def: Remove all index to >> AARCH64_EXTRA_TUNING_OPTION. >> * config/aarch64/aarch64-protos.h (extra_tuning_flags_index): New enum. > > I'm guessing that this has a more aarch64-centric name like > aarch64_extra_tuning_flags_index ? If not, it probably should have just to > fit with the naming scheme in the rest of the file. That was just a copy and paste error into the ChangeLog. The name in the aarch64-protos.h is aarch64_extra_tuning_flags_index. > >> (aarch64_extra_tuning_flags): Base the shifted value on the index instead >> of the argument to AARCH64_EXTRA_TUNING_OPTION. >> * config/aarch64/aarch64.c: Remove the last argument to >> AARCH64_EXTRA_TUNING_OPTION.. > > Watch out for the extra . on the end of this ChangeLog line.. Got it will fix. Thanks, Andrew > > Thanks, > James > >> --089e01176905360b03051de26f6d Content-Type: text/plain; charset=US-ASCII; name="tuning.diff.txt" Content-Disposition: attachment; filename="tuning.diff.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_idmqxfti0 Content-length: 5092 Y29tbWl0IGIxMDllNzNmNTk2NjgyN2Q5OWI5YWJkOGM5YzQ1ZGM4OTc2MDRj Y2QKQXV0aG9yOiBBbmRyZXcgUGluc2tpIDxhcGluc2tpQGNhdml1bS5jb20+ CkRhdGU6ICAgV2VkIEF1ZyAxOSAwMToxNTowMCAyMDE1IC0wNzAwCgogICAg UmVtb3ZlIGluZGV4IGZyb20gQUFSQ0g2NF9FWFRSQV9UVU5JTkdfT1BUSU9O CiAgICAKICAgIEluc3RlYWQgb2YgZG9pbmcgYW4gZXhwbGljdCBpbmRleCBp biBhYXJjaDY0LXR1bmluZy1mbGFncy5kZWYsIHdlCiAgICBzaG91bGQgaGF2 ZSBhbiBlbnVtIHdoaWNoIGRvZXMgdGhlIGluZGV4IGluc3RlYWQuICBUaGlz IGFsbG93cwogICAgeW91IHRvIGFkZC9yZW1vdmUgdGhlbSB3aXRob3V0IHdv cnJ5aW5nIGFib3V0IHRoZSBvcmRlciBiZWluZwogICAgY29ycmVjdCBhbmQg aGF2aW5nIGhvbGVzIG9yIHdvcnJ5IGFib3V0IG1lcmdlIGNvbmZpY3RzLgog ICAgCiAgICBPSz8gQm9vdHN0cmFwcGVkIGFuZCB0ZXN0ZWQgb24gYWFyY2g2 NC1saW51eC1nbnUgd2l0aCBubyByZWdyZXNzaW9ucy4KICAgIAogICAgQ2hh bmdlTG9nOgogICAgKiBjb25maWcvYWFyY2g2NC9hYXJjaDY0LXR1bmluZy1m bGFncy5kZWY6IFJlbW92ZSBhbGwgaW5kZXggdG8gQUFSQ0g2NF9FWFRSQV9U VU5JTkdfT1BUSU9OLgogICAgKiBjb25maWcvYWFyY2g2NC9hYXJjaDY0LXBy b3Rvcy5oIChleHRyYV90dW5pbmdfZmxhZ3NfaW5kZXgpOiBOZXcgZW51bS4K ICAgIChhYXJjaDY0X2V4dHJhX3R1bmluZ19mbGFncyk6IEJhc2UgdGhlIHNo aWZ0ZWQgdmFsdWUgb24gdGhlIGluZGV4IGluc3RlYWQKICAgIG9mIHRoZSBh cmd1bWVudCB0byBBQVJDSDY0X0VYVFJBX1RVTklOR19PUFRJT04uCiAgICAq IGNvbmZpZy9hYXJjaDY0L2FhcmNoNjQuYzogUmVtb3ZlIHRoZSBsYXN0IGFy Z3VtZW50IHRvIEFBUkNINjRfRVhUUkFfVFVOSU5HX09QVElPTi4uCgpkaWZm IC0tZ2l0IGEvZ2NjL2NvbmZpZy9hYXJjaDY0L2FhcmNoNjQtcHJvdG9zLmgg Yi9nY2MvY29uZmlnL2FhcmNoNjQvYWFyY2g2NC1wcm90b3MuaAppbmRleCAw NTdkNGZjLi5hMTJkZWM1IDEwMDY0NAotLS0gYS9nY2MvY29uZmlnL2FhcmNo NjQvYWFyY2g2NC1wcm90b3MuaAorKysgYi9nY2MvY29uZmlnL2FhcmNoNjQv YWFyY2g2NC1wcm90b3MuaApAQCAtMjIyLDIxICsyMjIsMjUgQEAgZW51bSBh YXJjaDY0X2Z1c2lvbl9wYWlycwogfTsKICN1bmRlZiBBQVJDSDY0X0ZVU0lP Tl9QQUlSCiAKLSNkZWZpbmUgQUFSQ0g2NF9FWFRSQV9UVU5JTkdfT1BUSU9O KHgsIG5hbWUsIGluZGV4KSBcCi0gIEFBUkNINjRfRVhUUkFfVFVORV8jI25h bWUgPSAoMSA8PCBpbmRleCksCisjZGVmaW5lIEFBUkNINjRfRVhUUkFfVFVO SU5HX09QVElPTih4LCBuYW1lKSBcCisgIEFBUkNINjRfRVhUUkFfVFVORV8j I25hbWUjI19pbmRleCwKKy8qIFN1cHBvcnRlZCB0dW5pbmcgZmxhZ3MgaW5k ZXhlcy4gICovCitlbnVtIGFhcmNoNjRfZXh0cmFfdHVuaW5nX2ZsYWdzX2lu ZGV4Cit7CisjaW5jbHVkZSAiYWFyY2g2NC10dW5pbmctZmxhZ3MuZGVmIgor ICBBQVJDSDY0X0VYVFJBX1RVTkVfaW5kZXhfRU5ECit9OworI3VuZGVmIEFB UkNINjRfRVhUUkFfVFVOSU5HX09QVElPTgorCisKKyNkZWZpbmUgQUFSQ0g2 NF9FWFRSQV9UVU5JTkdfT1BUSU9OKHgsIG5hbWUpIFwKKyAgQUFSQ0g2NF9F WFRSQV9UVU5FXyMjbmFtZSA9ICgxdSA8PCBBQVJDSDY0X0VYVFJBX1RVTkVf IyNuYW1lIyNfaW5kZXgpLAogLyogU3VwcG9ydGVkIHR1bmluZyBmbGFncy4g ICovCiBlbnVtIGFhcmNoNjRfZXh0cmFfdHVuaW5nX2ZsYWdzCiB7CiAgIEFB UkNINjRfRVhUUkFfVFVORV9OT05FID0gMCwKICNpbmNsdWRlICJhYXJjaDY0 LXR1bmluZy1mbGFncy5kZWYiCi0KLS8qIEhhY2t5IG1hY3JvIHRvIGJ1aWxk IHRoZSAiYWxsIiBmbGFnIG1hc2suCi0gICBFeHBhbmRzIHRvIDAgfCBBQVJD SDY0X1RVTkVfaW5kZXgwIHwgQUFSQ0g2NF9UVU5FX2luZGV4MSAsIGV0Yy4g ICovCi0jdW5kZWYgQUFSQ0g2NF9FWFRSQV9UVU5JTkdfT1BUSU9OCi0jZGVm aW5lIEFBUkNINjRfRVhUUkFfVFVOSU5HX09QVElPTih4LCBuYW1lLCB5KSBc Ci0gIHwgQUFSQ0g2NF9FWFRSQV9UVU5FXyMjbmFtZQotICBBQVJDSDY0X0VY VFJBX1RVTkVfQUxMID0gMAotI2luY2x1ZGUgImFhcmNoNjQtdHVuaW5nLWZs YWdzLmRlZiIKKyAgQUFSQ0g2NF9FWFRSQV9UVU5FX0FMTCA9ICgxdSA8PCBB QVJDSDY0X0VYVFJBX1RVTkVfaW5kZXhfRU5EKSAtIDEKIH07CiAjdW5kZWYg QUFSQ0g2NF9FWFRSQV9UVU5JTkdfT1BUSU9OCiAKZGlmZiAtLWdpdCBhL2dj Yy9jb25maWcvYWFyY2g2NC9hYXJjaDY0LXR1bmluZy1mbGFncy5kZWYgYi9n Y2MvY29uZmlnL2FhcmNoNjQvYWFyY2g2NC10dW5pbmctZmxhZ3MuZGVmCmlu ZGV4IDAxYWFjYTguLjYyODM4NmIgMTAwNjQ0Ci0tLSBhL2djYy9jb25maWcv YWFyY2g2NC9hYXJjaDY0LXR1bmluZy1mbGFncy5kZWYKKysrIGIvZ2NjL2Nv bmZpZy9hYXJjaDY0L2FhcmNoNjQtdHVuaW5nLWZsYWdzLmRlZgpAQCAtMjAs MTUgKzIwLDEzIEBACiAvKiBBZGRpdGlvbmFsIGNvbnRyb2wgb3ZlciBjZXJ0 YWluIHR1bmluZyBwYXJhbWV0ZXJzLiAgQmVmb3JlIGluY2x1ZGluZwogICAg dGhpcyBmaWxlLCBkZWZpbmUgYSBtYWNybzoKIAotICAgICBBQVJDSDY0X0VY VFJBX1RVTklOR19PUFRJT04gKG5hbWUsIGludGVybmFsX25hbWUsIGluZGV4 X2JpdCkKKyAgICAgQUFSQ0g2NF9FWFRSQV9UVU5JTkdfT1BUSU9OIChuYW1l LCBpbnRlcm5hbF9uYW1lKQogCiAgICBXaGVyZToKIAogICAgICBOQU1FIGlz IGEgc3RyaW5nIGdpdmluZyBhIGZyaWVuZGx5IG5hbWUgZm9yIHRoZSB0dW5p bmcgZmxhZy4KICAgICAgSU5URVJOQUxfTkFNRSBnaXZlcyB0aGUgaW50ZXJu YWwgbmFtZSBzdWl0YWJsZSBmb3IgYXBwZW5kaW5nIHRvCi0gICAgIEFBUkNI NjRfVFVORV8gdG8gZ2l2ZSBhbiBlbnVtIG5hbWUuCi0gICAgIElOREVYX0JJ VCBpcyB0aGUgYml0IHRvIHNldCBpbiB0aGUgYml0bWFzayBvZiBzdXBwb3J0 ZWQgdHVuaW5nCi0gICAgIGZsYWdzLiAgKi8KKyAgICAgQUFSQ0g2NF9UVU5F XyB0byBnaXZlIGFuIGVudW0gbmFtZS4gKi8KIAotQUFSQ0g2NF9FWFRSQV9U VU5JTkdfT1BUSU9OICgicmVuYW1lX2ZtYV9yZWdzIiwgUkVOQU1FX0ZNQV9S RUdTLCAwKQorQUFSQ0g2NF9FWFRSQV9UVU5JTkdfT1BUSU9OICgicmVuYW1l X2ZtYV9yZWdzIiwgUkVOQU1FX0ZNQV9SRUdTKQogCmRpZmYgLS1naXQgYS9n Y2MvY29uZmlnL2FhcmNoNjQvYWFyY2g2NC5jIGIvZ2NjL2NvbmZpZy9hYXJj aDY0L2FhcmNoNjQuYwppbmRleCAxNjJlMjVlLi5hZDE0NGZlIDEwMDY0NAot LS0gYS9nY2MvY29uZmlnL2FhcmNoNjQvYWFyY2g2NC5jCisrKyBiL2djYy9j b25maWcvYWFyY2g2NC9hYXJjaDY0LmMKQEAgLTE4Myw3ICsxODMsNyBAQCBz dGF0aWMgY29uc3Qgc3RydWN0IGFhcmNoNjRfZmxhZ19kZXNjIGFhcmNoNjRf ZnVzaWJsZV9wYWlyc1tdID0KIH07CiAjdW5kZWYgQUFSQ0g2NF9GVUlPTl9Q QUlSCiAKLSNkZWZpbmUgQUFSQ0g2NF9FWFRSQV9UVU5JTkdfT1BUSU9OKG5h bWUsIGludGVybmFsX25hbWUsIHkpIFwKKyNkZWZpbmUgQUFSQ0g2NF9FWFRS QV9UVU5JTkdfT1BUSU9OKG5hbWUsIGludGVybmFsX25hbWUpIFwKICAgeyBu YW1lLCBBQVJDSDY0X0VYVFJBX1RVTkVfIyNpbnRlcm5hbF9uYW1lIH0sCiBz dGF0aWMgY29uc3Qgc3RydWN0IGFhcmNoNjRfZmxhZ19kZXNjIGFhcmNoNjRf dHVuaW5nX2ZsYWdzW10gPQogewo= --089e01176905360b03051de26f6d--