From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yb1-xb34.google.com (mail-yb1-xb34.google.com [IPv6:2607:f8b0:4864:20::b34]) by sourceware.org (Postfix) with ESMTPS id BE74C385C40B for ; Mon, 19 Jul 2021 06:26:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BE74C385C40B Received: by mail-yb1-xb34.google.com with SMTP id y38so26159115ybi.1 for ; Sun, 18 Jul 2021 23:26:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ykTtTz0OwXs+9o3qpLxnn1Ime0GloAQ0mTr+c8CLWtc=; b=QK7p7yPs5uhfa4DUn50Q98H2prrc8Pxy9NYABuBPaKtmX8Cq97kbn9unxLxOXrD0bu ktNU6+vQdrsbkXkU4he64I3rnHOKUkLr8hDcN9d1gs5VMosqy+1fZ1NKG3kMx61Atnow I7QqMT9d7lWZrtonW+t1ZQqgtATK8ULJDuTXANu5r43njKauDfbrVU6s5Ydo24oJVJGB c05hhCcvfEJ+sZGvOH0bzmf0ae4D9k8X3R7Tf1gWN0zxLbtAMFG8GtvvLyzoE7BVJHFE 6TKxQ5FJyC9imzoFRZYMTohwjyT3gK4DcIFCMprJjW/XfvWglO3mjWbKxuugRZOyDANw jTcg== X-Gm-Message-State: AOAM530MOb6+H152zbR16na2JEyrtbMT+kvJHXNjAnoOM6jxpyAgmzjC NJsjG5lN1CM9qV1MckB24qDPwSJyF/+qAWf9Mmw= X-Google-Smtp-Source: ABdhPJxkavrFwHuiaRqBQIoUpxhIFXFHB8g6k2Jjm1QTbUoB3ClSVBC3IXeAr7eogLuhaSsAea19v5+RXUbfhe8z9fc= X-Received: by 2002:a5b:586:: with SMTP id l6mr30176868ybp.352.1626676011372; Sun, 18 Jul 2021 23:26:51 -0700 (PDT) MIME-Version: 1.0 References: <0a8b77ba-1d54-1eff-b54d-d2cb1e769e09@linux.ibm.com> In-Reply-To: <0a8b77ba-1d54-1eff-b54d-d2cb1e769e09@linux.ibm.com> From: Andrew Pinski Date: Sun, 18 Jul 2021 23:26:39 -0700 Message-ID: Subject: Re: [RFC/PATCH] Use range-based for loops for traversing loops To: "Kewen.Lin" Cc: GCC Patches , Jakub Jelinek , Jonathan Wakely , Segher Boessenkool , Richard Sandiford , Trevor Saunders Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-1.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Jul 2021 06:26:53 -0000 On Sun, Jul 18, 2021 at 11:21 PM Kewen.Lin via Gcc-patches wrote: > > Hi, > > This patch follows Martin's suggestion here[1], to support > range-based for loops for traversing loops, analogously to > the patch for vec[2]. > > Bootstrapped and regtested on powerpc64le-linux-gnu P9, > x86_64-redhat-linux and aarch64-linux-gnu, also > bootstrapped on ppc64le P9 with bootstrap-O3 config. > > Any comments are appreciated. +1 from me (note I did not review the patch but I like the idea). Thanks, Andrew > > BR, > Kewen > > [1] https://gcc.gnu.org/pipermail/gcc-patches/2021-June/573424.html > [2] https://gcc.gnu.org/pipermail/gcc-patches/2021-June/572315.html > ----- > gcc/ChangeLog: > > * cfgloop.h (class loop_iterator): Rename to ... > (class loops_list): ... this. > (loop_iterator::next): Rename to ... > (loops_list::iterator::fill_curr_loop): ... this and adjust. > (loop_iterator::loop_iterator): Rename to ... > (loops_list::loops_list): ... this and adjust. > (FOR_EACH_LOOP): Rename to ... > (ALL_LOOPS): ... this. > (FOR_EACH_LOOP_FN): Rename to ... > (ALL_LOOPS_FN): this. > (loops_list::iterator): New class. > (loops_list::begin): New function. > (loops_list::end): Likewise. > * cfgloop.c (flow_loops_dump): Adjust FOR_EACH_LOOP* with ALL_LOOPS*. > (sort_sibling_loops): Likewise. > (disambiguate_loops_with_multiple_latches): Likewise. > (verify_loop_structure): Likewise. > * cfgloopmanip.c (create_preheaders): Likewise. > (force_single_succ_latches): Likewise. > * config/aarch64/falkor-tag-collision-avoidance.c > (execute_tag_collision_avoidance): Likewise. > * config/mn10300/mn10300.c (mn10300_scan_for_setlb_lcc): Likewise. > * config/s390/s390.c (s390_adjust_loops): Likewise. > * doc/loop.texi: Likewise. > * gimple-loop-interchange.cc (pass_linterchange::execute): Likewise. > * gimple-loop-jam.c (tree_loop_unroll_and_jam): Likewise. > * gimple-loop-versioning.cc (loop_versioning::analyze_blocks): Likewise. > (loop_versioning::make_versioning_decisions): Likewise. > * gimple-ssa-split-paths.c (split_paths): Likewise. > * graphite-isl-ast-to-gimple.c (graphite_regenerate_ast_isl): Likewise. > * graphite.c (canonicalize_loop_form): Likewise. > (graphite_transform_loops): Likewise. > * ipa-fnsummary.c (analyze_function_body): Likewise. > * ipa-pure-const.c (analyze_function): Likewise. > * loop-doloop.c (doloop_optimize_loops): Likewise. > * loop-init.c (loop_optimizer_finalize): Likewise. > (fix_loop_structure): Likewise. > * loop-invariant.c (calculate_loop_reg_pressure): Likewise. > (move_loop_invariants): Likewise. > * loop-unroll.c (decide_unrolling): Likewise. > (unroll_loops): Likewise. > * modulo-sched.c (sms_schedule): Likewise. > * predict.c (predict_loops): Likewise. > (pass_profile::execute): Likewise. > * profile.c (branch_prob): Likewise. > * sel-sched-ir.c (sel_finish_pipelining): Likewise. > (sel_find_rgns): Likewise. > * tree-cfg.c (replace_loop_annotate): Likewise. > (replace_uses_by): Likewise. > (move_sese_region_to_fn): Likewise. > * tree-if-conv.c (pass_if_conversion::execute): Likewise. > * tree-loop-distribution.c (loop_distribution::execute): Likewise. > * tree-parloops.c (parallelize_loops): Likewise. > * tree-predcom.c (tree_predictive_commoning): Likewise. > * tree-scalar-evolution.c (scev_initialize): Likewise. > (scev_reset): Likewise. > * tree-ssa-dce.c (find_obviously_necessary_stmts): Likewise. > * tree-ssa-live.c (remove_unused_locals): Likewise. > * tree-ssa-loop-ch.c (ch_base::copy_headers): Likewise. > * tree-ssa-loop-im.c (analyze_memory_references): Likewise. > (tree_ssa_lim_initialize): Likewise. > * tree-ssa-loop-ivcanon.c (canonicalize_induction_variables): Likewise. > * tree-ssa-loop-ivopts.c (tree_ssa_iv_optimize): Likewise. > * tree-ssa-loop-manip.c (get_loops_exits): Likewise. > * tree-ssa-loop-niter.c (estimate_numbers_of_iterations): Likewise. > (free_numbers_of_iterations_estimates): Likewise. > * tree-ssa-loop-prefetch.c (tree_ssa_prefetch_arrays): Likewise. > * tree-ssa-loop-split.c (tree_ssa_split_loops): Likewise. > * tree-ssa-loop-unswitch.c (tree_ssa_unswitch_loops): Likewise. > * tree-ssa-loop.c (gate_oacc_kernels): Likewise. > (pass_scev_cprop::execute): Likewise. > * tree-ssa-propagate.c (clean_up_loop_closed_phi): Likewise. > * tree-ssa-sccvn.c (do_rpo_vn): Likewise. > * tree-ssa-threadupdate.c > (jump_thread_path_registry::thread_through_all_blocks): Likewise. > * tree-vectorizer.c (vectorize_loops): Likewise. > * tree-vrp.c (vrp_asserts::find_assert_locations): Likewise.