From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x630.google.com (mail-pl1-x630.google.com [IPv6:2607:f8b0:4864:20::630]) by sourceware.org (Postfix) with ESMTPS id 235C73858D39 for ; Wed, 8 Feb 2023 03:48:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 235C73858D39 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pl1-x630.google.com with SMTP id be8so17892304plb.7 for ; Tue, 07 Feb 2023 19:48:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=/Vlld0GxMwGXtL77rz881P6dhQLsZW9G8zqUNHp9eZg=; b=jd/BAN5TDNWdLAczUedGRedHUKNRwrus6mXzooklepXf6+eb0EdwfVDZHrGZe6Y5mq HSREmjfzLd7PnYQGOlvfKnw8OMgeuvkiEJ7BgulgzvTBAGJScs9BrtlDJAD11vNjxslB IF9DXxd/9MXozAd/PVUFfjKXRFyiCkq1V3VRXx7pvz1rJxTemyhD9s7u7nISlVmNfrBJ 0C7xRG8e0BvzGBkF38e7B/PE1yOFnzfSQE5fmS9qI+GrTL5HuoaMiRkhP+YD+xcvR6cz u5/5x4dKuqFleeKXYUBP2Zwl1rr1XEWLTBpUYV8is1NIIu/EGkZQxw6B5DIzgf5IbmRk D9Kg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/Vlld0GxMwGXtL77rz881P6dhQLsZW9G8zqUNHp9eZg=; b=FYwCfDYL5OPaHxllo83Y1s8iaIQKvgYXVb3D7FzF3OjegwrsF74ewnFxZvWgKGWDBC ZKRHLinP32BB/DQzelZn6hCA3n9JTDAYECnNFfBX1968TBh0T+sLb2YYkRn49Uztl43w T22yMfvTFLCiyooKBf9zuPMppToAN50iXgN41ENPLiA3sva6stnbI4u0aakyiJs0b17i euQFAtvElSYtyUJCAOgDxVY0TKKdj4phH6HYnpRbtSMwFdh3YugRVMdrtM7vCU6KzPh7 0yN41ZxD2uyFAgazJwNeUiltaUUyPjmHM1/gFMmvNiGe/d5u2JHcwqaVWHR82vs1thyw mrKg== X-Gm-Message-State: AO0yUKWaBXSPibCoFdihPGL3diP8/j65eo2DDdDkGL3sCEe4TiGw6RRZ 49fF9i520Bel4pbxqIUxwuF63eE87L3pshAV9/JjnXgP2wU= X-Google-Smtp-Source: AK7set8K9OPn1fX40i3c3nNLJXk5Tf9QYzj4nWxnN1oaZJu8escMM49AQQ6uOxKMfju+OO3cy+xbeZS4uQJWkKFaiIY= X-Received: by 2002:a17:90b:3610:b0:22c:1716:1c50 with SMTP id ml16-20020a17090b361000b0022c17161c50mr375063pjb.90.1675828122986; Tue, 07 Feb 2023 19:48:42 -0800 (PST) MIME-Version: 1.0 References: <7ee31afa-d5c5-3d34-85e6-6034165876de@redhat.com> In-Reply-To: <7ee31afa-d5c5-3d34-85e6-6034165876de@redhat.com> From: Andrew Pinski Date: Tue, 7 Feb 2023 19:48:30 -0800 Message-ID: Subject: Re: [pushed] [PR103541] RA: Implement reuse of equivalent memory for caller saves optimization To: Vladimir Makarov Cc: "gcc-patches@gcc.gnu.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,WEIRD_PORT autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, Feb 7, 2023 at 6:08 AM Vladimir Makarov via Gcc-patches wrote: > > The following patch solves > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D103541 > > The patch was successfully bootstrapped and tested on x86-64, aarch64, > and ppc64le. What languages did you test? Because I think I am getting a bootstrap failure while building libgo in 32bit x86 due to this patch. libtool: compile: /home/apinski/src/upstream-gcc-git/gcc/objdir/./gcc/gccgo -B/home/apinski/src/upstream-gcc-git/gcc/objdir/./gcc/ -B/home/apinski/upstream-gcc/x86_64-pc-linux-gnu/bin/ -B/home/apinski/upstream-gcc/x86_64-pc-linux-gnu/lib/ -isystem /home/apinski/upstream-gcc/x86_64-pc-linux-gnu/include -isystem /home/apinski/upstream-gcc/x86_64-pc-linux-gnu/sys-include -minline-all-stringops -O2 -g -m32 -I . -c -fgo-pkgpath=3Dreflect /home/apinski/src/upstream-gcc-git/gcc/libgo/go/reflect/deepequal.go /home/apinski/src/upstream-gcc-git/gcc/libgo/go/reflect/eqtype.go /home/apinski/src/upstream-gcc-git/gcc/libgo/go/reflect/makefunc.go /home/apinski/src/upstream-gcc-git/gcc/libgo/go/reflect/makefunc_ffi.go /home/apinski/src/upstream-gcc-git/gcc/libgo/go/reflect/swapper.go /home/apinski/src/upstream-gcc-git/gcc/libgo/go/reflect/type.go /home/apinski/src/upstream-gcc-git/gcc/libgo/go/reflect/value.go /home/apinski/src/upstream-gcc-git/gcc/libgo/go/reflect/visiblefields.go -fPIC -o .libs/reflect.o during RTL pass: reload /home/apinski/src/upstream-gcc-git/gcc/libgo/go/reflect/type.go: In function =E2=80=98reflect.rtype.Method=E2=80=99: /home/apinski/src/upstream-gcc-git/gcc/libgo/go/reflect/type.go:604:1: internal compiler error: in get_equiv, at lra-constraints.cc:534 604 | func (t *rtype) Method(i int) (m Method) { | ^ 0x7f9cfb get_equiv /home/apinski/src/upstream-gcc-git/gcc/gcc/lra-constraints.cc:534 0xde58d4 lra_constraints(bool) /home/apinski/src/upstream-gcc-git/gcc/gcc/lra-constraints.cc:5052 0xdd2532 lra(_IO_FILE*) /home/apinski/src/upstream-gcc-git/gcc/gcc/lra.cc:2375 0xd8a101 do_reload /home/apinski/src/upstream-gcc-git/gcc/gcc/ira.cc:5955 0xd8a101 execute /home/apinski/src/upstream-gcc-git/gcc/gcc/ira.cc:6141 Please submit a full bug report, with preprocessed source (by using -freport-bug). Please include the complete backtrace with any bug report. See for instructions. Makefile:3043: recipe for target 'reflect.lo' failed make[7]: *** [reflect.lo] Error 1 Thanks, Andrew Pinski