From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 084A33858425 for ; Tue, 20 Dec 2022 16:56:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 084A33858425 Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=gmail.com Received: from mail-pj1-x102e.google.com ([2607:f8b0:4864:20::102e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p7fuB-0000S6-DG for gcc-patches@gcc.gnu.org; Tue, 20 Dec 2022 11:56:04 -0500 Received: by mail-pj1-x102e.google.com with SMTP id t11-20020a17090a024b00b0021932afece4so17062420pje.5 for ; Tue, 20 Dec 2022 08:55:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=gnVxhtD7fQBOfZ6hVeSwlgri2nWJ6iuhCd5jNdH6q+I=; b=bXFa1TKAg3d174X8dXXv+LWDf2r9oNrxaR1EkHDE9ltIqBIjHxfpO07/OkTJNDe/ig wOac6774xZ53y6qiR9zavauli+5PTEY62V9B+3VH02FRb9+UnuF4SE7v1WgTKEky7Gz2 +ej/y76eVhIz8gKgFibotXrx55XEXgehqHggfaWaIf9/zyoW5Hpqwra0yuiZso5qfcCu w+i62OLj1XvzhKnRdFMufpJQYAY2ryacy96dr2DOYEqIqCFkdEJckvfU6zk9p9jxOzJS i8tPgTpQ93em5YJQYFFy3gB6+8nMR49k0tpRUvuhC1c2XUsF/XgZDiabwE2XGkTQDO/X GtaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=gnVxhtD7fQBOfZ6hVeSwlgri2nWJ6iuhCd5jNdH6q+I=; b=EoG1pHJ3r4VVsJRqoddoxTcECLcpFs2WJuIOAg7ILS/tZ5C5sYJXjO9kPdJGzRYHlo RdlKQZsCQw7E1k0t1QRmm91oLiD6/vK1HsM5YXNFNddipBgdruJ1YG6vC4Wpa6EmxY5w aHx2Vs/kOfmAEH3ZZmSNJlWUfDmXT/ML9LtVnjC2PmuN+n/Vw4pMOkOu85H1taxAh68P lS6u6/AnL9srE/5C3IjcehhkeOg9GVv4CJoxKjLLauzYUz1PE0PD+enLcG3yn16+dBah O3zCO07OvVI4DTorApedJyoSJvMrNQnVBe5h1CwRevMWszKR3qCJxFwD+XbGbdOEdBke WOEg== X-Gm-Message-State: AFqh2kp1hV6sRcisJjNjxtmw0wwA5RutzWlOqB1blf+ZBOQ1Cmn54e59 xZ/YjtK3nKQJb48dC17r2iFoqdaw9ZyLt2SIxEc= X-Google-Smtp-Source: AMrXdXuU5Sx24lyjn+huHQgMc638xyhZBzk00UfQuEpMzF3dClLlY8JSi0zznrqWkRzmb9ZNodVVrlpF2W30R20Sq0c= X-Received: by 2002:a17:90b:701:b0:219:1d0a:34a6 with SMTP id s1-20020a17090b070100b002191d0a34a6mr37944pjz.1.1671555315827; Tue, 20 Dec 2022 08:55:15 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Andrew Pinski Date: Tue, 20 Dec 2022 08:55:04 -0800 Message-ID: Subject: Re: testsuite: Fix pr55569.c excess errors To: Jonathan Yong <10walls@gmail.com> Cc: Gcc Patch List Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2607:f8b0:4864:20::102e; envelope-from=pinskia@gmail.com; helo=mail-pj1-x102e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9,DKIM_SIGNED=0.1,DKIM_VALID=-0.1,DKIM_VALID_AU=-0.1,DKIM_VALID_EF=-0.1,FREEMAIL_FROM=0.001,RCVD_IN_DNSWL_NONE=-0.0001,SPF_HELO_NONE=0.001,SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Status: No, score=-1.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,SPF_HELO_PASS,SPF_SOFTFAIL,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, Dec 20, 2022 at 1:22 AM Jonathan Yong via Gcc-patches wrote: > > This fixes the following: It is not obvious from the email, why this patch is needed but I figured it was due to LLP64 targets or some other targets where long is not the same size of the size_t type. I think this patch is good but I cannot approve it. The commit message should be improved to make a mention of LLP64 targets and long being a smaller size than size_t. Thanks, Andrew > > Excess errors: > > gcc/testsuite/gcc.c-torture/compile/pr55569.c:13:12: warning: overflow > in conversion from 'long long unsigned int' to 'long int' changes value > from '4611686018427387903' to '-1' [-Woverflow] > > gcc/testsuite/gcc.c-torture/compile/pr55569.c:13:34: warning: iteration > 2147483647 invokes undefined behavior [-Waggressive-loop-optimizations] > > Patch OK?