public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Andrew Pinski <pinskia@gmail.com>
To: YunQiang Su <syq@gcc.gnu.org>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] install: Correct check-g++ to check-gcc-c++
Date: Sat, 30 Dec 2023 23:37:41 -0800	[thread overview]
Message-ID: <CA+=Sn1ms4jXCkqbud0kjB7JKN5EiW9eBRnRRYO2zjJCqFhr4hQ@mail.gmail.com> (raw)
In-Reply-To: <20231231072524.1816878-1-syq@gcc.gnu.org>

On Sat, Dec 30, 2023 at 11:26 PM YunQiang Su <syq@gcc.gnu.org> wrote:
>
> make: *** No rule to make target 'check-g++'.  Stop.
>
> gcc
>
>         * doc/install.texi (Testing): Correct check-g++ to
>         check-gcc-c++.

Actually these targets exist in the gcc subdirectory.
Which is mentioned slightly above:
```
In order to run sets of tests selectively, there are targets
@samp{make check-gcc} and language specific @samp{make check-c},
@samp{make check-c++}, @samp{make check-d} @samp{make check-fortran},
@samp{make check-ada}, @samp{make check-m2}, @samp{make check-objc},
@samp{make check-obj-c++}, @samp{make check-lto} in the @file{gcc}
subdirectory of the object directory.
```

Though maybe it should be clear that these make targets are talking
about the targets in the gcc subdirectory rather than from the
toplevel.

Thanks,
Andrew Pinski


> ---
>  gcc/doc/install.texi | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/gcc/doc/install.texi b/gcc/doc/install.texi
> index d20b43a5b21..cff4d0cd71f 100644
> --- a/gcc/doc/install.texi
> +++ b/gcc/doc/install.texi
> @@ -3345,7 +3345,7 @@ Likewise, in order to run only the @command{g++} ``old-deja'' tests in
>  the testsuite with filenames matching @samp{9805*}, you would use
>
>  @smallexample
> -make check-g++ RUNTESTFLAGS="old-deja.exp=9805* @var{other-options}"
> +make check-gcc-c++ RUNTESTFLAGS="old-deja.exp=9805* @var{other-options}"
>  @end smallexample
>
>  The file-matching expression following @var{filename}@command{.exp=} is treated
> @@ -3354,8 +3354,8 @@ may be passed, although any whitespace must either be escaped or surrounded by
>  single quotes if multiple expressions are desired. For example,
>
>  @smallexample
> -make check-g++ RUNTESTFLAGS="old-deja.exp=9805*\ virtual2.c @var{other-options}"
> -make check-g++ RUNTESTFLAGS="'old-deja.exp=9805* virtual2.c' @var{other-options}"
> +make check-gcc-c++ RUNTESTFLAGS="old-deja.exp=9805*\ virtual2.c @var{other-options}"
> +make check-gcc-c++ RUNTESTFLAGS="'old-deja.exp=9805* virtual2.c' @var{other-options}"
>  @end smallexample
>
>  The @file{*.exp} files are located in the testsuite directories of the GCC
> @@ -3373,7 +3373,7 @@ You can pass multiple options to the testsuite using the
>  work outside the makefiles.  For example,
>
>  @smallexample
> -make check-g++ RUNTESTFLAGS="--target_board=unix/-O3/-fmerge-constants"
> +make check-gcc-c++ RUNTESTFLAGS="--target_board=unix/-O3/-fmerge-constants"
>  @end smallexample
>
>  will run the standard @command{g++} testsuites (``unix'' is the target name
> --
> 2.39.2
>

      reply	other threads:[~2023-12-31  7:37 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-31  7:25 YunQiang Su
2023-12-31  7:37 ` Andrew Pinski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CA+=Sn1ms4jXCkqbud0kjB7JKN5EiW9eBRnRRYO2zjJCqFhr4hQ@mail.gmail.com' \
    --to=pinskia@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=syq@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).