From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x62c.google.com (mail-pl1-x62c.google.com [IPv6:2607:f8b0:4864:20::62c]) by sourceware.org (Postfix) with ESMTPS id 947A53858C98; Sun, 31 Dec 2023 07:37:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 947A53858C98 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 947A53858C98 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::62c ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704008277; cv=none; b=KpJrcHEuk4RJ4ZeR6ChIi65gFS14gBJCgnFj+YbdH1L/aPyHFn6KgNETHVX6Qc4QDHNrisWkequwWAyjjSlbdtDsdO8h3o1kZ2l8gXJdioB+oLY8lheqNSmENoTsdHfWP0BziaCFscqEQGklpVuMzruQy5yfl4/zmgK2EY+xL+c= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704008277; c=relaxed/simple; bh=zr4QAUKHHjZ9FlrhumB9Wi/gr1Dk+7FkFOcsqPeIzyc=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=lEVNDt8LKQdUjqDfax1SPKTRBoC6ozjJNhC91YsevRGsIGAClr+b5QbwirHN+6Q1WFw4Xox4ISIaaNT/O8WNqW224fxgbqDMm9SkjHGhudEJP/2MsUEy5s0oJY2L/tP0A5a5hQRrJduQUVVLl1pjWEZlpSuqMw1PO7BXyaYl91M= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pl1-x62c.google.com with SMTP id d9443c01a7336-1d3e84fded7so38577365ad.1; Sat, 30 Dec 2023 23:37:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704008273; x=1704613073; darn=gcc.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=45qDtNoyjTZVPmZteWELLCFnqCIoalMqMM3yQhpO/Cs=; b=GuegKS27xds4VHIlDOvGG1PS4o4eZWbAv/LkxzS9qxpXmYC4T8EoV5EqyxGoaL+Exh nBntJq+agf/imQPG5z8v+xZ0HRgvvamW7TiMgOMFGh0QSQx+36hdqF/DnIhUswosWaC5 FW/HxAdcyzzNjrR2yy/iPTL92C+DSeMRAbNZFcF5DknMeFuNL4sN8kRpu1iaPDRTbfLi gSbZsG25iuZmKAPPco+58knuH9qbphKgA4RDtEGGMSvBVD/WJqsixED82Yw8akaunWGF 5UOSqMHZixXVN7UcGlJ0i4KfYo9qR7Y9Snr0P8p6f3a4ps6Sw5lQiyD5PEFJVw7hiT0k patg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704008273; x=1704613073; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=45qDtNoyjTZVPmZteWELLCFnqCIoalMqMM3yQhpO/Cs=; b=aT6pnrxlVkwtzCc/BNmC0G/Rz+krTiLvPD4zgD4hwFmFQ+6MyukpJsxRlxUqkbxiua otHIWxpO4JMA91Felf4Hu8Qpof/LPfHIM+mXNkkyg4oVM61PrMs0V+4ek204Z/5Z54X4 YcC6lAEV2BpZKBaG4c8XftPyT7USYNwg3PGih2/4H40jUKJLHBNapWJohfalub+9fQML G6wnqHXzpO1zbkKqfMSgW19w3QoZOSzN0hd0f1nhsgf5Fct1bqmyvSRgyg+yryqf2GuY 8YvNQbACXxKAxmiXZEnkoE6NHGQdjSwbVMGQFEvIvRLIKu+zcHJCz5uDJvjxO5x/C+dy V2LQ== X-Gm-Message-State: AOJu0YwEYLizmnHDXaH4V5fqp0wp4LO6o8de/PteIV1cwZhy8Zx8Xc1D RiyEAt5zaiTIj+Z6RHJIPmZEq3ImXX5L1chVLY/D8Wrn/B0= X-Google-Smtp-Source: AGHT+IHXfqrEQbxfxe1VO2+0XCp2V07e9wdmm9G1XY2kmbr476l61OlZGl+xzteSyWoPOh7d76HAWKEIRUzhfsFNNWE= X-Received: by 2002:a17:90a:c38b:b0:28b:f58e:f4ce with SMTP id h11-20020a17090ac38b00b0028bf58ef4cemr4823359pjt.24.1704008272979; Sat, 30 Dec 2023 23:37:52 -0800 (PST) MIME-Version: 1.0 References: <20231231072524.1816878-1-syq@gcc.gnu.org> In-Reply-To: <20231231072524.1816878-1-syq@gcc.gnu.org> From: Andrew Pinski Date: Sat, 30 Dec 2023 23:37:41 -0800 Message-ID: Subject: Re: [PATCH] install: Correct check-g++ to check-gcc-c++ To: YunQiang Su Cc: gcc-patches@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-7.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Sat, Dec 30, 2023 at 11:26=E2=80=AFPM YunQiang Su wrot= e: > > make: *** No rule to make target 'check-g++'. Stop. > > gcc > > * doc/install.texi (Testing): Correct check-g++ to > check-gcc-c++. Actually these targets exist in the gcc subdirectory. Which is mentioned slightly above: ``` In order to run sets of tests selectively, there are targets @samp{make check-gcc} and language specific @samp{make check-c}, @samp{make check-c++}, @samp{make check-d} @samp{make check-fortran}, @samp{make check-ada}, @samp{make check-m2}, @samp{make check-objc}, @samp{make check-obj-c++}, @samp{make check-lto} in the @file{gcc} subdirectory of the object directory. ``` Though maybe it should be clear that these make targets are talking about the targets in the gcc subdirectory rather than from the toplevel. Thanks, Andrew Pinski > --- > gcc/doc/install.texi | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/gcc/doc/install.texi b/gcc/doc/install.texi > index d20b43a5b21..cff4d0cd71f 100644 > --- a/gcc/doc/install.texi > +++ b/gcc/doc/install.texi > @@ -3345,7 +3345,7 @@ Likewise, in order to run only the @command{g++} ``= old-deja'' tests in > the testsuite with filenames matching @samp{9805*}, you would use > > @smallexample > -make check-g++ RUNTESTFLAGS=3D"old-deja.exp=3D9805* @var{other-options}" > +make check-gcc-c++ RUNTESTFLAGS=3D"old-deja.exp=3D9805* @var{other-optio= ns}" > @end smallexample > > The file-matching expression following @var{filename}@command{.exp=3D} i= s treated > @@ -3354,8 +3354,8 @@ may be passed, although any whitespace must either = be escaped or surrounded by > single quotes if multiple expressions are desired. For example, > > @smallexample > -make check-g++ RUNTESTFLAGS=3D"old-deja.exp=3D9805*\ virtual2.c @var{oth= er-options}" > -make check-g++ RUNTESTFLAGS=3D"'old-deja.exp=3D9805* virtual2.c' @var{ot= her-options}" > +make check-gcc-c++ RUNTESTFLAGS=3D"old-deja.exp=3D9805*\ virtual2.c @var= {other-options}" > +make check-gcc-c++ RUNTESTFLAGS=3D"'old-deja.exp=3D9805* virtual2.c' @va= r{other-options}" > @end smallexample > > The @file{*.exp} files are located in the testsuite directories of the G= CC > @@ -3373,7 +3373,7 @@ You can pass multiple options to the testsuite usin= g the > work outside the makefiles. For example, > > @smallexample > -make check-g++ RUNTESTFLAGS=3D"--target_board=3Dunix/-O3/-fmerge-constan= ts" > +make check-gcc-c++ RUNTESTFLAGS=3D"--target_board=3Dunix/-O3/-fmerge-con= stants" > @end smallexample > > will run the standard @command{g++} testsuites (``unix'' is the target n= ame > -- > 2.39.2 >