From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x531.google.com (mail-pg1-x531.google.com [IPv6:2607:f8b0:4864:20::531]) by sourceware.org (Postfix) with ESMTPS id 087F13858D1E; Mon, 17 Jul 2023 07:31:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 087F13858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pg1-x531.google.com with SMTP id 41be03b00d2f7-53fa455cd94so2355335a12.2; Mon, 17 Jul 2023 00:31:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1689579074; x=1692171074; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=QR8j5+YxrWsQRkfAc730MDV8cPBTjfX50PnV+e/TjTE=; b=SPaQXlUKyEjitc7MCKaAEJtfPAFlwALt31E7YB7WR/aGx01Xum07bmBRddNIg5ZHsz /6sNoAxO/uBnuAn/RRjRauCmOxgMklbGdYUsnkim4VBIH3vTO/k6dTqHIi5f0V7jspS+ kPubpPNREJ+rln5GxqJ2iQUuVaCrL7ROsKD1kIXlFkjIcfxjduJYETuAcCejdl+v5Htw IbzdH5pP5LxbSx0SI0uU58aUwBVYXyuBeEEVZ/MAM1qx7ge3KYRwTP11QR88PIMVQd3s K85Inii7h9X9O3c814G38JVARDzoti+WxvjOlMsxNJPvhy3nB50s6e14j1QBtgIk1ICG niyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689579074; x=1692171074; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QR8j5+YxrWsQRkfAc730MDV8cPBTjfX50PnV+e/TjTE=; b=dzrZDvq1LbI+YK9PCHLCoKJ3O1CykUIwheqB4I61XlDSPkcmb4nH4g/YSxsTZOvmk9 T9QVfB9NhfLPXHLiqTx2v8KpGJoOF2I+XBvML2Y90W2MWLuaEzSoiu7mH7/Ei1PikSkJ sYygRK+uzBxY8m80Ks0D+OjXaX+oenrO6u9UrlTiISOcivmONO3BGxJYpfyhf1cqRjXR umjsYFTKFioNq7sTmXXeQjKgdhtXfNtgwlVCqBgVuUr0U5i46JNoTDAJSY83U4h3WTW9 D7VlCHpC8hy72/A+sQy4jquV4PB1k9fFrFtS3HJxN+DTGeLF4QfwvU9Xi1xWeqGPYjrP yQjw== X-Gm-Message-State: ABy/qLZMbWcE7Pa6HDDvQf66nFuu8GY3vJ/TNTxPRso1UHa4cQyCZYoV ewwxpCcx8Kc/Q/9fGD2ZInbnkFhVI6oM/HlnWvbFr5aE X-Google-Smtp-Source: APBJJlGZ0mIeW6WjhTRHR4xQc6e2ihzrvjmwUZj/k0PuUOcASPPeNPKuhdkLLJCEMZAEDXTJfuIBRPbV71er4nrYfvg= X-Received: by 2002:a17:90b:38cf:b0:256:857f:823d with SMTP id nn15-20020a17090b38cf00b00256857f823dmr8356005pjb.48.1689579073789; Mon, 17 Jul 2023 00:31:13 -0700 (PDT) MIME-Version: 1.0 References: <20230712081314.F1263385800C@sourceware.org> <87351qpz1c.fsf@igel.home> In-Reply-To: From: Andrew Pinski Date: Mon, 17 Jul 2023 00:31:02 -0700 Message-ID: Subject: Re: [gcc r14-2455] riscv: Prepare backend for index registers To: =?UTF-8?Q?Christoph_M=C3=BCllner?= Cc: Andreas Schwab , Kito Cheng , gcc-patches@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Sun, Jul 16, 2023 at 11:49=E2=80=AFPM Christoph M=C3=BCllner wrote: > > On Fri, Jul 14, 2023 at 12:28=E2=80=AFPM Andreas Schwab wrote: > > > > Why didn't you test that? > > Thanks for reporting, and sorry for introducing this warning. > > I test all patches before sending them. > In the case of RISC-V backend patches, I build a 2-stage > cross-toolchain and run all regression tests for RV32 and RV64 (using > QEMU). > Testing is done with and without patches applied to identify regressions. > > The build process shows a lot of warnings. Therefore I did not > investigate finding a way to use -Werror. > This means that looking for compiler warnings is a manual step, and I > might miss one while scrolling through the logs. If you are building a cross compiler, and want to clean up warnings, first build a native compiler and then build the cross using that. Also maybe it is finding a way to do native bootstraps on riscv to do testing of patches rather than doing just cross builds when testing backend patches. Especially when I have found the GCC testsuite but the bootstrap is more likely to find backend issues and such. Thanks, Andrew > > Sorry for the inconvenience, > Christoph > > > > > > ../../gcc/config/riscv/riscv.cc: In function 'int riscv_regno_ok_for_in= dex_p(int)': > > ../../gcc/config/riscv/riscv.cc:864:33: error: unused parameter 'regno'= [-Werror=3Dunused-parameter] > > 864 | riscv_regno_ok_for_index_p (int regno) > > | ~~~~^~~~~ > > cc1plus: all warnings being treated as errors > > make[3]: *** [Makefile:2499: riscv.o] Error 1 > > > > -- > > Andreas Schwab, schwab@linux-m68k.org > > GPG Key fingerprint =3D 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA A= EC1 > > "And now for something completely different."