From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pinskia@gmail.com>
Received: from mail-pg1-x534.google.com (mail-pg1-x534.google.com [IPv6:2607:f8b0:4864:20::534])
	by sourceware.org (Postfix) with ESMTPS id 7532C385840E
	for <gcc-patches@gcc.gnu.org>; Tue,  1 Nov 2022 20:04:30 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7532C385840E
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com
Received: by mail-pg1-x534.google.com with SMTP id s196so14369950pgs.3
        for <gcc-patches@gcc.gnu.org>; Tue, 01 Nov 2022 13:04:30 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:from:to:cc:subject:date:message-id:reply-to;
        bh=hkVpCdwgPrgl8Abs1GAXtYSNgc8orwlqkh68+BDl83s=;
        b=QFGxaYepwxqZvMGr6ITelrNCfHyk2IMEIuIRd3RR+J+qER/fa4/sDZBsnzummBZB3p
         e1l9CtvVF1/BiME4UMf+Ye9z7gBCPCIBnHSBLRomsyXUE4yY9gM85CUHe7lXpn6InVPa
         aMYFjovluLweko+gXOXWYo+R8NQVK91W1U7KVT/rwrd6bLu82n5WUU5g/v255/PQH2o4
         yeUkfOSndTI9bA6eFa9WvjD8eLjyzEQokHRqAMO9qECoEqBAFKG31Vt+AJNksng/A6s4
         uo46rm9jPHmPj+LloYFW6V31CnPLbIg6AXvcOtGVdFR92Fe2qe3l9LQ4W571QfARwIov
         Tvqg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=cc:to:subject:message-id:date:from:in-reply-to:references
         :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
         :reply-to;
        bh=hkVpCdwgPrgl8Abs1GAXtYSNgc8orwlqkh68+BDl83s=;
        b=GridpgvXVroMqEKZWOTUac7+26MTL9CKWtnqsjE0SmVMxi8yq9G4vdGsamj2gIR3If
         kCuOTJVzOakCTsEW96u7ML2b4YNOzBWOeINhPSq2sz2/nKtIvnt5oC+b7ALM5KQUjfoA
         3E93x2VXm3Bnm2/9v3pRsv/5sGwnbaIyRQWduSNRN7IBhvU7u78ekwL6MllqqQwyPYcF
         7G0vx8lq6dBXLEI2pIPl2f8EV7PwFySqPQJTiGaPcV2+oLSQeT0LcB07XrorgXOyskE4
         I+Ch/oXzjieInhEhPJ27BznePOUhkW74hnPIJEJdhcDQOiKjiayy6+qeNkhJjtz3UmbR
         A2YA==
X-Gm-Message-State: ACrzQf1z7qZe0h4Qe5THjjLPyrqkiaioptL/fOUOGQ4Nv/mLZrjcG9vD
	uTKBmzF/d/PNJmWpl4RjUR9moxM6v3cU0e4iK6y30eMC
X-Google-Smtp-Source: AMsMyM4EW/XcvD69YS/NWv4Z/g1C4Jk0SC2Uwmd7opCBM+2l9F+dslhfEXOr4PvLcmIfP8M4pH6tTOHCPpmZKAro7vE=
X-Received: by 2002:a63:8841:0:b0:461:24b7:a621 with SMTP id
 l62-20020a638841000000b0046124b7a621mr18794444pgd.277.1667333069292; Tue, 01
 Nov 2022 13:04:29 -0700 (PDT)
MIME-Version: 1.0
References: <3b938af0-7978-2646-80d9-b39ed2d04ba1@arm.com>
In-Reply-To: <3b938af0-7978-2646-80d9-b39ed2d04ba1@arm.com>
From: Andrew Pinski <pinskia@gmail.com>
Date: Tue, 1 Nov 2022 13:04:17 -0700
Message-ID: <CA+=Sn1n3_2VF-ovOnMFqEHMkw9BHxq6Ea+zqGVUa1qR9+NbNig@mail.gmail.com>
Subject: Re: [PATCH 1/2][GCC][AArch64] Implement hint intrinsics for AArch64
To: Srinath Parvathaneni <Srinath.Parvathaneni@arm.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>, nd <nd@arm.com>, 
	Richard Earnshaw <Richard.Earnshaw@arm.com>, James Greenhalgh <James.Greenhalgh@arm.com>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_NUMSUBJECT,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <gcc-patches.gcc.gnu.org>

On Thu, Jan 10, 2019 at 11:20 AM Srinath Parvathaneni
<Srinath.Parvathaneni@arm.com> wrote:
>
> Hi All,
>
> This patch implements the ACLE hint intrinsics (nop, yield, wfe, wfi,
> sev and sevl), for AArch64.

Hmm, this (and the corresponding arm patch) was never reviewed.
It might be useful to get an updated version which could be reviewed
and merged in for GCC 13.

Thanks,
Andrew

>
> The instructions are documented in the ArmARM[1] and the intrinsics
> specification will be
> published on the Arm website [2].
>
> [1]
> https://developer.arm.com/docs/ddi0487/latest/arm-architecture-reference-manual-armv8-for-armv8-a-architecture-profile
> [2]
> http://infocenter.arm.com/help/topic/com.arm.doc.ihi0053c/IHI0053C_acle_2_0.pdf
>
> Bootstrapped on aarch64-none-linux-gnu and regression tested on
> aarch64-none-elf with no regressions.
>
> Ok for trunk? If ok, could someone commit the patch on my behalf, I
> don't have commit rights.
>
> Thanks,
> Srinath
>
> gcc/ChangeLog:
>
> 2019-01-10  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
>
>         * config/aarch64/aarch64.md (yield): New pattern name.
>         (wfe): Likewise.
>         (wfi): Likewise.
>         (sev): Likewise.
>         (sevl): Likewise.
>         (UNSPECV_YIELD): New volatile unspec.
>         (UNSPECV_WFE): Likewise.
>         (UNSPECV_WFI): Likewise.
>         (UNSPECV_SEV): Likewise.
>         (UNSPECV_SEVL): Likewise.
>         * config/aarch64/aarch64-builtins.c (aarch64_builtins):
>         AARCH64_SYSHINTOP_BUILTIN_NOP: New builtin.
>         AARCH64_SYSHINTOP_BUILTIN_YIELD: Likewise.
>         AARCH64_SYSHINTOP_BUILTIN_WFE: Likewise.
>         AARCH64_SYSHINTOP_BUILTIN_WFI: Likewise.
>         AARCH64_SYSHINTOP_BUILTIN_SEV: Likewise.
>         AARCH64_SYSHINTOP_BUILTIN_SEVL: Likewise.
>         (aarch64_init_syshintop_builtins): New function.
>         (aarch64_init_builtins): New call statement.
>         (aarch64_expand_builtin): New case.
>         * config/aarch64/arm_acle.h (__nop ): New inline function.
>         (__yield): Likewise.
>         (__sev): Likewise.
>         (__sevl): Likewise.
>         (__wfi): Likewise.
>         (__wfe): Likewise.
>
> gcc/testsuite/ChangeLog:
>
> 2019-01-10  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
>
>         * gcc.target/aarch64/acle/hint-1.c: New test.
>         * gcc.target/aarch64/acle/hint-2.c: Likewise.
>
>
>
>
>
>