From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12909 invoked by alias); 18 Aug 2012 04:17:36 -0000 Received: (qmail 12900 invoked by uid 22791); 18 Aug 2012 04:17:33 -0000 X-SWARE-Spam-Status: No, hits=-4.2 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,KHOP_RCVD_TRUST,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE X-Spam-Check-By: sourceware.org Received: from mail-we0-f175.google.com (HELO mail-we0-f175.google.com) (74.125.82.175) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 18 Aug 2012 04:17:20 +0000 Received: by weyr6 with SMTP id r6so3134244wey.20 for ; Fri, 17 Aug 2012 21:17:18 -0700 (PDT) MIME-Version: 1.0 Received: by 10.180.105.163 with SMTP id gn3mr10908045wib.2.1345263438794; Fri, 17 Aug 2012 21:17:18 -0700 (PDT) Received: by 10.216.2.4 with HTTP; Fri, 17 Aug 2012 21:17:18 -0700 (PDT) Date: Sat, 18 Aug 2012 04:17:00 -0000 Message-ID: Subject: [PATCH] Add valgrind support to alloc-pool.c From: Andrew Pinski To: GCC Patches Content-Type: multipart/mixed; boundary=f46d0442846666115904c7828d1f X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2012-08/txt/msg01227.txt.bz2 --f46d0442846666115904c7828d1f Content-Type: text/plain; charset=UTF-8 Content-length: 367 Hi, I implemented this patch almost 6 years ago when the df branch was being worked on. It adds valgrind support to alloc-pool.c to catch cases of using memory after free the memory. OK? Bootstrapped and tested on x86_64-linux-gnu with no regressions. Thanks, Andrew Pinski ChangeLog: * alloc-pool.c (pool_alloc): Add valgrind markers. (pool_free): Likewise. --f46d0442846666115904c7828d1f Content-Type: text/plain; charset=US-ASCII; name="implement-alloc-pool-valgrind.diff.txt" Content-Disposition: attachment; filename="implement-alloc-pool-valgrind.diff.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_h606y9360 Content-length: 3339 SW5kZXg6IGFsbG9jLXBvb2wuYwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBhbGxvYy1wb29sLmMJKHJldmlzaW9uIDE5MDUwMCkKKysrIGFsbG9jLXBv b2wuYwkod29ya2luZyBjb3B5KQpAQCAtMjQ3LDYgKzI0Nyw3IEBAIHZvaWQg KgogcG9vbF9hbGxvYyAoYWxsb2NfcG9vbCBwb29sKQogewogICBhbGxvY19w b29sX2xpc3QgaGVhZGVyOworICBWQUxHUklORF9ESVNDQVJEIChpbnQgc2l6 ZSk7CiAKICAgaWYgKEdBVEhFUl9TVEFUSVNUSUNTKQogICAgIHsKQEAgLTI1 OSw2ICsyNjAsNyBAQCBwb29sX2FsbG9jIChhbGxvY19wb29sIHBvb2wpCiAg ICAgfQogCiAgIGdjY19jaGVja2luZ19hc3NlcnQgKHBvb2wpOworICBWQUxH UklORF9ESVNDQVJEIChzaXplID0gcG9vbC0+ZWx0X3NpemUgLSBvZmZzZXRv ZiAoYWxsb2NhdGlvbl9vYmplY3QsIHUuZGF0YSkpOwogCiAgIC8qIElmIHRo ZXJlIGFyZSBubyBtb3JlIGZyZWUgZWxlbWVudHMsIG1ha2Ugc29tZSBtb3Jl IS4gICovCiAgIGlmICghcG9vbC0+cmV0dXJuZWRfZnJlZV9saXN0KQpAQCAt Mjk4LDYgKzMwMCw3IEBAIHBvb2xfYWxsb2MgKGFsbG9jX3Bvb2wgcG9vbCkK ICAgICAgIC8qIE1hcmsgdGhlIGVsZW1lbnQgdG8gYmUgZnJlZS4gICovCiAg ICAgICAoKGFsbG9jYXRpb25fb2JqZWN0ICopIGJsb2NrKS0+aWQgPSAwOwog I2VuZGlmCisgICAgICBWQUxHUklORF9ESVNDQVJEIChWQUxHUklORF9NQUtF X01FTV9OT0FDQ0VTUyAoaGVhZGVyLHNpemUpKTsKICAgICAgIHBvb2wtPnJl dHVybmVkX2ZyZWVfbGlzdCA9IGhlYWRlcjsKICAgICAgIHBvb2wtPnZpcmdp bl9mcmVlX2xpc3QgKz0gcG9vbC0+ZWx0X3NpemU7CiAgICAgICBwb29sLT52 aXJnaW5fZWx0c19yZW1haW5pbmctLTsKQEAgLTMwNiw2ICszMDksNyBAQCBw b29sX2FsbG9jIChhbGxvY19wb29sIHBvb2wpCiAKICAgLyogUHVsbCB0aGUg Zmlyc3QgZnJlZSBlbGVtZW50IGZyb20gdGhlIGZyZWUgbGlzdCwgYW5kIHJl dHVybiBpdC4gICovCiAgIGhlYWRlciA9IHBvb2wtPnJldHVybmVkX2ZyZWVf bGlzdDsKKyAgVkFMR1JJTkRfRElTQ0FSRCAoVkFMR1JJTkRfTUFLRV9NRU1f REVGSU5FRCAoaGVhZGVyLCBzaXplb2YoKmhlYWRlcikpKTsKICAgcG9vbC0+ cmV0dXJuZWRfZnJlZV9saXN0ID0gaGVhZGVyLT5uZXh0OwogICBwb29sLT5l bHRzX2ZyZWUtLTsKIApAQCAtMzEzLDYgKzMxNyw3IEBAIHBvb2xfYWxsb2Mg KGFsbG9jX3Bvb2wgcG9vbCkKICAgLyogU2V0IHRoZSBJRCBmb3IgZWxlbWVu dC4gICovCiAgIEFMTE9DQVRJT05fT0JKRUNUX1BUUl9GUk9NX1VTRVJfUFRS IChoZWFkZXIpLT5pZCA9IHBvb2wtPmlkOwogI2VuZGlmCisgIFZBTEdSSU5E X0RJU0NBUkQgKFZBTEdSSU5EX01BS0VfTUVNX1VOREVGSU5FRCAoaGVhZGVy LCBzaXplKSk7CiAKICAgcmV0dXJuICgodm9pZCAqKSBoZWFkZXIpOwogfQpA QCAtMzIyLDYgKzMyNywxMCBAQCB2b2lkCiBwb29sX2ZyZWUgKGFsbG9jX3Bv b2wgcG9vbCwgdm9pZCAqcHRyKQogewogICBhbGxvY19wb29sX2xpc3QgaGVh ZGVyOworI2lmIGRlZmluZWQoRU5BQkxFX1ZBTEdSSU5EX0NIRUNLSU5HKSB8 fCBkZWZpbmVkKEVOQUJMRV9DSEVDS0lORykKKyAgaW50IHNpemU7CisgIHNp emUgPSBwb29sLT5lbHRfc2l6ZSAtIG9mZnNldG9mIChhbGxvY2F0aW9uX29i amVjdCwgdS5kYXRhKTsKKyNlbmRpZgogCiAjaWZkZWYgRU5BQkxFX0NIRUNL SU5HCiAgIGdjY19hc3NlcnQgKHB0cgpAQCAtMzMwLDcgKzMzOSw3IEBAIHBv b2xfZnJlZSAoYWxsb2NfcG9vbCBwb29sLCB2b2lkICpwdHIpCiAJICAgICAg LyogQ2hlY2sgd2hldGhlciB0aGUgUFRSIHdhcyBhbGxvY2F0ZWQgZnJvbSBQ T09MLiAgKi8KIAkgICAgICAmJiBwb29sLT5pZCA9PSBBTExPQ0FUSU9OX09C SkVDVF9QVFJfRlJPTV9VU0VSX1BUUiAocHRyKS0+aWQpOwogCi0gIG1lbXNl dCAocHRyLCAweGFmLCBwb29sLT5lbHRfc2l6ZSAtIG9mZnNldG9mIChhbGxv Y2F0aW9uX29iamVjdCwgdS5kYXRhKSk7CisgIG1lbXNldCAocHRyLCAweGFm LCBzaXplKTsKIAogICAvKiBNYXJrIHRoZSBlbGVtZW50IHRvIGJlIGZyZWUu ICAqLwogICBBTExPQ0FUSU9OX09CSkVDVF9QVFJfRlJPTV9VU0VSX1BUUiAo cHRyKS0+aWQgPSAwOwpAQCAtMzM5LDYgKzM0OCw3IEBAIHBvb2xfZnJlZSAo YWxsb2NfcG9vbCBwb29sLCB2b2lkICpwdHIpCiAgIGhlYWRlciA9IChhbGxv Y19wb29sX2xpc3QpIHB0cjsKICAgaGVhZGVyLT5uZXh0ID0gcG9vbC0+cmV0 dXJuZWRfZnJlZV9saXN0OwogICBwb29sLT5yZXR1cm5lZF9mcmVlX2xpc3Qg PSBoZWFkZXI7CisgIFZBTEdSSU5EX0RJU0NBUkQgKFZBTEdSSU5EX01BS0Vf TUVNX05PQUNDRVNTIChwdHIsIHNpemUpKTsKICAgcG9vbC0+ZWx0c19mcmVl Kys7CiAKICAgaWYgKEdBVEhFUl9TVEFUSVNUSUNTKQo= --f46d0442846666115904c7828d1f--