From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x42a.google.com (mail-pf1-x42a.google.com [IPv6:2607:f8b0:4864:20::42a]) by sourceware.org (Postfix) with ESMTPS id 554213858C2F for ; Thu, 10 Nov 2022 01:21:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 554213858C2F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pf1-x42a.google.com with SMTP id v28so388223pfi.12 for ; Wed, 09 Nov 2022 17:21:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=KfOlJpoyOt6WtAZ4MP7UNGi8IeHzKx4uoa7ky+YEFAk=; b=TtGo/OhrcHkdjqxawDh9Dtn9Zm08nn1NnvwavL8KyuJVv5Cw1qT2mKf6nH9CP590+A 1AmvsJomNmGN5jyQdtdQ/Gkc6KwQw4WR+MHYskRWiMAqQdPxU0fYHwF4PXnNodtqYkbs tcSM9sPQV12frd23mNP3sq1t/PMd4SEm743F/GLC5uzAAVr4YMynUIhfdxtM1IkigYJD gsmQiM/UTCsIBRXyUNsBDUiRJB5Q7ARrkPuW/0rSDb4HkHN1nWqCbw3QkXRckB0Gbu7b NMSocUpZvtyqA5ipO53Zus+9zAGhQCb0Di3/2ec+aFix49QNFEE7drIZo9laI5XTAQ05 NZfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=KfOlJpoyOt6WtAZ4MP7UNGi8IeHzKx4uoa7ky+YEFAk=; b=mDNolfRcCaY0GHubsXf1KdXdn1f+XIbr35RAHTaItJuN6oQN750WEKBcfgHK/UA0WK oM5jU1l4JEjMTlBL599r+Y2pDErW65q4i4tl/tWUDyJqYe3tup938/3OVR89Qkf4+D4M VPglVfxsbsO/w6AGawhD8mGlBOdQucKLdMC2CdgIj869eabZwrh0FRcGGfJwXf0qnXhk yATSYT0nQGzNSPF01rjnOWAxX/65Tuu4xTBJq7UoKshNi5uYXAYXC2yTCzPe0h7VDpyY f5gp+4a1TiZKQHiY4sM7JZGnj7Mv1U6L1zRgYc0dH8swW/oJzeo3FJhQh1v9Wb9Rjv7q Upxw== X-Gm-Message-State: ACrzQf2UlV2mAtRTzHch52eY/J76faeKBmgKPnstShnJ45diFLBs4pR4 /t62xHwh51ZZlxTFOB/kJT/woFHluI1I3zA2T4g= X-Google-Smtp-Source: AMsMyM74m5V/BnXQth9Omewm4wJm9GErycLsDzTCI7eA/8OZhKRpSeq1GOxlFo47jg8niJcy964dp7uDWJUlzSO1nvc= X-Received: by 2002:a05:6a00:15c8:b0:565:bc96:1c5b with SMTP id o8-20020a056a0015c800b00565bc961c5bmr63676132pfu.52.1668043266148; Wed, 09 Nov 2022 17:21:06 -0800 (PST) MIME-Version: 1.0 References: <1668042934-1377-1-git-send-email-apinski@marvell.com> In-Reply-To: <1668042934-1377-1-git-send-email-apinski@marvell.com> From: Andrew Pinski Date: Wed, 9 Nov 2022 17:20:53 -0800 Message-ID: Subject: Re: [PATCH] Remove SLOW_SHORT_ACCESS from target headers To: apinski@marvell.com Cc: gcc-patches@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, Nov 9, 2022 at 5:16 PM apinski--- via Gcc-patches wrote: > > From: Andrew Pinski > > SLOW_SHORT_ACCESS is defined in bfin and i386 target > headers but the target macro is not used elsewhere. > So let's remove it from those two headers and poison it. Just to add, this target macro was defined in GCC 2.8.0 in i386.h but not used in any other sources. apinski@xeond:~/src/upstream-gcc/gcc$ git grep SLOW_SHORT_ACCESS releases/gcc-2.8.0 releases/gcc-2.8.0:gcc/config/i386/i386.h:#define SLOW_SHORT_ACCESS 0 So it looks like it was never used for the last 24+ years and it is time to finally remove it. Thanks, Andrew Pinski > > OK? Built x86_64-linux-gnu and bfin-elf. > > gcc/ChangeLog: > > * config/bfin/bfin.h (SLOW_SHORT_ACCESS): Delete. > * config/i386/i386.h (SLOW_SHORT_ACCESS): Delete. > * system.h: Poison SLOW_SHORT_ACCESS > --- > gcc/config/bfin/bfin.h | 1 - > gcc/config/i386/i386.h | 3 --- > gcc/system.h | 2 +- > 3 files changed, 1 insertion(+), 5 deletions(-) > > diff --git a/gcc/config/bfin/bfin.h b/gcc/config/bfin/bfin.h > index 4e7753038a8..1d75c655df8 100644 > --- a/gcc/config/bfin/bfin.h > +++ b/gcc/config/bfin/bfin.h > @@ -810,7 +810,6 @@ typedef struct { > subsequent accesses occur to other fields in the same word of the > structure, but to different bytes. */ > #define SLOW_BYTE_ACCESS 0 > -#define SLOW_SHORT_ACCESS 0 > > /* Define this if most significant bit is lowest numbered > in instructions that operate on numbered bit-fields. */ > diff --git a/gcc/config/i386/i386.h b/gcc/config/i386/i386.h > index b32db8da109..a5ad9f387f7 100644 > --- a/gcc/config/i386/i386.h > +++ b/gcc/config/i386/i386.h > @@ -1933,9 +1933,6 @@ do { \ > > #define SLOW_BYTE_ACCESS 0 > > -/* Nonzero if access to memory by shorts is slow and undesirable. */ > -#define SLOW_SHORT_ACCESS 0 > - > /* Define this macro if it is as good or better to call a constant > function address than to call an address kept in a register. > > diff --git a/gcc/system.h b/gcc/system.h > index c192b6c3ce7..de9c5c0d2ef 100644 > --- a/gcc/system.h > +++ b/gcc/system.h > @@ -1075,7 +1075,7 @@ extern void fancy_abort (const char *, int, const char *) > EH_FRAME_IN_DATA_SECTION TARGET_FLT_EVAL_METHOD_NON_DEFAULT \ > JCR_SECTION_NAME TARGET_USE_JCR_SECTION SDB_DEBUGGING_INFO \ > SDB_DEBUG NO_IMPLICIT_EXTERN_C NOTICE_UPDATE_CC \ > - CC_STATUS_MDEP_INIT CC_STATUS_MDEP CC_STATUS > + CC_STATUS_MDEP_INIT CC_STATUS_MDEP CC_STATUS SLOW_SHORT_ACCESS > > /* Hooks that are no longer used. */ > #pragma GCC poison LANG_HOOKS_FUNCTION_MARK LANG_HOOKS_FUNCTION_FREE \ > -- > 2.17.1 >