From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x1036.google.com (mail-pj1-x1036.google.com [IPv6:2607:f8b0:4864:20::1036]) by sourceware.org (Postfix) with ESMTPS id DD4493858D28 for ; Fri, 6 Jan 2023 17:21:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DD4493858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pj1-x1036.google.com with SMTP id m7-20020a17090a730700b00225ebb9cd01so5777373pjk.3 for ; Fri, 06 Jan 2023 09:21:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=s+0PVoJUsg3WOjOa3MIq0V2jijN7To0ICX0KD5t8Si4=; b=hHOWurqX8KS0plL63RnlQcchkUnQENv6pF/wuxOk743P5PD3/HlD6/PMApvidG5DDc 5F2Fwqq+t2ZV456H386QDm6YmKIGSsP+0rk1Zr7EM4QAik1MJvPPasztiI0Y0+fDl7z8 V6ojApwlGWoZbwR9ra1wKA0XHucIf8LisRQovqQWB/J2kv47ANE+NB5px8Nk/2rksNCt jHlrsb40NqIgEGz+rEwR3SfdFtInqysKwIHhY67zYfxFy6R02RAyBdAQcYB1L4H4pkqz aoRlhsCnphd7NpNEiXLOYe30VzyAJHHGGw6J4DvNXz9zcgLF9qGmNKMdXke0hRuRt/FP on+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=s+0PVoJUsg3WOjOa3MIq0V2jijN7To0ICX0KD5t8Si4=; b=UpVcKvTzmXmRahaOhdq4awyLXlePpdKPzyLzGjZxOoZFkT36TRh6s+y5VtOwFiSgwA Io8bqQklBR8xaVZaKk6gDTOm8kS0reeCHmJ7jupsLU209UXBgOCfAG/PeDhsFlB/b7Fz 0PGvb46aUSvw4jWFChqx7vAS2kl0wUeXEt2CrA53CzWS5+APPjD2Ht5lEzVUkkysEFtv YAeKE1O/bI1/KTtyVrK0t2Fb5VsugOvLmaIG8/r6ejS5Pfv7K+b/EMt5n3PwGkjCeddp SQykeWiMAi2Tbr3ZfFe3FoyI71PfkakJQcxIwnS2UyYntGtXYs1ZLYsLum1CTNpA1mKK eKtg== X-Gm-Message-State: AFqh2kp3g12XgTKHra3amogS0RKQhKqLxmW5kXya1V9hWC8nd9NkJqNR 3l3Wtfc/P2p90cwRkUNirBKRMb82Rt8Hqy5k+Zo= X-Google-Smtp-Source: AMrXdXsO4jmYIZMuEpm1UcjIz476C7ow/3IkaEOFAFjn1+qQqnuTKVfpiaMkkG6JxTEZng7GLabu3x42cIXZmMRiWMw= X-Received: by 2002:a17:902:760e:b0:192:5838:afdd with SMTP id k14-20020a170902760e00b001925838afddmr2299992pll.119.1673025678775; Fri, 06 Jan 2023 09:21:18 -0800 (PST) MIME-Version: 1.0 References: <6defa548-2da3-6cba-0372-f1e6c6b64c81@suse.cz> In-Reply-To: <6defa548-2da3-6cba-0372-f1e6c6b64c81@suse.cz> From: Andrew Pinski Date: Fri, 6 Jan 2023 09:21:06 -0800 Message-ID: Subject: Re: [PATCH] Remove legacy pre-C++ 11 definitions To: =?UTF-8?Q?Martin_Li=C5=A1ka?= Cc: gcc-patches@gcc.gnu.org, Jonathan Wakely Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, Jan 6, 2023 at 4:21 AM Martin Li=C5=A1ka wrote: > > As mentioned in the PRs, both are defined in C++ 11 > which is a version we depend on. > > Ready to be installed now? There is another #define NULL below: /* System headers may define NULL to be an integer (e.g. 0L), which cannot = be used safely in certain contexts (e.g. as sentinels). Redefine NULL to nullptr in order to make it safer. Note that this might confuse system headers, however, by convention they must not be included after this poi= nt. */ #ifdef __cplusplus #undef NULL #define NULL nullptr #endif Thanks, Andrew Pinski > > Thanks, > Martin > > PR middle-end/108311 > PR middle-end/108312 > > gcc/ChangeLog: > > * system.h (va_copy): Remove as it is defined in C++ 11. > (NULL): Likewise. > --- > gcc/system.h | 13 ------------- > 1 file changed, 13 deletions(-) > > diff --git a/gcc/system.h b/gcc/system.h > index 5eaeb9d2d03..0d06b9749e5 100644 > --- a/gcc/system.h > +++ b/gcc/system.h > @@ -31,25 +31,12 @@ along with GCC; see the file COPYING3. If not see > /* We must include stdarg.h before stdio.h. */ > #include > > -#ifndef va_copy > -# ifdef __va_copy > -# define va_copy(d,s) __va_copy (d, s) > -# else > -# define va_copy(d,s) ((d) =3D (s)) > -# endif > -#endif > - > #ifdef HAVE_STDDEF_H > # include > #endif > > #include > > -/* Define a generic NULL if one hasn't already been defined. */ > -#ifndef NULL > -#define NULL 0 > -#endif > - > /* Use the unlocked open routines from libiberty. */ > > /* Some of these are #define on some systems, e.g. on AIX to redirect > -- > 2.39.0 >