From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x102e.google.com (mail-pj1-x102e.google.com [IPv6:2607:f8b0:4864:20::102e]) by sourceware.org (Postfix) with ESMTPS id 754923858D39 for ; Sat, 20 Aug 2022 23:54:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 754923858D39 Received: by mail-pj1-x102e.google.com with SMTP id s3-20020a17090a2f0300b001facfc6fdbcso7402538pjd.1 for ; Sat, 20 Aug 2022 16:54:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=U4eOFjEpKvbiGbGwPPt8NgXJm6fAOe8NDhNh6OVJ4Dk=; b=zJmEVk4NX1hAGtVISHzTYww5Lz+Q0E5wUK4unZmYgGYUe0M3vNmGR9ki1n9eRseQZS IKdKxOEHzbmEFJu13Jre5+VZTZHCzZoBsEQn3yknQ0D7VjeZX6OUDLfzuppSLsK1zaxO HvAby/Ssj5LfwLfnH3uGpGc3tGSlt04Sr1HyAnYqpJxYH+nAScUjBxfn+YU5c7IAbJTv 3bljWQiEuEFn7twFnI45GWpKFu5Q3lpjotGWFf0jwuZYs2zZjnmv0VVk0FNPOSEvqQX5 Gl36jrfXxi3E3BYPRx/INIgpSIREi47oooD56wOhWQGonYDk3lVN3FyDiFbPiS2UihZF oCrA== X-Gm-Message-State: ACgBeo1w/FViAfxaYI8ZpG9jAXVlYZkWGeSvh5/d3EB3Y2OVId1utXnD 9874lEhiFPK5RrWeKT0l5IvZnu0judbdqJk1W3U= X-Google-Smtp-Source: AA6agR5DonQcRZmgqHNmzZzD1g9nmba+bD65AMfMroLP25zamepLZWW6OkkJG0DjZAy/Ram6uVbZFGcA2x113CVdD4A= X-Received: by 2002:a17:902:b410:b0:172:c9d1:7501 with SMTP id x16-20020a170902b41000b00172c9d17501mr7058147plr.106.1661039642119; Sat, 20 Aug 2022 16:54:02 -0700 (PDT) MIME-Version: 1.0 References: <20220817071950.271762-1-juzhe.zhong@rivai.ai> <87h726h7et.fsf@linux-m68k.org> In-Reply-To: <87h726h7et.fsf@linux-m68k.org> From: Andrew Pinski Date: Sat, 20 Aug 2022 16:53:48 -0700 Message-ID: Subject: Re: [PATCH] RISC-V: Add runtime invariant support To: Andreas Schwab Cc: juzhe.zhong@rivai.ai, gcc-patches@gcc.gnu.org, kito.cheng@gmail.com, andrew@sifive.com, Richard Guenther Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 20 Aug 2022 23:54:06 -0000 On Sat, Aug 20, 2022 at 3:34 PM Andreas Schwab wrote: > > This breaks bootstrap: > > ../../gcc/tree-vect-loop-manip.cc: In function 'void vect_gen_vector_loop_niters(loop_vec_info, tree, tree_node**, tree_node**, bool)': > ../../gcc/tree-vect-loop-manip.cc:1981:26: error: 'const_vf' may be used uninitialized [-Werror=maybe-uninitialized] > 1981 | unsigned HOST_WIDE_INT const_vf; > | ^~~~~~~~ > cc1plus: all warnings being treated as errors > make[3]: *** [Makefile:1146: tree-vect-loop-manip.o] Error 1 > make[2]: *** [Makefile:4977: all-stage2-gcc] Error 2 > make[1]: *** [Makefile:30363: stage2-bubble] Error 2 > make: *** [Makefile:1065: all] Error 2 This looks like a real uninitialized variable issue. I even can't tell if the paths that lead to using const_vf will be always set so how we expect GCC to do the same. The code that uses const_vf was added with r11-5820-cdcbef3c3310, CCing the author there. Thanks, Andrew > > -- > Andreas Schwab, schwab@linux-m68k.org > GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 > "And now for something completely different."