[PATCH, wide-int] change fixed_wide_int_storage from class to struct

[PATCH, wide-int] change fixed_wide_int_storage from class to struct

[Gerald Pfeifer]

While not a bug according to the language of the C++ standard, this
causes dozens of warnings when building GCC with clang, and there is
not benefit of mixing struct and class like this.

Mike, when I had a similar case a while ago you sounded pretty 
supportive of this kind of change.  Would you be fine to pre-approve
such changes?

Gerald

2016-05-15  Gerald Pfeifer  <gerald@pfeifer.com>

	* wide-int.h: Change fixed_wide_int_storage from class to struct.

Index: wide-int.h
===================================================================
--- wide-int.h	(revision 236255)
+++ wide-int.h	(working copy)
@@ -294,7 +294,7 @@
   HOST_WIDE_INT *VAL = RESULT.write_val ()
 
 template <typename T> class generic_wide_int;
-template <int N> struct fixed_wide_int_storage;
+template <int N> class fixed_wide_int_storage;
 class wide_int_storage;
 
 /* An N-bit integer.  Until we can use typedef templates, use this instead.  */

Re: [PATCH, wide-int] change fixed_wide_int_storage from class to struct

[Andrew Pinski]

On Sun, May 15, 2016 at 12:03 PM, Gerald Pfeifer <gerald@pfeifer.com> wrote:
> While not a bug according to the language of the C++ standard, this
> causes dozens of warnings when building GCC with clang, and there is
> not benefit of mixing struct and class like this.
>
> Mike, when I had a similar case a while ago you sounded pretty
> supportive of this kind of change.  Would you be fine to pre-approve
> such changes?

Can we recommend that clang disable this warning by default instead?
Or use an option flag to disable the warning while compiling gcc?

Thanks,
Andrew

>
> Gerald
>
> 2016-05-15  Gerald Pfeifer  <gerald@pfeifer.com>
>
>         * wide-int.h: Change fixed_wide_int_storage from class to struct.
>
> Index: wide-int.h
> ===================================================================
> --- wide-int.h  (revision 236255)
> +++ wide-int.h  (working copy)
> @@ -294,7 +294,7 @@
>    HOST_WIDE_INT *VAL = RESULT.write_val ()
>
>  template <typename T> class generic_wide_int;
> -template <int N> struct fixed_wide_int_storage;
> +template <int N> class fixed_wide_int_storage;
>  class wide_int_storage;
>
>  /* An N-bit integer.  Until we can use typedef templates, use this instead.  */

Re: [PATCH, wide-int] change fixed_wide_int_storage from class to struct

[Richard Biener]

On May 15, 2016 9:03:22 PM GMT+02:00, Gerald Pfeifer <gerald@pfeifer.com> wrote:
>While not a bug according to the language of the C++ standard, this
>causes dozens of warnings when building GCC with clang, and there is
>not benefit of mixing struct and class like this.
>
>Mike, when I had a similar case a while ago you sounded pretty 
>supportive of this kind of change.  Would you be fine to pre-approve
>such changes?

Yes, they are OK.

Thanks,
Richard.

>Gerald
>
>2016-05-15  Gerald Pfeifer  <gerald@pfeifer.com>
>
>	* wide-int.h: Change fixed_wide_int_storage from class to struct.
>
>Index: wide-int.h
>===================================================================
>--- wide-int.h	(revision 236255)
>+++ wide-int.h	(working copy)
>@@ -294,7 +294,7 @@
>   HOST_WIDE_INT *VAL = RESULT.write_val ()
> 
> template <typename T> class generic_wide_int;
>-template <int N> struct fixed_wide_int_storage;
>+template <int N> class fixed_wide_int_storage;
> class wide_int_storage;
> 
>/* An N-bit integer.  Until we can use typedef templates, use this
>instead.  */

Re: [PATCH, wide-int] change fixed_wide_int_storage from class to struct

[Mike Stump]

On May 15, 2016, at 12:03 PM, Gerald Pfeifer <gerald@pfeifer.com> wrote:
> While not a bug according to the language of the C++ standard, this
> causes dozens of warnings when building GCC with clang, and there is
> not benefit of mixing struct and class like this.
> 
> Mike, when I had a similar case a while ago you sounded pretty 
> supportive of this kind of change.  Would you be fine to pre-approve
> such change?

There was no intention to have this struct/class mismatch.  As Richard already said, Ok.  Ok for back porting as well.

Re: [PATCH, wide-int] change fixed_wide_int_storage from class to struct

[Mike Stump]

On May 15, 2016, at 1:30 PM, Andrew Pinski <pinskia@gmail.com> wrote:
> 
> Can we recommend that clang disable this warning by default instead?

No.  We want to ensure the class/struct tags match as there is no good reason to have them differ.

> Or use an option flag to disable the warning while compiling gcc?

Don't need the option to disable it, as once we fix gcc, it won't produce these warnings.  If clang produces warnings for constructs we do want to use, then we disable those warnings as uninteresting.  For example, if they warned for line widths more than 80, and we don't have a hard rule about 80, then we'd turn it off as overly pedantic for our source base, even though in most files, most of the time we were 80 or under.  If we had a hard and fast rule, no lines over 80, ever, then we'd not turn that warning off, rather, we would fixed the software to conform to that.