From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x102a.google.com (mail-pj1-x102a.google.com [IPv6:2607:f8b0:4864:20::102a]) by sourceware.org (Postfix) with ESMTPS id 9059A3858D20 for ; Sun, 21 May 2023 03:32:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9059A3858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pj1-x102a.google.com with SMTP id 98e67ed59e1d1-25332422531so1667513a91.0 for ; Sat, 20 May 2023 20:32:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684639972; x=1687231972; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=4N+OPztSK7ElorCbm+BJr8BoRg46NtPYMLn39R0mr5g=; b=BiVLSuzQpRzCT0XRmRieD8Dut1huchcQ0qBec35lWUZlDdCf6aH+5zWt7lHOqCC99d UsV+nIS3ACPpFac1b1PQqUqHRnVKQt6JC1QZrHkGpLTo6kplfjliPQTNGAMkfMb0dg3s WZszRf7Yh4/jP+bs8JrN07dvpHM4rROOI0mSpBnDGVhq+sfhGnLllHXXtXIgNbpBJFYq F4fmvbtoaM2x0LE/m6S/GwH7aw+zq+2yl6c2qyfLXcL3V+qRgB6HWfKWUE1p5CIKhrvX 0CzQA8n8NhJmG2ZObYB+4hvZfKGpxJc3uVEfMX2DzKIe1DKh5J2+pYsTx4ymHytD/Oix 3mTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684639972; x=1687231972; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=4N+OPztSK7ElorCbm+BJr8BoRg46NtPYMLn39R0mr5g=; b=lv1zmAYKWLYW3zdOe5UUmduxjz1xSQ6ZD5TCIKIvGgzYTXZCED/AsPRChvbPk66Kmg 40utMSH3I5Q4qu/qBrmeG12TZ6PWhPGo7Bwl/ZNwy4aU2XR3DRkIaTAHWRXLNsxHIeQ+ GhAQ8Y7bgJMr6Z1Rk5f5xOBI2aE/S3RDR9IW61NRgcSxz+pd1KniCR6NsVPf955XlyEK WZmnqot7+oF7Z1C2XH3eu0ls2dEULm+Mpo54DyTzQA85O9az7FvzHVfZmmK4+rPhz6xe FDI8GWw/fampRIfRh8Tvdyd/EhvnMtUNm2NtEb2UwDyjWS2R7pYn6KsvKWGRezpysog8 KQ7Q== X-Gm-Message-State: AC+VfDwYZ0ytcPFRypo4PvOH4r18ZZFkMyxVcZXrsx0eNflBlUuOjtXr IuKl38xeMhCE5Cn1Ca5GugsVdRV+qy94Mp7BLKw= X-Google-Smtp-Source: ACHHUZ5EThApXg/5v5MsUwIQqcgvrVoCMAxT/Faen7dC8EAuXGBBxqAn+s9k+8kvVbPWGjDRP1pKq/44icYTcJLozZA= X-Received: by 2002:a17:90a:1b2b:b0:24e:2759:8dbe with SMTP id q40-20020a17090a1b2b00b0024e27598dbemr8076654pjq.7.1684639972518; Sat, 20 May 2023 20:32:52 -0700 (PDT) MIME-Version: 1.0 References: <20230521010949.1957550-1-apinski@marvell.com> <8110c2f0-cf70-3360-b59a-5f1df798cebd@gmail.com> In-Reply-To: From: Andrew Pinski Date: Sat, 20 May 2023 20:32:39 -0700 Message-ID: Subject: Re: [PATCH] Fix PR 109919: ICE in emit_move_insn with some bit tests To: Jeff Law Cc: gcc-patches@gcc.gnu.org Content-Type: multipart/mixed; boundary="0000000000002346c805fc2bcfba" X-Spam-Status: No, score=-7.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --0000000000002346c805fc2bcfba Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sat, May 20, 2023 at 8:28=E2=80=AFPM Andrew Pinski w= rote: > > On Sat, May 20, 2023 at 8:25=E2=80=AFPM Jeff Law = wrote: > > > > > > > > On 5/20/23 21:05, Andrew Pinski wrote: > > > On Sat, May 20, 2023 at 6:26=E2=80=AFPM Jeff Law via Gcc-patches > > > wrote: > > >> > > >> > > >> > > >> On 5/20/23 19:09, Andrew Pinski via Gcc-patches wrote: > > >>> The problem is I used expand_expr with the target but > > >>> we don't want to use the target here as it is the wrong > > >>> mode for the original expression. The testcase would ICE > > >>> deap down while trying to do a move to use the target. > > >>> Anyways just calling expand_expr with NULL_EXPR fixes > > >>> the issue. > > >>> > > >>> Committed as obvious after a bootstrap/test on x86_64-linux-gnu. > > >>> > > >>> PR middle-end/109919 > > >>> > > >>> gcc/ChangeLog: > > >>> > > >>> * expr.cc (expand_single_bit_test): Don't use the > > >>> target for expand_expr. > > >>> > > >>> gcc/testsuite/ChangeLog: > > >>> > > >>> * gcc.c-torture/compile/pr109919-1.c: New test. > > >> Thanks. I'll respin the targets that failed. If you don't hear fro= m > > >> me, assume everything is happy again after this fix. > > > > > > Oh, I am going to test on aarch64-linux-gnu too just in case. > > > Expand is definitely something which I am not used to working on so I > > > figured I had made a mistake somewhere. I suspect I still made a > > > similar mistake later on too. > > I'm seeing some execution failures. Building H8 bits now to debug as > > it's the target I'm most familiar with. More info as it's available. > > Is H8 big-endian? I could have messed that up. If so, try the attached patch. I thought extract_bit_field's bitnum field was like a shift and not like how BIT_FIELD_REF is defined. Thanks, Andrew > > Thanks, > Andrew Pinski > > > > > jeff --0000000000002346c805fc2bcfba Content-Type: text/plain; charset="US-ASCII"; name="maybefixbigendian.diff.txt" Content-Disposition: attachment; filename="maybefixbigendian.diff.txt" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lhwv3rm30 ZGlmZiAtLWdpdCBhL2djYy9leHByLmNjIGIvZ2NjL2V4cHIuY2MKaW5kZXggMDJmMjRjMDAxNDgu LmMwMzM3NjFmMzE3IDEwMDY0NAotLS0gYS9nY2MvZXhwci5jYworKysgYi9nY2MvZXhwci5jYwpA QCAtMTI5NTgsNyArMTI5NTgsMTIgQEAgZXhwYW5kX3NpbmdsZV9iaXRfdGVzdCAobG9jYXRpb25f dCBsb2MsIGVudW0gdHJlZV9jb2RlIGNvZGUsCiAKICAgcnR4IGlubmVyMCA9IGV4cGFuZF9leHBy IChpbm5lciwgTlVMTF9SVFgsIFZPSURtb2RlLCBFWFBBTkRfTk9STUFMKTsKIAotICBpbm5lcjAg PSBleHRyYWN0X2JpdF9maWVsZCAoaW5uZXIwLCAxLCBiaXRudW0sIDEsIHRhcmdldCwKKyAgaW50 IGJpdHBvcyA9IGJpdG51bTsKKworICBpZiAoQllURVNfQklHX0VORElBTikKKyAgICBiaXRwb3Mg PSBHRVRfTU9ERV9CSVRTSVpFIChpbm5lcjApIC0gMSAtIGJpdHBvczsKKworICBpbm5lcjAgPSBl eHRyYWN0X2JpdF9maWVsZCAoaW5uZXIwLCAxLCBiaXRwb3MsIDEsIHRhcmdldCwKIAkJCSAgICAg IG9wZXJhbmRfbW9kZSwgbW9kZSwgMCwgTlVMTCk7CiAKICAgaWYgKGNvZGUgPT0gRVFfRVhQUikK --0000000000002346c805fc2bcfba--