From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x1033.google.com (mail-pj1-x1033.google.com [IPv6:2607:f8b0:4864:20::1033]) by sourceware.org (Postfix) with ESMTPS id 6C1203858CDB for ; Tue, 25 Jul 2023 20:54:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6C1203858CDB Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pj1-x1033.google.com with SMTP id 98e67ed59e1d1-26824c32cfbso190102a91.1 for ; Tue, 25 Jul 2023 13:54:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1690318475; x=1690923275; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=RV0Vg70zkGZPkl4EqIWYgVpnpA4Xtz+XCLW/Bdly0ZM=; b=IOax7G+yki7wzwflBS7klxA+0vogGz7eRBKDalaU2PILvrPzv9/K3yyCDF+044Fxd9 mCuoAdqd9UT+N5J5dtvSPlPOona6BWjCI0ayV+4xwAvlREv7jwCwYy0QdsbgeS6SLaV3 QaY59CQg3OTGTTBIZJX4L4vnDHIg1WL/t2c6vGQhMTe3qCxdUqAgY+rpxBKlp5Q2/ZFg Awp3W+rQax+XvvjYH0ddwaVdQECDYa2pjvem4nNyJEhSTamWFeV0NJM9J72A8d7Q4fhR tzC0TK87N2TXnNHNg32ovwAxwgXXLI6pM5CxU2mwO1+MLLHiYe0jfRU63voNgx4cgyay 6Ayw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690318475; x=1690923275; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RV0Vg70zkGZPkl4EqIWYgVpnpA4Xtz+XCLW/Bdly0ZM=; b=MAHym3hrYamPACuRxIOJ9/5pMl5GbzFeJymqUobUyPNLhamQWUZXMLmP4OmATOGyJQ RhEMKBBGK7dIEC9xw7n30vbzcGL0g8W+S1TMv5QKOIVpdkx5cnoNbIYd+SwNwI41oHjL noKKB+pQ35W00qMB8vJwK6NiyN91w/MfdSy92faDCxdXM/VTU3UFzP1vts1/AmS0kk/F KPt548nxE5LAUY4bh3F1J5cf9uRuTNQznKL2zJMDp8E4xsZikKO3JZvRUQQg0g+JmVAV m/i2XjnloEwYir8tcxyo6Sp4C6FzbvEt1x6m4SQ5kBwP5teFK0d7WvQZPKZPnQR4xSBO xNxg== X-Gm-Message-State: ABy/qLYbSU2EdacmYgi70rfgRc79CG+ADAslM0EaNPIXenCM/VbfvD4f 6SX/QOBCnq+Zd8Fjgg4WuuuJSo1Lol/OnNrk47c= X-Google-Smtp-Source: APBJJlFHRBA+VdJ+TJyWDRuV56jLkHgPJC/28EYJyjI82fLEGMJn3NlI4l+vbDxFbygNSXUg2Uvngo9cBB+mpmyhRzA= X-Received: by 2002:a17:90a:9316:b0:263:161c:9e9c with SMTP id p22-20020a17090a931600b00263161c9e9cmr361921pjo.12.1690318475054; Tue, 25 Jul 2023 13:54:35 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Andrew Pinski Date: Tue, 25 Jul 2023 13:54:23 -0700 Message-ID: Subject: Re: [PATCH] match.pd: Implement missed optimization (~X | Y) ^ X -> ~(X & Y) [PR109986] To: Jakub Jelinek Cc: David Edelsohn , Drew Ross , GCC Patches Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, Jul 25, 2023 at 12:45=E2=80=AFPM Jakub Jelinek via Gcc-patches wrote: > > On Tue, Jul 25, 2023 at 03:42:21PM -0400, David Edelsohn via Gcc-patches = wrote: > > Hi, Drew > > > > Thanks for addressing this missed optimization. > > > > The testcase includes an incorrect assumption: signed char, which > > causes the testcase to fail on PowerPC. > > > > Should the testcase be updated to specify signed char in the function > > signatures or should -fsigned-char be added to the command line > > options? > > I think we should use signed char instead of char in the testcase. I also think it should be `signed char` instead as I mentioned in https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D110803 . Thanks, Andrew > > Jakub >