From: Andrew Pinski <pinskia@gmail.com>
To: Diego Novillo <dnovillo@google.com>
Cc: Hans-Peter Nilsson <hp@bitrange.com>, gcc-patches@gcc.gnu.org
Subject: Re: VEC re-write [patch 01/25]
Date: Sun, 18 Nov 2012 19:15:00 -0000 [thread overview]
Message-ID: <CA+=Sn1nctDH7faSRhO7HifMVDW9ryutwg_bUbPKsV5hxQaeF3g@mail.gmail.com> (raw)
In-Reply-To: <CAD_=9DTGx56zb3xQ1_=BCeFA98WKuhnssQWUQH7+YuL0arMT9w@mail.gmail.com>
On Sun, Nov 18, 2012 at 9:12 AM, Diego Novillo <dnovillo@google.com> wrote:
> On Sun, Nov 18, 2012 at 12:05 PM, Hans-Peter Nilsson <hp@bitrange.com> wrote:
>> On Sat, 17 Nov 2012, Diego Novillo wrote:
>>> I have now committed all 25 parts of this patch as rev 193595. Please
>>> CC me on any problems that you think may be related to this rewrite.
>>
>> That seems to have trigged some bug in gcc-4.4-era. See
>> PR55381. There are a lot of suspicious warnings from vec.h.
>> It smells a bit like a host gcc bug, but I'll have to find a
>> newer version where it builds to confirm. (If so, "hopefully"
>> it's as "simple" as upping the minimum host gcc version or
>> blacklisting gcc-4.4.x.)
>
> Yeah, I got those warnings in my sparc and hppa builds, but they are
> harmless. Strictly speaking offsetof cannot be applied to non-PODs.
> The only thing that makes that class non-POD is the protected
> attribute, but that does not alter the physical layout. So the
> compiler is emitting a harmless warning (newer versions have
> tightened the check to warn when you are using offsetof on a non-base
> class).
But then we are no longer writing in C++. Is there a reason why this
warning does not break the build? We should not be using offsetof
with non-PODs.
Thanks,
Andrew Pinski
>
> My cris-elf builds worked fine, but config-list.mk only builds stage
> 1, it does not build libgfortran. Can you give me instructions on how
> to build your target on my x86 workstation?
>
>
> Thanks. Diego.
next prev parent reply other threads:[~2012-11-18 19:15 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-15 21:53 Diego Novillo
[not found] ` <50A61414.8070908@redhat.com>
2012-11-16 12:13 ` Diego Novillo
2012-11-16 12:22 ` Pedro Alves
2012-11-16 23:16 ` Ian Lance Taylor
2012-11-18 2:57 ` Diego Novillo
2012-11-18 17:05 ` Hans-Peter Nilsson
2012-11-18 17:12 ` Diego Novillo
2012-11-18 17:43 ` Hans-Peter Nilsson
2012-11-18 17:48 ` Diego Novillo
2012-11-18 19:15 ` Andrew Pinski [this message]
2012-11-19 19:57 ` Jack Howarth
2012-11-19 20:16 ` Jack Howarth
2012-11-25 13:11 ` Richard Biener
2012-11-25 15:25 ` Diego Novillo
2012-11-18 18:25 ` Andreas Tobler
2012-11-18 19:12 ` Hans-Peter Nilsson
2012-11-18 19:32 ` Andreas Tobler
2012-11-18 19:50 ` Hans-Peter Nilsson
2012-11-20 13:57 ` Ulrich Weigand
2012-11-18 21:28 David Edelsohn
2012-11-19 1:04 ` Diego Novillo
2012-11-19 1:14 ` David Edelsohn
2012-11-19 3:18 ` Ian Lance Taylor
2012-11-19 14:46 ` David Edelsohn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+=Sn1nctDH7faSRhO7HifMVDW9ryutwg_bUbPKsV5hxQaeF3g@mail.gmail.com' \
--to=pinskia@gmail.com \
--cc=dnovillo@google.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hp@bitrange.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).