From: Andrew Pinski <pinskia@gmail.com>
To: Kyrill Tkachov <kyrylo.tkachov@arm.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
Ramana Radhakrishnan <Ramana.Radhakrishnan@arm.com>,
Richard Earnshaw <Richard.Earnshaw@arm.com>
Subject: Re: [PATCH][ARM] Add debug dumping of cost table fields
Date: Wed, 27 May 2015 09:04:00 -0000 [thread overview]
Message-ID: <CA+=Sn1nup6kAQUNrU0+a6Kg4u=wEiGRp_MXhaM9HAdXMExwZaw@mail.gmail.com> (raw)
In-Reply-To: <55658268.7020403@arm.com>
On Wed, May 27, 2015 at 4:38 PM, Kyrill Tkachov <kyrylo.tkachov@arm.com> wrote:
> Ping.
> https://gcc.gnu.org/ml/gcc-patches/2015-05/msg00054.html
This and the one in AARCH64 is too noisy. Can we have an option to
turn this on and default to turning them off.
Thanks,
Andrew
>
> Thanks,
> Kyrill
>
> On 01/05/15 15:31, Kyrill Tkachov wrote:
>>
>> Hi all,
>>
>> This patch adds a macro to wrap cost field accesses into a helpful debug
>> dump,
>> saying which field is being accessed at what line and with what values.
>> This helped me track down cases where the costs were doing the wrong thing
>> by allowing me to see which path in arm_new_rtx_costs was taken.
>> For example, the combine log might now contain:
>>
>> Trying 2 -> 6:
>> Successfully matched this instruction:
>> (set (reg:SI 115 [ D.5348 ])
>> (neg:SI (reg:SI 0 r0 [ a ])))
>> using extra_cost->alu.arith with cost 0 from line 10506
>>
>> which can be useful in debugging the rtx costs.
>>
>> Bootstrapped and tested on arm.
>>
>> Ok for trunk?
>>
>> Thanks,
>> Kyrill
>>
>>
>> 2015-05-01 Kyrylo Tkachov <kyrylo.tkachov@arm.com>
>>
>> * config/arm/arm.c (DBG_COST): New macro.
>> (arm_new_rtx_costs): Use above.
>
>
next prev parent reply other threads:[~2015-05-27 8:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-01 14:31 Kyrill Tkachov
2015-05-27 8:47 ` Kyrill Tkachov
2015-05-27 9:04 ` Andrew Pinski [this message]
2015-05-27 9:29 ` Bin.Cheng
2015-05-27 10:25 ` Kyrill Tkachov
2015-06-16 8:41 ` Kyrill Tkachov
2015-07-08 8:22 ` Kyrill Tkachov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+=Sn1nup6kAQUNrU0+a6Kg4u=wEiGRp_MXhaM9HAdXMExwZaw@mail.gmail.com' \
--to=pinskia@gmail.com \
--cc=Ramana.Radhakrishnan@arm.com \
--cc=Richard.Earnshaw@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=kyrylo.tkachov@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).