public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Patrick Palka <patrick@parcs.ath.cx>
To: GCC Patches <gcc-patches@gcc.gnu.org>
Cc: Patrick Palka <patrick@parcs.ath.cx>
Subject: Re: [PATCH] Turn some compile-time tests into run-time tests
Date: Thu, 10 Mar 2016 23:54:00 -0000	[thread overview]
Message-ID: <CA+C-WL-ERZE7QUHfhJXRoodJUWtdTZC7ZJpCUNsT0=i00XLMUA@mail.gmail.com> (raw)
In-Reply-To: <1457653131-32296-1-git-send-email-patrick@parcs.ath.cx>

On Thu, Mar 10, 2016 at 6:38 PM, Patrick Palka <patrick@parcs.ath.cx> wrote:
> I ran the command
>
>   git grep -l "dg-do compile" | xargs grep -l __builtin_abort | xargs grep -lw main
>
> to find tests marked as compile-time tests that likely ought to instead
> be marked as run-time tests, by the rationale that they use
> __builtin_abort and they also define main().  (I also then confirmed that they
> compile, link and run cleanly on my machine.)
>
> After this patch, the remaining test files reported by the above command
> are:
>
>   These do not define all the functions they use:
>     gcc/testsuite/g++.dg/ipa/devirt-41.C
>     gcc/testsuite/g++.dg/ipa/devirt-44.C
>     gcc/testsuite/g++.dg/ipa/devirt-45.C
>     gcc/testsuite/gcc.target/i386/pr55672.c

Actually this i386 test just performs obvious UB which is why I left
it as a compile-time test.

  reply	other threads:[~2016-03-10 23:54 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-10 23:39 Patrick Palka
2016-03-10 23:54 ` Patrick Palka [this message]
2016-03-11 16:39 ` Patrick Palka
2016-04-27 21:26   ` Jeff Law
2016-04-27 21:37 ` Jeff Law
2016-04-28 14:03   ` Patrick Palka
2016-04-28 14:59     ` Jeff Law

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CA+C-WL-ERZE7QUHfhJXRoodJUWtdTZC7ZJpCUNsT0=i00XLMUA@mail.gmail.com' \
    --to=patrick@parcs.ath.cx \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).