From: Patrick Palka <patrick@parcs.ath.cx>
To: Jason Merrill <jason@redhat.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] Fix PR c++/30044
Date: Mon, 15 Jun 2015 18:37:00 -0000 [thread overview]
Message-ID: <CA+C-WL9iT2Ab_360SYWmZVkRPWaz4scVQXLmWgi1Hp8cttzaOw@mail.gmail.com> (raw)
In-Reply-To: <557F13E3.3020507@redhat.com>
On Mon, Jun 15, 2015 at 2:05 PM, Jason Merrill <jason@redhat.com> wrote:
> On 06/11/2015 09:25 PM, Patrick Palka wrote:
>>
>> + parameter_vec = make_tree_vec
>> + (TREE_VEC_LENGTH (TREE_VALUE (current_template_parms)) + 1);
>> +
>> + for (int i = 0; i < TREE_VEC_LENGTH (parameter_vec) - 1; i++)
>> + TREE_VEC_ELT (parameter_vec, i)
>> + = TREE_VEC_ELT (TREE_VALUE (current_template_parms), i);
>> +
>> + TREE_VEC_ELT (parameter_vec, TREE_VEC_LENGTH (parameter_vec) - 1)
>> + = tree_last (parameter_list);
>
>
> Any reason not to use grow_tree_vec?
Doing so causes a lot of ICEs in the testsuite. I think it's because
grow_tree_vec invalidates the older parameter_vec which some trees may
still be holding a reference to in their DECL_TEMPLATE_PARMS field.
>
>
next prev parent reply other threads:[~2015-06-15 18:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-12 1:28 Patrick Palka
2015-06-15 18:07 ` Jason Merrill
2015-06-15 18:37 ` Patrick Palka [this message]
2015-06-23 7:56 ` Jason Merrill
2015-06-24 0:47 ` Patrick Palka
2015-06-24 9:22 ` Markus Trippelsdorf
2015-06-24 12:25 ` Patrick Palka
2015-06-26 12:05 ` Patrick Palka
2015-07-09 13:07 ` Patrick Palka
2015-07-09 20:56 ` Jason Merrill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+C-WL9iT2Ab_360SYWmZVkRPWaz4scVQXLmWgi1Hp8cttzaOw@mail.gmail.com \
--to=patrick@parcs.ath.cx \
--cc=gcc-patches@gcc.gnu.org \
--cc=jason@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).