From: Patrick Palka <patrick@parcs.ath.cx>
To: Marek Polacek <polacek@redhat.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
"Joseph S. Myers" <joseph@codesourcery.com>
Subject: Re: [PATCH] [C FE] Fold trivial exprs that refer to const vars
Date: Mon, 07 Dec 2015 12:27:00 -0000 [thread overview]
Message-ID: <CA+C-WL_1OD2QDBJVQ=UQnQrR+FDd0DOp_bWJpYa01uwNNdwQRw@mail.gmail.com> (raw)
In-Reply-To: <20151207122048.GL3175@redhat.com>
On Mon, Dec 7, 2015 at 7:20 AM, Marek Polacek <polacek@redhat.com> wrote:
> On Sun, Dec 06, 2015 at 11:50:15PM -0500, Patrick Palka wrote:
>> diff --git a/gcc/c/c-fold.c b/gcc/c/c-fold.c
>> index c554e17..ab0b37f 100644
>> --- a/gcc/c/c-fold.c
>> +++ b/gcc/c/c-fold.c
>> @@ -88,6 +88,7 @@ c_fully_fold (tree expr, bool in_init, bool *maybe_const)
>> }
>> ret = c_fully_fold_internal (expr, in_init, maybe_const,
>> &maybe_const_itself, false);
>> + ret = decl_constant_value_for_optimization (ret);
>
> Sorry, I don't think you can just do this. Because for e.g.
> const int x = 7;
> x++;
> we'd turn this into
> 7++;
> , right? And I'm sure that's going to ICE in gimplifier.
Yes, looks like it.
next prev parent reply other threads:[~2015-12-07 12:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-07 4:51 Patrick Palka
2015-12-07 4:56 ` Patrick Palka
2015-12-07 12:20 ` Marek Polacek
2015-12-07 12:27 ` Patrick Palka [this message]
2015-12-07 12:24 ` Joseph Myers
2015-12-07 12:43 ` Patrick Palka
2015-12-07 12:24 ` Patrick Palka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+C-WL_1OD2QDBJVQ=UQnQrR+FDd0DOp_bWJpYa01uwNNdwQRw@mail.gmail.com' \
--to=patrick@parcs.ath.cx \
--cc=gcc-patches@gcc.gnu.org \
--cc=joseph@codesourcery.com \
--cc=polacek@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).