From: Patrick Palka <patrick@parcs.ath.cx>
To: Jason Merrill <jason@redhat.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] Fix PR c++/16160
Date: Wed, 14 Jan 2015 13:49:00 -0000 [thread overview]
Message-ID: <CA+C-WL_BH_mjyuZosixku8GSuCnwc2k+BfYv51rPEuxt-E+ppQ@mail.gmail.com> (raw)
In-Reply-To: <CA+C-WL8kY7cqovaKeaFOmnG69GWR3EKMhjPrVH_pZddyUofrLw@mail.gmail.com>
On Wed, Jan 14, 2015 at 8:26 AM, Patrick Palka <patrick@parcs.ath.cx> wrote:
> On Wed, Jan 14, 2015 at 8:05 AM, Jason Merrill <jason@redhat.com> wrote:
>> On 01/13/2015 10:54 PM, Patrick Palka wrote:
>>>
>>> + type = error_mark_node;
>>> + goto out;
>>
>>
>> Why exit early in the explicit instantiation cases? Doesn't it work to give
>> the error and continue?
>>
>> Jason
>>
>
> Yes it does. I changed it to an early exit in the last minute for no
> good reason. But an earlier version of the patch that continued
> instead of exiting worked correctly.
Actually I recall having issues with not exiting early in the "an
explicit instantiation may not have a definition" case. But in the
"an explicit instantiation must be preceded by template" case one
could safely continue (even though it goes on to be processed as a
forward declaration of a template specialization instead of a mistyped
explicit instantiation...)
next prev parent reply other threads:[~2015-01-14 13:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-14 5:30 Patrick Palka
2015-01-14 13:27 ` Jason Merrill
2015-01-14 13:34 ` Patrick Palka
2015-01-14 13:49 ` Patrick Palka [this message]
2015-01-14 18:23 ` Patrick Palka
2015-01-14 21:34 ` Jason Merrill
2015-01-14 22:20 ` Patrick Palka
2015-01-15 1:19 ` Jason Merrill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+C-WL_BH_mjyuZosixku8GSuCnwc2k+BfYv51rPEuxt-E+ppQ@mail.gmail.com \
--to=patrick@parcs.ath.cx \
--cc=gcc-patches@gcc.gnu.org \
--cc=jason@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).