From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 74205 invoked by alias); 11 Mar 2016 16:39:22 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 72823 invoked by uid 89); 11 Mar 2016 16:39:21 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 spammy= X-HELO: mail-oi0-f49.google.com Received: from mail-oi0-f49.google.com (HELO mail-oi0-f49.google.com) (209.85.218.49) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Fri, 11 Mar 2016 16:39:11 +0000 Received: by mail-oi0-f49.google.com with SMTP id d205so89786898oia.0 for ; Fri, 11 Mar 2016 08:39:10 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=2BM++YPZO0C4ddvp7j4j8GvAqMzqR7NBsvjxlO4g228=; b=Q5oJfX2aEx7u7hWlOxo4CRRUbPZ0H2Yg4HwmxsuJf2BEXzyngPB7cNbCPy8/TNeXMl xByM6OqTSjKaUnr4nYCMcVzgC7oNylRkowQ89zu8mul7MhyiAROS/6ix8Qdw4VGrDGtx 4r10nhJJaUctVvQ13TKla0pVirGhaSjxYsBQb9ABZKpmx3JWJLdvp4ca68JaaTTXcACC Ay4Y/Qqe/rHixsIAqO2GhtKn8FbWh57PPB1/lsmpIAy0u/5TqO02X7zaMc1M99hOKHX2 Nh9UKaLBkIwrdGplc00+qyRMKbd1VkdZLp+A804N2YKq2lZX4LkmUAQ1oFiEp2//4a1O zqRg== X-Gm-Message-State: AD7BkJJcS/3a0VssPhG6gOT2Ry/irJQzWEhq0CKACthbK2QNEFQFgyUvRICGkZDQZIVr6CwTlsrvdmB1bC7U5w== X-Received: by 10.202.217.136 with SMTP id q130mr6030457oig.127.1457714349050; Fri, 11 Mar 2016 08:39:09 -0800 (PST) MIME-Version: 1.0 Received: by 10.182.29.226 with HTTP; Fri, 11 Mar 2016 08:38:49 -0800 (PST) In-Reply-To: <1457653131-32296-1-git-send-email-patrick@parcs.ath.cx> References: <1457653131-32296-1-git-send-email-patrick@parcs.ath.cx> From: Patrick Palka Date: Fri, 11 Mar 2016 16:39:00 -0000 Message-ID: Subject: Re: [PATCH] Turn some compile-time tests into run-time tests To: GCC Patches Cc: Patrick Palka Content-Type: text/plain; charset=UTF-8 X-SW-Source: 2016-03/txt/msg00707.txt.bz2 On Thu, Mar 10, 2016 at 6:38 PM, Patrick Palka wrote: > I ran the command > > git grep -l "dg-do compile" | xargs grep -l __builtin_abort | xargs grep -lw main > > to find tests marked as compile-time tests that likely ought to instead > be marked as run-time tests, by the rationale that they use > __builtin_abort and they also define main(). (I also then confirmed that they > compile, link and run cleanly on my machine.) > > After this patch, the remaining test files reported by the above command > are: > > These do not define all the functions they use: > gcc/testsuite/g++.dg/ipa/devirt-41.C > gcc/testsuite/g++.dg/ipa/devirt-44.C > gcc/testsuite/g++.dg/ipa/devirt-45.C > gcc/testsuite/gcc.target/i386/pr55672.c > > These are non-x86 tests so I can't confirm that they run cleanly: > gcc/testsuite/gcc.target/arm/pr58041.c > gcc/testsuite/gcc.target/powerpc/pr35907.c > gcc/testsuite/gcc.target/s390/dwarfregtable-1.c > gcc/testsuite/gcc.target/s390/dwarfregtable-2.c > gcc/testsuite/gcc.target/s390/dwarfregtable-3.c > > These use dg-error: > libstdc++-v3/testsuite/20_util/forward/c_neg.cc > libstdc++-v3/testsuite/20_util/forward/f_neg.cc > > Bootstrapped and regtested on x86_64-pc-linux-gnu, does this look OK to > commit? Does anyone have another heuristic one can use to help find > these kinds of typos? > > gcc/testsuite/ChangeLog: > > * g++.dg/cpp0x/constexpr-aggr2.C: Make it a run-time test. > * g++.dg/cpp0x/nullptr32.C: Likewise. > * g++.dg/cpp1y/digit-sep-cxx11-neg.C: Likewise. > * g++.dg/cpp1y/digit-sep.C: Likewise. > * g++.dg/ext/flexary13.C: Likewise. > * gcc.dg/alias-14.c: Likewise. > * gcc.dg/ipa/PR65282.c: Likewise. > * gcc.dg/pr69644.c: Likewise. > * gcc.dg/tree-ssa/pr38533.c: Likewise. > * gcc.dg/tree-ssa/pr61385.c: Likewise. Here's another I found: diff --git a/gcc/testsuite/g++.dg/cpp0x/lambda/lambda-return1.C b/gcc/testsuite/g++.dg/cpp0x/lambda/lambda-return1.C index 4b353b6..ea7ae6f 100644 --- a/gcc/testsuite/g++.dg/cpp0x/lambda/lambda-return1.C +++ b/gcc/testsuite/g++.dg/cpp0x/lambda/lambda-return1.C @@ -1,5 +1,5 @@ // PR c++/57437 -// { dg-require-effective-target c++11 } +// { dg-do run { target c++11 } } struct A { int i;