From: Patrick Palka <patrick@parcs.ath.cx>
To: Mike Stump <mikestump@comcast.net>
Cc: David Malcolm <dmalcolm@redhat.com>,
GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH 1/4] -Wmisleading-indentation: don't warn in presence of entirely blank lines
Date: Thu, 29 Oct 2015 17:56:00 -0000 [thread overview]
Message-ID: <CA+C-WL_ruD+CHzhDPxNhZLUV6UEg+D12qk5VHXXfYMqEy0Fc9g@mail.gmail.com> (raw)
In-Reply-To: <F1AC80DE-5BEC-4BD5-AF0B-009942BCEED6@comcast.net>
On Thu, Oct 29, 2015 at 1:50 PM, Mike Stump <mikestump@comcast.net> wrote:
> On Oct 29, 2015, at 10:42 AM, Patrick Palka <patrick@parcs.ath.cx> wrote:
>> However we should definitely not warn on
>>
>> if (foo)
>> bar ();
>>
>> {
>> baz ();
>> }
>>
>> Since that is valid GNU-style code :)
>
> I’ll put it differently; no, that formatting is wrong.
>
Ah, okay. That simplifies things then. (I've seen that style used in
GCC and in GDB so I assumed it was valid GNU style since I couldn't
find a section in the style guide that explicitly stated how to indent
there.)
next prev parent reply other threads:[~2015-10-29 17:56 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-29 16:32 [PATCH 0/4] -Wmisleading-indentation David Malcolm
2015-10-29 16:32 ` [PATCH 3/4] Fix misleading indentation in tree-nested.c David Malcolm
2015-10-29 17:36 ` Jeff Law
2015-10-29 16:32 ` [PATCH 2/4] Fix misleading indentation in tree-ssa-loop-unswitch.c David Malcolm
2015-10-29 17:34 ` Jeff Law
2015-10-29 16:32 ` [PATCH 1/4] -Wmisleading-indentation: don't warn in presence of entirely blank lines David Malcolm
2015-10-29 17:33 ` Jeff Law
2015-10-29 17:38 ` Patrick Palka
2015-10-29 17:44 ` Patrick Palka
2015-10-29 17:50 ` Jeff Law
2015-10-29 17:56 ` Mike Stump
2015-10-29 17:56 ` Patrick Palka [this message]
2015-10-29 18:00 ` Mike Stump
2015-10-29 18:13 ` David Malcolm
2015-10-29 17:59 ` AW: " bernds_cb1
2015-10-29 16:32 ` [PATCH 4/4] Add -Wmisleading-indentation to -Wall David Malcolm
2015-10-29 17:42 ` Jeff Law
2015-10-30 9:16 ` Richard Biener
2015-11-01 22:06 ` Patrick Palka
2015-11-02 16:21 ` David Malcolm
2015-11-02 17:11 ` David Malcolm
2015-11-02 18:39 ` Patrick Palka
2015-11-02 19:35 ` David Malcolm
2015-11-02 20:35 ` Marc Glisse
2015-11-02 23:41 ` Jeff Law
2015-12-09 15:19 ` [PATCH] Add levels to -Wmisleading-indentation; add level 1 " David Malcolm
2015-12-09 15:40 ` Bernd Schmidt
2015-12-09 16:49 ` David Malcolm
2015-12-09 17:19 ` Pedro Alves
2015-12-09 17:34 ` Bernd Schmidt
2015-12-10 15:25 ` [committed 1/5] Fix -Wmisleading-indentation warning in function.c David Malcolm
2015-12-10 15:25 ` [committed 5/5] Fix -Wmisleading-indentation warning in graphite-optimize-isl.c David Malcolm
2015-12-11 16:44 ` Sebastian Pop
2015-12-10 15:25 ` [committed 3/5] Fix -Wmisleading-indentation warning in gcc/regrename.c David Malcolm
2015-12-10 15:25 ` [committed 4/5] Fix -Wmisleading-indentation warning in ifcvt.c David Malcolm
2015-12-10 15:25 ` [committed 2/5] Fix misleading indentation in gcc/fortran/io.c David Malcolm
2015-12-10 15:33 ` [committed 1/5] Fix -Wmisleading-indentation warning in function.c David Malcolm
2015-12-10 18:25 ` [PATCH 4/4] Add -Wmisleading-indentation to -Wall David Malcolm
2015-10-30 5:42 ` [PATCH 0/4] -Wmisleading-indentation Andi Kleen
2015-10-30 5:59 ` Jeff Law
2015-10-30 15:42 ` Mike Stump
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+C-WL_ruD+CHzhDPxNhZLUV6UEg+D12qk5VHXXfYMqEy0Fc9g@mail.gmail.com \
--to=patrick@parcs.ath.cx \
--cc=dmalcolm@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=mikestump@comcast.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).