From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by sourceware.org (Postfix) with ESMTPS id 254423858C27 for ; Tue, 26 Oct 2021 01:17:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 254423858C27 Received: by mail-wm1-x333.google.com with SMTP id z11-20020a1c7e0b000000b0030db7b70b6bso1188152wmc.1 for ; Mon, 25 Oct 2021 18:17:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=4bCc2udLlmxF8PmRRxaPLLVeOL8yruO7K6XTekw7IIo=; b=eoCw/RPncdVoQJGVcTCy+o3ouBl76s+h+4RpQaMClS69TL88RS8nJb134p2jwBsngc Zz6xALlz9pqDjgmPH3Mel8JkuzLmZpZ3hgXcPL0MbKMTa+sCOpfzklp4nLDDO6Vy7T3k xuVanTPsV8cyXGvkvqRggItLUKDJWv/GF4kOeYfNQ33CjG25VQWPhWVXhgOQjbkCRPc6 xdFMYXjX+jJMBVzAj4v4BXYAnPEvRtQujKwGyKN0Fx6/i7oE+nSUhlnYxiTr5A/Ma1uL iH8XwPl1NUfXz9wKoicK6vHLeTlx/hFXKukZeM1llc8jSe5Atew2n1J1kXjzomyv7Ad/ U/lA== X-Gm-Message-State: AOAM531SqEDPoWx9HuPYtG28VQrpjCd8PKAbJ1RqUTDEGr5k+HMBCpho vfj8i2ieabuYkrc9dCFFokW28H0kQcXwVe+3mGY= X-Google-Smtp-Source: ABdhPJwQOy2DSbaAKvERvps5ph62GVCbDq0J5ASYwuJ+MADh4b1GlwP0/cwx1UKyw1NZG1hCQm/yB3L3wllKLMWN40Y= X-Received: by 2002:a1c:4e15:: with SMTP id g21mr20514457wmh.38.1635211072094; Mon, 25 Oct 2021 18:17:52 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Hongyu Wang Date: Tue, 26 Oct 2021 09:11:36 +0800 Message-ID: Subject: Re: [PATCH] testsuite: i386: Fix gcc.target/i386/avx512fp16-trunchf.c on Solaris [PR102835] To: Rainer Orth Cc: GCC Patches Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Oct 2021 01:17:54 -0000 I think this can be put in as an obvious fix. Thanks for the patch. Rainer Orth =E4=BA=8E2021=E5=B9=B410=E6=9C=88= 25=E6=97=A5=E5=91=A8=E4=B8=80 =E4=B8=8B=E5=8D=889:53=E5=86=99=E9=81=93=EF= =BC=9A > > The gcc.target/i386/avx512fp16-trunchf.c test FAILs on 32-bit Solaris/x86= : > > FAIL: gcc.target/i386/avx512fp16-trunchf.c scan-assembler-times vcvttsh2s= i[ \\\\t]+[^{\\n]*(?:%xmm[0-9]|\\\\(%esp\\\\))+, %eax(?:\\n|[ \\\\t]+#) 3 > FAIL: gcc.target/i386/avx512fp16-trunchf.c scan-assembler-times vcvttsh2u= si[ \\\\t]+[^{\\n]*(?:%xmm[0-9]|\\\\(%esp\\\\))+, %eax(?:\\n|[ \\\\t]+#) 2 > > This happens because Solaris defaults to -fno-omit-frame-pointer, so it > uses %ebp instead of the expected %esp. As Hongyu Wang suggested in the > PR, this can be fixed by accepting both forms, which this patch does. > > Tested on i386-pc-solaris2.11 and x86_64-pc-linux-gnu. > > Ok for master? > > Rainer > > -- > -------------------------------------------------------------------------= ---- > Rainer Orth, Center for Biotechnology, Bielefeld University > > > 2021-10-20 Rainer Orth > > gcc/testsuite: > * gcc.target/i386/avx512fp16-trunchf.c: Allow for %esp instead of > %ebp. >