From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com [IPv6:2a00:1450:4864:20::52f]) by sourceware.org (Postfix) with ESMTPS id B3A0E3858C30 for ; Wed, 8 Mar 2023 08:27:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B3A0E3858C30 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ed1-x52f.google.com with SMTP id ec29so31617359edb.6 for ; Wed, 08 Mar 2023 00:27:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678264060; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=J9fDTuHt5uZpkz9yxlHCrM7feAHAvRo6tG3sHyKqFT8=; b=YSqAJrhQGMF9jSDKACuWuVLgsD9YWjOHzrX5SiHPNsahMqCVdYc3iLCu6VAAtt6Ydj GOsAuVhAHUKAtuu2khiDtv1FdncHJ116z6BuT9wTwt950IRYftQzfshW+E0Iova7gOcI 3u146N2Qd57RMb5wSTKFrOdy5mDyffFI3iYwtvFtKl9+ixKOWmSabDQbtIQRjvIzTZuh Qa7+9kkrwHRMBZ/yvCGiEYVjYInly08sMY5pJW9/ubctJ6LlzszwzsVEOoDz88ECNeAV Azr9M1aQng9yNpdH52bkE0uZPM4JfWElGdiCXp2OXhyasSyi94G0Eh3GKwDDvP+UyIJG kblg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678264060; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=J9fDTuHt5uZpkz9yxlHCrM7feAHAvRo6tG3sHyKqFT8=; b=rYxvXm6VEoC3igacooBqGIVxn9sm9gi9tqBVhYfB0tWF5DHpqxypioo9O9ReD0jkWE CnA8WkIk9SHQocJG5wjZQzP//xd2Vv6o//7i1Pr9p9BFNOGa7EKcpK5m/DKV/tYT3IAw S8gjgreVsgOukjkO39hAGTEq9wMC+n+J/1zcoQSOaH116nKw7pmYOZwU3uiAmyf5gHD/ 1jJE0uqaxC7OE1MoUE3dEorjI/YfqQIpj2nNRlbabpIGwucnB9kNg7O9sFZ71WjV5Lga GFO58K2Kf0dbO6fR9lrs3gdou5cgjWXz22T3VrltG9dI0dsasv82NcVLv6CML6GK2KxI cf1w== X-Gm-Message-State: AO0yUKXYJrCGLmLd1Y6RQWAmCOr1Tg0uGXBlofX0XWzRcEexQKgsRJyH EnrdceiBvI/OAfuA1CEaMom7gIK2+WaEAYcVyh1zB21C6+IRjw== X-Google-Smtp-Source: AK7set8ceEaIxfCaAm1xOHLqRNCZGVGFG16ZSTprYpPc8B6r1rk5gSyVr+u8WREbaWrbk3tm2d6ymWxPcbAYv+iEw6I= X-Received: by 2002:a17:906:13c2:b0:8b1:7aec:c8e6 with SMTP id g2-20020a17090613c200b008b17aecc8e6mr8868076ejc.2.1678264060286; Wed, 08 Mar 2023 00:27:40 -0800 (PST) MIME-Version: 1.0 References: <20230308063138.1490431-1-hongyu.wang@intel.com> In-Reply-To: From: Hongyu Wang Date: Wed, 8 Mar 2023 16:21:46 +0800 Message-ID: Subject: Re: [PATCH] libgomp: Fix default value of GOMP_SPINCOUNT [PR 109062] To: Jakub Jelinek Cc: Hongyu Wang , gcc-patches@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.3 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hongyu Wang =E4=BA=8E2023=E5=B9=B43=E6=9C=888=E6= =97=A5=E5=91=A8=E4=B8=89 16:07=E5=86=99=E9=81=93=EF=BC=9A > > > I think the right spot to fix this would be instead in initialize_icvs, > > change the > > icvs->wait_policy =3D 0; > > in there to > > icvs->wait_policy =3D -1; > > That way it will be the default for all the devices, not just the > > initial one. > > It doesn't work, for the code that determines value of wait_policy: > > if (none !=3D NULL && gomp_get_icv_flag (none->flags, GOMP_ICV_WAIT_POLIC= Y)) > wait_policy =3D none->icvs.wait_policy; > else if (all !=3D NULL && gomp_get_icv_flag (all->flags, GOMP_ICV_WAIT_PO= LICY)) > wait_policy =3D all->icvs.wait_policy; > > gomp_get_icv_flag (none->flags, GOMP_ICV_WAIT_POLICY) returns true only w= hen > OMP_WAIT_POLICY is explicitly set, so the initial icvs->wait_policy > could not affect the global wait_policy that used to set > GOMP_SPINCOUNT. Also the global variable wait_policy here is only used for setting spin_count related values that do not belong to any ICV, so there is no need to set icvs->wait_policy since for OMP_WAIT_POLICY_(DEV|ALL) itself only has value 0 for passive and value 1 for active.