From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-x72f.google.com (mail-qk1-x72f.google.com [IPv6:2607:f8b0:4864:20::72f]) by sourceware.org (Postfix) with ESMTPS id ED99E3858036 for ; Sat, 26 Mar 2022 01:08:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org ED99E3858036 Received: by mail-qk1-x72f.google.com with SMTP id d142so7288451qkc.4 for ; Fri, 25 Mar 2022 18:08:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=fbAZUPtDcJ8zAumEUP14Z7pTkAmpanc7qLIUcsDWo2s=; b=ETwPQ48TQ1vrwTJDb0SQMDTbIiQMDFQW41jgCLMAY16NhmdVwa17Ksj24OJLoFekXl N12EtNYCV2uXMJotIG9OIRmMceX3eYx0Z00R0HJAxQ0pkp1BfpnODHwEkcZ0kQC4Af3S lHjpFvNTXIS/KVyy1vCXQi6jVwYS3jM3S1N4IYdmK1y0VqfVP/L9XV51jKtcQiaM9blM C815PYgWwmGxodLA4bc25O5MAOgM/86SXEPFIksJn/W3ZX/kY7BJ/E9EbdMudly2BG21 H9aM9APLVzAFm9KSblTgrGxBjgkZbl0NaQBXCTPnEapgXsVUxmtajFmYRsDmMFr85yHv oMQg== X-Gm-Message-State: AOAM532RYYY/zidkBVpX1LbJ4U2JqRkPiG5fKrieFAegDhay3ywvB3yw cJvJvnataK05Z0kLRr1HAXSc6qdt5M9g2O5ymE4= X-Google-Smtp-Source: ABdhPJy5u8u9WOWWPClhdaW66pWpFpAxYY9x1dkgEAuXwg7mZAsI3diX7+Ma9CW8ipYd61t2THgZKSX7z6Fxgm25b0Y= X-Received: by 2002:a37:3cf:0:b0:67b:1bd3:bc09 with SMTP id 198-20020a3703cf000000b0067b1bd3bc09mr8816388qkd.165.1648256929287; Fri, 25 Mar 2022 18:08:49 -0700 (PDT) MIME-Version: 1.0 References: <20220325205014.32895-1-hjl.tools@gmail.com> In-Reply-To: <20220325205014.32895-1-hjl.tools@gmail.com> From: Hongyu Wang Date: Sat, 26 Mar 2022 09:08:39 +0800 Message-ID: Subject: Re: [PATCH] x86: Use x constraint on KL patterns To: "H.J. Lu" Cc: GCC Patches , liuhongt Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 Mar 2022 01:08:51 -0000 Is it possible to create a test case that gas would throw an error for invalid operands? H.J. Lu via Gcc-patches =E4=BA=8E2022=E5=B9=B43= =E6=9C=8826=E6=97=A5=E5=91=A8=E5=85=AD 04:50=E5=86=99=E9=81=93=EF=BC=9A > > Since KL instructions have no AVX512 version, replace the "v" register > constraint with the "x" register constraint. > > PR target/105058 > * config/i386/sse.md (loadiwkey): Replace "v" with "x". > (aesu8): Likewise. > --- > gcc/config/i386/sse.md | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/gcc/config/i386/sse.md b/gcc/config/i386/sse.md > index 29802d00ce6..33bd2c4768a 100644 > --- a/gcc/config/i386/sse.md > +++ b/gcc/config/i386/sse.md > @@ -28364,8 +28364,8 @@ (define_insn "avx512f_dpbf16ps__mask" > > ;; KEYLOCKER > (define_insn "loadiwkey" > - [(unspec_volatile:V2DI [(match_operand:V2DI 0 "register_operand" "v") > - (match_operand:V2DI 1 "register_operand" "v") > + [(unspec_volatile:V2DI [(match_operand:V2DI 0 "register_operand" "x") > + (match_operand:V2DI 1 "register_operand" "x") > (match_operand:V2DI 2 "register_operand" "Yz") > (match_operand:SI 3 "register_operand" "a")] > UNSPECV_LOADIWKEY) > @@ -28498,7 +28498,7 @@ (define_int_attr aesklvariant > (UNSPECV_AESENC256KLU8 "enc256kl")]) > > (define_insn "aesu8" > - [(set (match_operand:V2DI 0 "register_operand" "=3Dv") > + [(set (match_operand:V2DI 0 "register_operand" "=3Dx") > (unspec_volatile:V2DI [(match_operand:V2DI 1 "register_operand" "= 0") > (match_operand:BLK 2 "memory_operand" "m= ")] > AESDECENCKL)) > -- > 2.35.1 >