From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [IPv6:2a00:1450:4864:20::62e]) by sourceware.org (Postfix) with ESMTPS id 2797B3834E14 for ; Wed, 14 Dec 2022 08:01:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2797B3834E14 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ej1-x62e.google.com with SMTP id b2so42557064eja.7 for ; Wed, 14 Dec 2022 00:01:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ZDZziKavZKyCjHzmolVxtreSkvHgWK9DucT+SbtduUQ=; b=OOdlWNExJvz3n7ueDenoCKqnypOy4ePgkwBnxq8so0iqdvM2DEvLWDuiuKCad5FBJV gZ3JXNZMwWCpbXizN+nQeCZNQn7+WO7h8W6T+9E/PbmRHKeMYcijF7260XX7Hh6he+6h XjzublinqbDq8OSDodZT06EO9s7vVay3cAeVQOuOPWma4skM9msg143nWepxwGin/oaO S4A3tGZPoQX90CUI52zlBHjKFL7G3jUscjtLY/FJ4R4O1ouJFkkkPJahGdaJQk3qGGqO gI43GrpIrHaFhKRa/LVH66ExPbd0DxcGDKuzJrO6d67rrRVZESrL8EkA5ed7XbWZmN+a FQGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZDZziKavZKyCjHzmolVxtreSkvHgWK9DucT+SbtduUQ=; b=Erp8tKOnsOqgK/Z9ZroVcI8uFuC9gYQyiydQ95imuQboAL39KjENWiwElBor0hFF8n moXZdpNqdFlauPVyuR2jgDXRl3Gb5Vv1nfisP5u1liwETjePfCJwmbRPR52lZ3xB7AUX wc/vVYoJSzc0vNh5OYXzNJqJfrEm96oQGtgmKiOn4JXptfKw+E4IptSt0s6jvTfSK81H 4kgrRRLwxw5tNDJrOULC2ZgRoC3TBdwtFDVQyqbR048o7SCbWu5qt1whaM04WKwXzdtB s6a991PDmath4wVtgjV8UoHSzAfgL4TztfWXw+r7PnB4MuOrKqrhB6AP6Fwp1dh+as/h q5iQ== X-Gm-Message-State: ANoB5pmUDZFyBZRHOlrhVSE/KkCKxMi9ojgZ9IZE5aJ1sbVvV0THzlKS OTKDkN/JJMwTe81YP7FpOnEnPg+/GP3CllmUkfc= X-Google-Smtp-Source: AA0mqf5nJoGX0hfRJHTsARMjUtdRQRGBOLn7LvfDfSZfJ+xB/dGuqkyVbzNuIohR7v8IeHz4mYtL16+AkdJXmwzyyBM= X-Received: by 2002:a17:906:2988:b0:7c0:b56a:eadf with SMTP id x8-20020a170906298800b007c0b56aeadfmr8976219eje.271.1671004877517; Wed, 14 Dec 2022 00:01:17 -0800 (PST) MIME-Version: 1.0 References: <20221207063644.100134-1-hongyu.wang@intel.com> In-Reply-To: From: Hongyu Wang Date: Wed, 14 Dec 2022 15:55:41 +0800 Message-ID: Subject: Re: [PATCH] i386: Avoid fma_chain for -march=alderlake and sapphirerapids. To: Uros Bizjak Cc: Hongyu Wang , gcc-patches@gcc.gnu.org, hongtao.liu@intel.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: If there is no objection, I'm going to backport the m_SAPPHIRERAPIDS and m_ALDERLAKE change to GCC 12. Uros Bizjak via Gcc-patches =E4=BA=8E2022=E5=B9= =B412=E6=9C=887=E6=97=A5=E5=91=A8=E4=B8=89 15:11=E5=86=99=E9=81=93=EF=BC=9A > > On Wed, Dec 7, 2022 at 7:36 AM Hongyu Wang wrote: > > > > For Alderlake there is similar issue like PR 81616, enable > > avoid_fma256_chain will also benefit on Intel latest platforms > > Alderlake and Sapphire Rapids. > > > > Bootstrapped/regtested on x86_64-pc-linux-gnu{-m32,}. > > > > Ok for master? > > > > gcc/ChangeLog: > > > > * config/i386/x86-tune.def (X86_TUNE_AVOID_256FMA_CHAINS): Add > > m_SAPPHIRERAPIDS, m_ALDERLAKE and m_CORE_ATOM. > > OK. > > Thanks, > Uros. > > > --- > > gcc/config/i386/x86-tune.def | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/gcc/config/i386/x86-tune.def b/gcc/config/i386/x86-tune.de= f > > index cd66f335113..db85de20bae 100644 > > --- a/gcc/config/i386/x86-tune.def > > +++ b/gcc/config/i386/x86-tune.def > > @@ -499,7 +499,8 @@ DEF_TUNE (X86_TUNE_AVOID_128FMA_CHAINS, "avoid_fma_= chains", m_ZNVER) > > > > /* X86_TUNE_AVOID_256FMA_CHAINS: Avoid creating loops with tight 256bi= t or > > smaller FMA chain. */ > > -DEF_TUNE (X86_TUNE_AVOID_256FMA_CHAINS, "avoid_fma256_chains", m_ZNVER= 2 | m_ZNVER3) > > +DEF_TUNE (X86_TUNE_AVOID_256FMA_CHAINS, "avoid_fma256_chains", m_ZNVER= 2 | m_ZNVER3 > > + | m_ALDERLAKE | m_SAPPHIRERAPIDS | m_CORE_ATOM) > > > > /* X86_TUNE_V2DF_REDUCTION_PREFER_PHADDPD: Prefer haddpd > > for v2df vector reduction. */ > > -- > > 2.18.1 > >