From: Hongyu Wang <wwwhhhyyy333@gmail.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: Kirill Yukhin <kirill.yukhin@gmail.com>,
Uros Bizjak <ubizjak@gmail.com>,
GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [committed] testsuite: Fix up amx* dg-do run tests with older binutils
Date: Wed, 30 Sep 2020 22:05:10 +0800 [thread overview]
Message-ID: <CA+OydWnxpQ3cGF-fKEtupLQZ6a=OPPJvc1_ht4cJ9SVhFjt0Jg@mail.gmail.com> (raw)
In-Reply-To: <20200930115142.GO2176@tucnak>
Thanks for the fix! I forgot that we don't have builtin check for
target-supports.exp.
Will update these once we implement AMX with builtins.
Jakub Jelinek <jakub@redhat.com> 于2020年9月30日周三 下午7:51写道：
> On Fri, Sep 18, 2020 at 04:31:55PM +0800, Hongyu Wang via Gcc-patches
> wrote:
> > Very Appreciated for your review again
> >
> > I just update the patch with adding XSAVE dependency and use
> > __builtin_cpu_supports for runtime test.
>
> Several tests FAIL when using older binutils that don't support AMX.
>
> Fixed thusly, tested on x86_64-linux -m32/-m64, committed to trunk as
> obvious:
>
> 2020-09-30 Jakub Jelinek <jakub@redhat.com>
>
> * gcc.target/i386/amxint8-dpbssd-2.c: Require effective targets
> amx_tile and amx_int8.
> * gcc.target/i386/amxint8-dpbsud-2.c: Likewise.
> * gcc.target/i386/amxint8-dpbusd-2.c: Likewise.
> * gcc.target/i386/amxint8-dpbuud-2.c: Likewise.
> * gcc.target/i386/amxbf16-dpbf16ps-2.c: Require effective targets
> amx_tile and amx_bf16.
> * gcc.target/i386/amxtile-2.c: Require effective target amx_tile.
>
> --- gcc/testsuite/gcc.target/i386/amxint8-dpbssd-2.c.jj 2020-09-29
> 11:32:02.950602758 +0200
> +++ gcc/testsuite/gcc.target/i386/amxint8-dpbssd-2.c 2020-09-30
> 13:16:08.186445881 +0200
> @@ -1,4 +1,6 @@
> /* { dg-do run { target { ! ia32 } } } */
> +/* { dg-require-effective-target amx_tile } */
> +/* { dg-require-effective-target amx_int8 } */
> /* { dg-options "-O2 -mamx-tile -mamx-int8" } */
> #include <immintrin.h>
>
> --- gcc/testsuite/gcc.target/i386/amxint8-dpbsud-2.c.jj 2020-09-29
> 11:32:02.950602758 +0200
> +++ gcc/testsuite/gcc.target/i386/amxint8-dpbsud-2.c 2020-09-30
> 13:16:23.715221450 +0200
> @@ -1,4 +1,6 @@
> /* { dg-do run { target { ! ia32 } } } */
> +/* { dg-require-effective-target amx_tile } */
> +/* { dg-require-effective-target amx_int8 } */
> /* { dg-options "-O2 -mamx-tile -mamx-int8" } */
> #include <immintrin.h>
>
> --- gcc/testsuite/gcc.target/i386/amxint8-dpbusd-2.c.jj 2020-09-29
> 11:32:02.950602758 +0200
> +++ gcc/testsuite/gcc.target/i386/amxint8-dpbusd-2.c 2020-09-30
> 13:16:28.998145100 +0200
> @@ -1,4 +1,6 @@
> /* { dg-do run { target { ! ia32 } } } */
> +/* { dg-require-effective-target amx_tile } */
> +/* { dg-require-effective-target amx_int8 } */
> /* { dg-options "-O2 -mamx-tile -mamx-int8" } */
> #include <immintrin.h>
>
> --- gcc/testsuite/gcc.target/i386/amxint8-dpbuud-2.c.jj 2020-09-29
> 11:32:02.950602758 +0200
> +++ gcc/testsuite/gcc.target/i386/amxint8-dpbuud-2.c 2020-09-30
> 13:16:35.770047224 +0200
> @@ -1,4 +1,6 @@
> /* { dg-do run { target { ! ia32 } } } */
> +/* { dg-require-effective-target amx_tile } */
> +/* { dg-require-effective-target amx_int8 } */
> /* { dg-options "-O2 -mamx-tile -mamx-int8" } */
> #include <immintrin.h>
>
> --- gcc/testsuite/gcc.target/i386/amxbf16-dpbf16ps-2.c.jj 2020-09-29
> 11:32:02.949602773 +0200
> +++ gcc/testsuite/gcc.target/i386/amxbf16-dpbf16ps-2.c 2020-09-30
> 13:15:41.079837637 +0200
> @@ -1,4 +1,6 @@
> /* { dg-do run { target { ! ia32 } } } */
> +/* { dg-require-effective-target amx_tile } */
> +/* { dg-require-effective-target amx_bf16 } */
> /* { dg-options "-O2 -mamx-tile -mamx-bf16" } */
> #include <immintrin.h>
>
> --- gcc/testsuite/gcc.target/i386/amxtile-2.c.jj 2020-09-29
> 11:32:02.950602758 +0200
> +++ gcc/testsuite/gcc.target/i386/amxtile-2.c 2020-09-30
> 13:16:57.972726339 +0200
> @@ -1,4 +1,5 @@
> /* { dg-do run { target { ! ia32 } } } */
> +/* { dg-require-effective-target amx_tile } */
> /* { dg-options "-O2 -mamx-tile " } */
> #include <immintrin.h>
>
>
>
> Jakub
>
>
--
Regards,
Hongyu, Wang
next prev parent reply other threads:[~2020-09-30 14:05 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-06 1:58 [PATCH] Enable GCC support for AMX Hongyu Wang
2020-07-07 3:24 ` Hongyu Wang
2020-07-17 5:40 ` Hongyu Wang
2020-07-24 5:41 ` Hongyu Wang
2020-08-04 12:17 ` Hongyu Wang
2020-08-04 14:47 ` Kirill Yukhin
2020-08-04 15:40 ` Hongyu Wang
2020-09-01 1:31 ` Hongyu Wang
2020-09-03 15:07 ` Kirill Yukhin
2020-09-03 15:17 ` H.J. Lu
2020-09-04 14:01 ` Kirill Yukhin
2020-09-11 17:00 ` Hongyu Wang
2020-09-18 8:31 ` Hongyu Wang
2020-09-30 11:51 ` [committed] testsuite: Fix up amx* dg-do run tests with older binutils Jakub Jelinek
2020-09-30 14:05 ` Hongyu Wang [this message]
2020-09-28 11:38 ` [PATCH] Enable GCC support for AMX Kirill Yukhin
2020-09-28 12:07 ` Hongyu Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+OydWnxpQ3cGF-fKEtupLQZ6a=OPPJvc1_ht4cJ9SVhFjt0Jg@mail.gmail.com' \
--to=wwwhhhyyy333@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=kirill.yukhin@gmail.com \
--cc=ubizjak@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).