From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) by sourceware.org (Postfix) with ESMTPS id 79D36398792F for ; Wed, 30 Sep 2020 14:05:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 79D36398792F Received: by mail-wm1-x32a.google.com with SMTP id k18so1912211wmj.5 for ; Wed, 30 Sep 2020 07:05:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4RD5RtBvcBUzZ7qhiVs/BXrq8hnqH10lUNKCNlCELEM=; b=rOqcHKfZJbadxKAkHZs06pDgqbrHQFPaLI6n7wSPZzmk2nt3xhUy3wQkNZwvTNH3NF dtW2YQ9BKPmM1hwG8E9fYYL/HGAMCWjzlACG/2gWSS0JPNgdlSHH+ZMPNS0mk9sL8N6p f6zG2dZohNIkoFGJgY6N13NIn7TiIPXeePjzNOWKkICwZ23LmrUJZrbzyfZWwiFt2XoV ujcyOPS8XSw8IHpz/uGhdoT4fPGXhhR133LGlGmrAtWfgiSAXBdf67DueHpK7LWJxQzA SF26IKFCEvgiE96OXj3Jj7yfnT+Bmtl3mzHUdROfktu8ifd4i1IjwwV56dQxwoSYQvYS EZrQ== X-Gm-Message-State: AOAM533OApgLmWH83RT3gk1Uj7LJYKX0qqmaO/bckPJWPxg0nQAaoN5j 4suY9ZMYHGTVob8OWHtczXVKXCQM3BwIG+RABCY= X-Google-Smtp-Source: ABdhPJyqp9Si+xO6zuSn3QoeeG7cgciW3ft3tQSWV1r7UsvssI3yqv2stE+xyU4NZd+4JC0c62N+euz5l3XmOdvSONk= X-Received: by 2002:a05:600c:2054:: with SMTP id p20mr3186750wmg.173.1601474721536; Wed, 30 Sep 2020 07:05:21 -0700 (PDT) MIME-Version: 1.0 References: <20200903150743.gfzofhl3huifeq4x@kyukhin> <20200904140159.r6biwwb74qnj7dhc@kyukhin> <20200930115142.GO2176@tucnak> In-Reply-To: <20200930115142.GO2176@tucnak> From: Hongyu Wang Date: Wed, 30 Sep 2020 22:05:10 +0800 Message-ID: Subject: Re: [committed] testsuite: Fix up amx* dg-do run tests with older binutils To: Jakub Jelinek Cc: Kirill Yukhin , Uros Bizjak , GCC Patches X-Spam-Status: No, score=-1.4 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, HTML_MESSAGE, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Sep 2020 14:05:24 -0000 Thanks for the fix! I forgot that we don't have builtin check for target-supports.exp. Will update these once we implement AMX with builtins. Jakub Jelinek =E4=BA=8E2020=E5=B9=B49=E6=9C=8830=E6=97= =A5=E5=91=A8=E4=B8=89 =E4=B8=8B=E5=8D=887:51=E5=86=99=E9=81=93=EF=BC=9A > On Fri, Sep 18, 2020 at 04:31:55PM +0800, Hongyu Wang via Gcc-patches > wrote: > > Very Appreciated for your review again > > > > I just update the patch with adding XSAVE dependency and use > > __builtin_cpu_supports for runtime test. > > Several tests FAIL when using older binutils that don't support AMX. > > Fixed thusly, tested on x86_64-linux -m32/-m64, committed to trunk as > obvious: > > 2020-09-30 Jakub Jelinek > > * gcc.target/i386/amxint8-dpbssd-2.c: Require effective targets > amx_tile and amx_int8. > * gcc.target/i386/amxint8-dpbsud-2.c: Likewise. > * gcc.target/i386/amxint8-dpbusd-2.c: Likewise. > * gcc.target/i386/amxint8-dpbuud-2.c: Likewise. > * gcc.target/i386/amxbf16-dpbf16ps-2.c: Require effective targets > amx_tile and amx_bf16. > * gcc.target/i386/amxtile-2.c: Require effective target amx_tile. > > --- gcc/testsuite/gcc.target/i386/amxint8-dpbssd-2.c.jj 2020-09-29 > 11:32:02.950602758 +0200 > +++ gcc/testsuite/gcc.target/i386/amxint8-dpbssd-2.c 2020-09-30 > 13:16:08.186445881 +0200 > @@ -1,4 +1,6 @@ > /* { dg-do run { target { ! ia32 } } } */ > +/* { dg-require-effective-target amx_tile } */ > +/* { dg-require-effective-target amx_int8 } */ > /* { dg-options "-O2 -mamx-tile -mamx-int8" } */ > #include > > --- gcc/testsuite/gcc.target/i386/amxint8-dpbsud-2.c.jj 2020-09-29 > 11:32:02.950602758 +0200 > +++ gcc/testsuite/gcc.target/i386/amxint8-dpbsud-2.c 2020-09-30 > 13:16:23.715221450 +0200 > @@ -1,4 +1,6 @@ > /* { dg-do run { target { ! ia32 } } } */ > +/* { dg-require-effective-target amx_tile } */ > +/* { dg-require-effective-target amx_int8 } */ > /* { dg-options "-O2 -mamx-tile -mamx-int8" } */ > #include > > --- gcc/testsuite/gcc.target/i386/amxint8-dpbusd-2.c.jj 2020-09-29 > 11:32:02.950602758 +0200 > +++ gcc/testsuite/gcc.target/i386/amxint8-dpbusd-2.c 2020-09-30 > 13:16:28.998145100 +0200 > @@ -1,4 +1,6 @@ > /* { dg-do run { target { ! ia32 } } } */ > +/* { dg-require-effective-target amx_tile } */ > +/* { dg-require-effective-target amx_int8 } */ > /* { dg-options "-O2 -mamx-tile -mamx-int8" } */ > #include > > --- gcc/testsuite/gcc.target/i386/amxint8-dpbuud-2.c.jj 2020-09-29 > 11:32:02.950602758 +0200 > +++ gcc/testsuite/gcc.target/i386/amxint8-dpbuud-2.c 2020-09-30 > 13:16:35.770047224 +0200 > @@ -1,4 +1,6 @@ > /* { dg-do run { target { ! ia32 } } } */ > +/* { dg-require-effective-target amx_tile } */ > +/* { dg-require-effective-target amx_int8 } */ > /* { dg-options "-O2 -mamx-tile -mamx-int8" } */ > #include > > --- gcc/testsuite/gcc.target/i386/amxbf16-dpbf16ps-2.c.jj 2020-09-2= 9 > 11:32:02.949602773 +0200 > +++ gcc/testsuite/gcc.target/i386/amxbf16-dpbf16ps-2.c 2020-09-30 > 13:15:41.079837637 +0200 > @@ -1,4 +1,6 @@ > /* { dg-do run { target { ! ia32 } } } */ > +/* { dg-require-effective-target amx_tile } */ > +/* { dg-require-effective-target amx_bf16 } */ > /* { dg-options "-O2 -mamx-tile -mamx-bf16" } */ > #include > > --- gcc/testsuite/gcc.target/i386/amxtile-2.c.jj 2020-09-29 > 11:32:02.950602758 +0200 > +++ gcc/testsuite/gcc.target/i386/amxtile-2.c 2020-09-30 > 13:16:57.972726339 +0200 > @@ -1,4 +1,5 @@ > /* { dg-do run { target { ! ia32 } } } */ > +/* { dg-require-effective-target amx_tile } */ > /* { dg-options "-O2 -mamx-tile " } */ > #include > > > > Jakub > > --=20 Regards, Hongyu, Wang