From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) by sourceware.org (Postfix) with ESMTPS id 7EC683858C5F for ; Thu, 16 Feb 2023 13:52:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7EC683858C5F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=iki.fi Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pj1-f45.google.com with SMTP id r9-20020a17090a2e8900b00233ba727724so5960921pjd.1 for ; Thu, 16 Feb 2023 05:52:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=9rQCaKUe9/41SmbwdmFtGO87R5SOtps/joYfCGH/Aw4=; b=Sw6G0pXSIhs3eneP/QSBZysPyC5cnKwiC6v83gWfojHKpmrPTY+qHzfTE4y8nuKkr6 1Fkfx3bqA8tas/2DR3Hti664tiLrUPOk1xZFZY+DBfQ9gxz2MrBTqlXsjrTn/wG1MdoB I0jsmYr9jVRB+C0dLGxus23Nf0sRFQ38I3JMboMWOWCT/G5NEQGxOdjfJNf5qW4bW11N kZwMN4qtY770UpNLsw1OaVqnUsfoJnO0CXEBlES8cwDfKXf06pkLtxmzjoLttqDb2gen ItC9qcHTGHKABK8wGcrWrZ/3ORAOE3tcTMn36tHMJfsW9pXcJZ1CiVRa4Ho9mN2uQPyJ 7tEA== X-Gm-Message-State: AO0yUKXgu9rZSf37k9bo3S69iOBw7lIB0g48rrJujVAKYuWSRwokMuSr nNE/XBhXBFV9OjtIKu2CdiiZpSp2cDLWPgdYaXw= X-Google-Smtp-Source: AK7set/eTODt0cgN3YwNqdTMM7aN+TERrfsfUunQq2ZveIxJq4lr5b+bK/aR1m4+TI0KI9k+2tIdUhpHPvkXLyMX33U= X-Received: by 2002:a17:90b:1a84:b0:234:8e4:7a5e with SMTP id ng4-20020a17090b1a8400b0023408e47a5emr590453pjb.128.1676555554411; Thu, 16 Feb 2023 05:52:34 -0800 (PST) MIME-Version: 1.0 References: <20230216075005.2600-1-shihua@iscas.ac.cn> In-Reply-To: From: Markku-Juhani Olavi Saarinen Date: Thu, 16 Feb 2023 13:52:24 +0000 Message-ID: Subject: Re: [PATCH V2 0/5] RISC-V: Implement Scalar Cryptography Extension To: Kito Cheng Cc: Liao Shihua , gcc-patches@gcc.gnu.org, jiawei@iscas.ac.cn, palmer@dabbelt.com, shiyulong@iscas.ac.cn, ben.marshall@pqshield.com, christoph.muellner@vrull.eu Content-Type: multipart/alternative; boundary="000000000000445a6105f4d1825a" X-Spam-Status: No, score=-1.4 required=5.0 tests=BAYES_00,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,KAM_DMARC_STATUS,KAM_SHORT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000445a6105f4d1825a Content-Type: text/plain; charset="UTF-8" On Thu, Feb 16, 2023, 13:29 Kito Cheng wrote: > Hi Shihua: > > Thanks for your patches! This patch set is generally in good shape, > but I would prefer to remove riscv_scalar_crypto.h at this moment > since it's NOT standardized yet. > Hi Kito, I'm not sure if you're referring to the scalar crypto extensions (which were fully ratified in November 2021 by RVI, are included in several profiles, and available in commercial silicon IP), or this particular header file. Note that the single header is perhaps the most convenient way to access these subextensions that make up the scalar crypto extension 1.0. Cheers, Markku > > Do you mind sending a new version of this patch set which does not > include that and also update the testcases? > > > > On Thu, Feb 16, 2023 at 3:52 PM Liao Shihua wrote: > > > > This series adds basic support for the Scalar Cryptography extensions: > > * Zbkb > > * Zbkc > > * Zbkx > > * Zknd > > * Zkne > > * Zknh > > * Zksed > > * Zksh > > > > The implementation follows the version Scalar Cryptography v1.0.0 of the > specification, > > and the intrinsic of Scalar Cryptography extensions follows riscv-c-api > > which can be found here: > > https://github.com/riscv/riscv-crypto/releases/tag/v1.0.0-scalar > > https://github.com/riscv-non-isa/riscv-c-api-doc/pull/31 > > > > It works by Wu Siyu and Liao Shihua . > > > > Liao Shihua (5): > > Add prototypes for RISC-V Crypto built-in functions > > Implement ZBKB, ZBKC and ZBKX extensions > > Implement ZKND and ZKNE extensions > > Implement ZKNH extensions > > Implement ZKSH and ZKSED extensions > > > > gcc/config.gcc | 2 +- > > gcc/config/riscv/bitmanip.md | 20 +- > > gcc/config/riscv/constraints.md | 8 + > > gcc/config/riscv/crypto.md | 435 ++++++++++++++++++ > > gcc/config/riscv/riscv-builtins.cc | 26 ++ > > gcc/config/riscv/riscv-crypto.def | 94 ++++ > > gcc/config/riscv/riscv-ftypes.def | 10 + > > gcc/config/riscv/riscv.md | 4 +- > > gcc/config/riscv/riscv_scalar_crypto.h | 218 +++++++++ > > gcc/testsuite/gcc.target/riscv/zbkb32.c | 36 ++ > > gcc/testsuite/gcc.target/riscv/zbkb64.c | 28 ++ > > gcc/testsuite/gcc.target/riscv/zbkc32.c | 17 + > > gcc/testsuite/gcc.target/riscv/zbkc64.c | 17 + > > gcc/testsuite/gcc.target/riscv/zbkx32.c | 18 + > > gcc/testsuite/gcc.target/riscv/zbkx64.c | 18 + > > gcc/testsuite/gcc.target/riscv/zknd32.c | 18 + > > gcc/testsuite/gcc.target/riscv/zknd64.c | 36 ++ > > gcc/testsuite/gcc.target/riscv/zkne32.c | 18 + > > gcc/testsuite/gcc.target/riscv/zkne64.c | 30 ++ > > gcc/testsuite/gcc.target/riscv/zknh-sha256.c | 29 ++ > > .../gcc.target/riscv/zknh-sha512-32.c | 43 ++ > > .../gcc.target/riscv/zknh-sha512-64.c | 31 ++ > > gcc/testsuite/gcc.target/riscv/zksed.c | 20 + > > gcc/testsuite/gcc.target/riscv/zksh.c | 19 + > > 24 files changed, 1183 insertions(+), 12 deletions(-) > > create mode 100644 gcc/config/riscv/crypto.md > > create mode 100644 gcc/config/riscv/riscv-crypto.def > > create mode 100644 gcc/config/riscv/riscv_scalar_crypto.h > > create mode 100644 gcc/testsuite/gcc.target/riscv/zbkb32.c > > create mode 100644 gcc/testsuite/gcc.target/riscv/zbkb64.c > > create mode 100644 gcc/testsuite/gcc.target/riscv/zbkc32.c > > create mode 100644 gcc/testsuite/gcc.target/riscv/zbkc64.c > > create mode 100644 gcc/testsuite/gcc.target/riscv/zbkx32.c > > create mode 100644 gcc/testsuite/gcc.target/riscv/zbkx64.c > > create mode 100644 gcc/testsuite/gcc.target/riscv/zknd32.c > > create mode 100644 gcc/testsuite/gcc.target/riscv/zknd64.c > > create mode 100644 gcc/testsuite/gcc.target/riscv/zkne32.c > > create mode 100644 gcc/testsuite/gcc.target/riscv/zkne64.c > > create mode 100644 gcc/testsuite/gcc.target/riscv/zknh-sha256.c > > create mode 100644 gcc/testsuite/gcc.target/riscv/zknh-sha512-32.c > > create mode 100644 gcc/testsuite/gcc.target/riscv/zknh-sha512-64.c > > create mode 100644 gcc/testsuite/gcc.target/riscv/zksed.c > > create mode 100644 gcc/testsuite/gcc.target/riscv/zksh.c > > > > -- > > 2.38.1.windows.1 > > > --000000000000445a6105f4d1825a--