From: KuanLin Chen <best124612@gmail.com>
To: gcc-patches@gcc.gnu.org, juzhe.zhong@rivai.ai
Cc: kito.cheng@sifive.com, palmer@rivosinc.com, rdapp.gcc@gmail.com,
jeffreyalaw@gmail.com
Subject: Re: [PATCH] RISC-V: Add _mu C++ overloaded intrinsics for load && viota && vid
Date: Fri, 2 Jun 2023 09:26:09 +0800 [thread overview]
Message-ID: <CA+jpiRcxaYkG=HgeziOAciJqeq+DgrcyM9=JTF6Os++=o4ZmkA@mail.gmail.com> (raw)
In-Reply-To: <20230601230441.294259-1-juzhe.zhong@rivai.ai>
Hi Juzhe,
I think fault_load_def::get_name should remove "instance.pred ==
PRED_TYPE_mu", right?
<juzhe.zhong@rivai.ai> 於 2023年6月2日 週五 上午7:05寫道:
>
> From: Juzhe-Zhong <juzhe.zhong@rivai.ai>
>
> Base on these:
> https://github.com/riscv-non-isa/rvv-intrinsic-doc/issues/232
> https://github.com/riscv-non-isa/rvv-intrinsic-doc/pull/233
>
> Add _mu C++ overloaded intrinsics for load && viota && vid.
>
> gcc/ChangeLog:
>
> * config/riscv/riscv-vector-builtins-bases.cc: Add _mu overloaded intrinsics.
>
> ---
> gcc/config/riscv/riscv-vector-builtins-bases.cc | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/gcc/config/riscv/riscv-vector-builtins-bases.cc b/gcc/config/riscv/riscv-vector-builtins-bases.cc
> index a8113f6602b..498c6ba042e 100644
> --- a/gcc/config/riscv/riscv-vector-builtins-bases.cc
> +++ b/gcc/config/riscv/riscv-vector-builtins-bases.cc
> @@ -164,7 +164,7 @@ public:
> {
> if (STORE_P || LST_TYPE == LST_INDEXED)
> return true;
> - return pred != PRED_TYPE_none && pred != PRED_TYPE_mu;
> + return pred != PRED_TYPE_none;
> }
>
> rtx expand (function_expander &e) const override
> @@ -963,7 +963,7 @@ public:
> bool can_be_overloaded_p (enum predication_type_index pred) const override
> {
> return pred == PRED_TYPE_tu || pred == PRED_TYPE_tum
> - || pred == PRED_TYPE_tumu;
> + || pred == PRED_TYPE_tumu || pred == PRED_TYPE_mu;
> }
>
> rtx expand (function_expander &e) const override
> @@ -979,7 +979,7 @@ public:
> bool can_be_overloaded_p (enum predication_type_index pred) const override
> {
> return pred == PRED_TYPE_tu || pred == PRED_TYPE_tum
> - || pred == PRED_TYPE_tumu;
> + || pred == PRED_TYPE_tumu || pred == PRED_TYPE_mu;
> }
>
> rtx expand (function_expander &e) const override
> @@ -1749,7 +1749,7 @@ public:
>
> bool can_be_overloaded_p (enum predication_type_index pred) const override
> {
> - return pred != PRED_TYPE_none && pred != PRED_TYPE_mu;
> + return pred != PRED_TYPE_none;
> }
>
> rtx expand (function_expander &e) const override
> @@ -1794,7 +1794,7 @@ public:
>
> bool can_be_overloaded_p (enum predication_type_index pred) const override
> {
> - return pred != PRED_TYPE_none && pred != PRED_TYPE_mu;
> + return pred != PRED_TYPE_none;
> }
>
> rtx expand (function_expander &e) const override
> --
> 2.36.1
>
next prev parent reply other threads:[~2023-06-02 1:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-01 23:04 juzhe.zhong
2023-06-02 1:26 ` KuanLin Chen [this message]
2023-06-02 1:32 ` juzhe.zhong
2023-06-02 2:04 juzhe.zhong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+jpiRcxaYkG=HgeziOAciJqeq+DgrcyM9=JTF6Os++=o4ZmkA@mail.gmail.com' \
--to=best124612@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jeffreyalaw@gmail.com \
--cc=juzhe.zhong@rivai.ai \
--cc=kito.cheng@sifive.com \
--cc=palmer@rivosinc.com \
--cc=rdapp.gcc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).