From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vk1-xa2c.google.com (mail-vk1-xa2c.google.com [IPv6:2607:f8b0:4864:20::a2c]) by sourceware.org (Postfix) with ESMTPS id 2A8AC3858C33; Wed, 26 Jul 2023 01:23:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2A8AC3858C33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-vk1-xa2c.google.com with SMTP id 71dfb90a1353d-486518f0ed4so13412e0c.3; Tue, 25 Jul 2023 18:23:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1690334588; x=1690939388; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=11JusQnVBnDrOcHUAEEfX8xG3pNmXYnsEMNpq0DBZeE=; b=rQ983ubF+HEhUJutKUOw0Ksz7FoiVOoK/tGT26hhpgaQYtUfRZY0n3WZ27TKsAiby7 70MvZe2/CGKacrUAauqrgLNuxYAAMVWiNI0ySJ9mgZ1ErnBtymVdOi42jKqKMk8MpJKL jmEscoX6n5KfnPnJkC2DjErN5Wy35LY4oEoLmRvtpcw9Uy2+Db1+x/WZQubgEjDFIRmf Xyc0yxYbms0tFmsbWvgLciBY7RoasToi/P8nk6fboCRuezP6I+XzaCe+Zo8A2PKRm9PQ os3sczN3QuGI+9nCeTemyz2/0LrUYyrLl+hicDxa45wDlt8jrUK12o+VTOFma5Pxk3gZ GYyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690334588; x=1690939388; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=11JusQnVBnDrOcHUAEEfX8xG3pNmXYnsEMNpq0DBZeE=; b=Mk5HNaQ4nlZtOq5iEi+FzTOT2vV66MHiLgtxo+7aliqA1YVlmixGDvQASNLOIVbdBN ucZEcokR2aDE1C6dUOgzv0de9+N55ZpxXkD+WWmD4UjfeDz3biFk5XeRG9HTKF2pDcnp CfBTiaaF1SjPqrwtEyq7SnG66Wdp4RMzi8maXUC1siolafyR/JJr7jQ8CHcpHgQcndTG Dnai0c3fydKrTrQqYgTwQosmFbW8cX9PTLewrAoOUyjz704UZMQXTpT3VsbPDldvgHlD vUd+1FtX03o1geibRnhmK81p/XQU5q576Mg+BUqoiZVjQB0Xbx73CbHkLHFuOeZj+Q+t TKJA== X-Gm-Message-State: ABy/qLYb9kIpjkPg8eHbEv+BEcIg5IIppiK54l0oSUWJ+JoX7W84CXmi SqCI+KHhwA41rpNOtTWu4h/lBaMoCN+5l6rwpk4= X-Google-Smtp-Source: APBJJlFf5AgMsT+t+VNdW9JMTS62qVIfKWoZ7AoMYBNLB6++kE6fdBFHsSQkmKPIlCOtQcWtPFbW7IDMljOsKQ76OSc= X-Received: by 2002:a1f:5c54:0:b0:486:42ab:6a46 with SMTP id q81-20020a1f5c54000000b0048642ab6a46mr60261vkb.13.1690334588327; Tue, 25 Jul 2023 18:23:08 -0700 (PDT) MIME-Version: 1.0 References: <20230427162301.1151333-1-patrick@rivosinc.com> <20230725180206.284777-1-patrick@rivosinc.com> <20230725180206.284777-13-patrick@rivosinc.com> In-Reply-To: <20230725180206.284777-13-patrick@rivosinc.com> From: Kito Cheng Date: Wed, 26 Jul 2023 09:22:57 +0800 Message-ID: Subject: Re: [gcc13 backport 12/12] riscv: fix error: control reaches end of non-void function To: "Patrick O'Neill" Cc: gcc-patches@gcc.gnu.org, jeffreyalaw@gmail.com, palmer@rivosinc.com, vineetg@rivosinc.com, andrew@sifive.com, kito.cheng@sifive.com, dlustig@nvidia.com, cmuellner@gcc.gnu.org, andrea@rivosinc.com, hboehm@google.com, Martin Liska Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-8.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: OK for backport :) On Wed, Jul 26, 2023 at 2:11=E2=80=AFAM Patrick O'Neill wrote: > > From: Martin Liska > > Fixes: > gcc/config/riscv/sync.md:66:1: error: control reaches end of non-void fun= ction [-Werror=3Dreturn-type] > 66 | [(set (attr "length") (const_int 4))]) > | ^ > > PR target/109713 > > gcc/ChangeLog: > > * config/riscv/sync.md: Add gcc_unreachable to a switch. > --- > gcc/config/riscv/sync.md | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/gcc/config/riscv/sync.md b/gcc/config/riscv/sync.md > index 6e7c762ac57..9fc626267de 100644 > --- a/gcc/config/riscv/sync.md > +++ b/gcc/config/riscv/sync.md > @@ -62,6 +62,8 @@ > return "fence\tr,rw"; > else if (model =3D=3D MEMMODEL_RELEASE) > return "fence\trw,w"; > + else > + gcc_unreachable (); > } > [(set (attr "length") (const_int 4))]) > > -- > 2.34.1 >