From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [IPv6:2a00:1450:4864:20::62c]) by sourceware.org (Postfix) with ESMTPS id 36E463856DC8 for ; Wed, 12 Oct 2022 03:40:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 36E463856DC8 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ej1-x62c.google.com with SMTP id nb11so35389486ejc.5 for ; Tue, 11 Oct 2022 20:40:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=XvIGbqEU1d0d+rtVDolUzgWkjVk39T09y90QI/QEcdY=; b=KWqtX74wXlz6nLbuY3yx7B4+QRzFZi3y3rQ5nmP/7F+5ZyInjyshNoYYZzXoVukTyL BE+eUsV++BddqfC9vYCvgMc4jRwyjt7rmqYWUnpraymABvXmw58K5li80IszTkDBAEMU FtQ9uF+5FNDYcodXFMGe71t1dwvPCTg/ItYEi/4Y5uzG3LyNfCJpZ566Bt9n+oHc4fWt 7D8Xdq/U77Vt34zI1Zjc9ZZTDg3DgkR5vvlZvB4qe6aEf3s7uomNyhPmu1o5nibJ1usx Kri94T165/U2g3+1jTa8nnpaFQ6p3YMp287rgZbGaE7YwUGyOYktRINJOOnA1RMx0vcP Bphg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=XvIGbqEU1d0d+rtVDolUzgWkjVk39T09y90QI/QEcdY=; b=VGdhoCj2UCbXo0OEa48xiJd/dJd6IzDCaAIsRfGlI2lzTYaGFvoecvN8Z/RZv17Va0 wsE8TTZyNg/spmv5eS/Qt02oKnK4qh5uIySa25jY1klmVE/gfmvEGfFpkYlNbMc2b8+1 CkrjJLugYlGXPT/WOzSARtR5HOtF/GIhFO706ItHXzEhXXWzHu0Oue28R4WIIfgALvZj sOaae2GjTO/A6UMZvVxUZr9bVbwTkYsANierPzfSlZEtlMkzMuk3Um8pu0ycrUsHHBZ8 0wwjjUdfc6cit1GX2affaKhFsUaTIOTBS0EgknFc9NtiUXs1b+m9YoAStq7bnkEoqCo2 LOEw== X-Gm-Message-State: ACrzQf1L6BfvtG0F4OvO/QELeyKAgDZh4WF6Kxw+2f5l7pzBCUkDkIyK Ft4bY4AJ95zMtWomUtWWuQlbtWNYi5yeoXWvvAE= X-Google-Smtp-Source: AMsMyM4yknm7DYphsWUae3CxgKxUl2nH23II4W7uR7Jf3stWvaqJmoA6gXaulc6MKAmnRknVyPt6gLHMxtEOK+hdwwM= X-Received: by 2002:a17:907:6e93:b0:78d:dff1:71e3 with SMTP id sh19-20020a1709076e9300b0078ddff171e3mr4253690ejc.94.1665546006757; Tue, 11 Oct 2022 20:40:06 -0700 (PDT) MIME-Version: 1.0 References: <20221011063156.115984-1-juzhe.zhong@rivai.ai> In-Reply-To: <20221011063156.115984-1-juzhe.zhong@rivai.ai> From: Kito Cheng Date: Wed, 12 Oct 2022 11:39:54 +0800 Message-ID: Subject: Re: [PATCH] RISC-V: Refine riscv-vector-builtins.o include files and makefile. To: juzhe.zhong@rivai.ai Cc: gcc-patches@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-8.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: I would suggest we do not include those header files unless we really need that. On Tue, Oct 11, 2022 at 2:32 PM wrote: > > From: Ju-Zhe Zhong > > gcc/ChangeLog: > > * config/riscv/riscv-vector-builtins.cc: Change include files same as ARM SVE. > * config/riscv/t-riscv: Refine makefile. > > --- > gcc/config/riscv/riscv-vector-builtins.cc | 9 +++++++-- > gcc/config/riscv/t-riscv | 14 ++++++++------ > 2 files changed, 15 insertions(+), 8 deletions(-) > > diff --git a/gcc/config/riscv/riscv-vector-builtins.cc b/gcc/config/riscv/riscv-vector-builtins.cc > index 4814b6ef6e7..61f5f9802cf 100644 > --- a/gcc/config/riscv/riscv-vector-builtins.cc > +++ b/gcc/config/riscv/riscv-vector-builtins.cc > @@ -33,17 +33,22 @@ > #include "recog.h" > #include "diagnostic.h" > #include "expr.h" > +#include "basic-block.h" > #include "function.h" > #include "fold-const.h" > +#include "gimple.h" > +#include "gimple-iterator.h" > #include "gimplify.h" > #include "explow.h" > +#include "emit-rtl.h" > +#include "tree-vector-builder.h" > #include "stor-layout.h" > +#include "regs.h" > #include "alias.h" > +#include "gimple-fold.h" > #include "langhooks.h" > #include "stringpool.h" > #include "attribs.h" > -#include "targhooks.h" > -#include "regs.h" > #include "riscv-vector-builtins.h" > > using namespace riscv_vector; > diff --git a/gcc/config/riscv/t-riscv b/gcc/config/riscv/t-riscv > index 2f060437c23..82010721348 100644 > --- a/gcc/config/riscv/t-riscv > +++ b/gcc/config/riscv/t-riscv > @@ -6,12 +6,14 @@ riscv-builtins.o: $(srcdir)/config/riscv/riscv-builtins.cc $(CONFIG_H) \ > $(srcdir)/config/riscv/riscv-builtins.cc > > riscv-vector-builtins.o: $(srcdir)/config/riscv/riscv-vector-builtins.cc \ > - $(CONFIG_H) $(SYSTEM_H) coretypes.h $(TM_H) $(TREE_H) $(RTL_H) $(TM_P_H) \ > - memmodel.h insn-codes.h $(OPTABS_H) $(RECOG_H) $(DIAGNOSTIC_H) $(EXPR_H) \ > - $(FUNCTION_H) fold-const.h gimplify.h explow.h stor-layout.h $(REGS_H) \ > - alias.h langhooks.h attribs.h stringpool.h \ > - $(srcdir)/config/riscv/riscv-vector-builtins.h \ > - $(srcdir)/config/riscv/riscv-vector-builtins.def > + $(srcdir)/config/riscv/riscv-vector-builtins.def \ > + $(CONFIG_H) $(SYSTEM_H) coretypes.h $(TM_H) $(TREE_H) $(RTL_H) \ > + $(TM_P_H) memmodel.h insn-codes.h $(OPTABS_H) $(RECOG_H) $(DIAGNOSTIC_H) \ > + $(EXPR_H) $(BASIC_BLOCK_H) $(FUNCTION_H) fold-const.h $(GIMPLE_H) \ > + gimple-iterator.h gimplify.h explow.h $(EMIT_RTL_H) tree-vector-builder.h \ > + stor-layout.h $(REG_H) alias.h gimple-fold.h langhooks.h \ > + stringpool.h \ > + $(srcdir)/config/riscv/riscv-vector-builtins.h > $(COMPILER) -c $(ALL_COMPILERFLAGS) $(ALL_CPPFLAGS) $(INCLUDES) \ > $(srcdir)/config/riscv/riscv-vector-builtins.cc > > -- > 2.36.1 >