From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vs1-xe2d.google.com (mail-vs1-xe2d.google.com [IPv6:2607:f8b0:4864:20::e2d]) by sourceware.org (Postfix) with ESMTPS id B44333858C1F for ; Tue, 5 Sep 2023 12:14:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B44333858C1F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-vs1-xe2d.google.com with SMTP id ada2fe7eead31-44ee1123667so2037485137.0 for ; Tue, 05 Sep 2023 05:14:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693916066; x=1694520866; darn=gcc.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=83D7w0Xvr0jpxlL/TfbqXHgTZRcuh/ON4O9HeO9xcbY=; b=X1S6X3qrcpWaW4jW5oS26Fw7+7TdPXcZhZjb7cgqpIo3+BoNISbGdH6JkQG/eiMF6Q jSirUtwsIlxZtyswO7XU8tNFvdnUtR6OnazoqU7HfHX4lvPAkrnTwCTzivDNhrnQubKU WHBJHzI/b90KCbzWiJ1XfokE7xnlEePcqIoclH2Lp98iL0epycEvxeoyKjwuzcMnMPIa fwKZEwKGpBGWXY442T9tvAjo3x1KIn90oA2df68F8O1XT5/cS+N9PscOBokyltOBGL/Y /NUsLHVAVhhMbLsr7KnF0Y+gOoqMiftN1nOG+wFUz3z0eyJT3azSKfzpM2F97EqONzqy qiXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693916066; x=1694520866; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=83D7w0Xvr0jpxlL/TfbqXHgTZRcuh/ON4O9HeO9xcbY=; b=BaeIS1zSku6UTkV2x9/FW302KODwVEYeoig/GHIZVUM75oS2jSnqg30TQMz2z1MHJV 9EAqSNQrIqURwo/DBdVaLHXJMDOb8iWjOP2caDzV2gMoGzwiDRKCKCt4GKznzikfUdoa gKrSpewjMU7w0YJPHk7paaASEKXk7g7XOQzNHTmJf1PA4a3qk1MpmeWEk5o5llqzHP4K jgTbbARx2d0+FDK2k7pGSXuwOVd1apH79ma3dYsK986+Yvu+SxuXc3qHarq7+PoUb7JI 7XJ1wKR3cMfcEEJnGPN6A9jho7hmq2T+3t9TKXKT5Jt+yNZi+eZITLfWySsqOSlJS+60 K6Sw== X-Gm-Message-State: AOJu0YxQB3kNc4puqNXmT56RM/Caqq6rt6dcIWT3amhRrbWxHiaFSdhg fQ+snEvPW80rqLYo6vJMXVW5UD88nZgTYubrZQY= X-Google-Smtp-Source: AGHT+IGz8wY6ZwotydRe/cpFDg0ZNa/bSP2g/qjCs3Gkmge1B6ybNs2aZ3eADl2pjRCxS76zeXV0vQMe4qPuXy444Xs= X-Received: by 2002:a05:6102:2455:b0:44e:e770:b853 with SMTP id g21-20020a056102245500b0044ee770b853mr8004930vss.4.1693916065844; Tue, 05 Sep 2023 05:14:25 -0700 (PDT) MIME-Version: 1.0 References: <20230831090547.71737-1-kito.cheng@sifive.com> In-Reply-To: From: Kito Cheng Date: Tue, 5 Sep 2023 20:14:14 +0800 Message-ID: Subject: Re: [PATCH] RISC-V: Emit .note.GNU-stack for non-linux target as well To: Jeff Law Cc: Kito Cheng , gcc-patches@gcc.gnu.org, palmer@dabbelt.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: committed, thanks :) On Tue, Sep 5, 2023 at 3:18=E2=80=AFPM Jeff Law via Gcc-patches wrote: > > > > On 8/31/23 03:05, Kito Cheng wrote: > > We only emit that on linux target before, that not problem before, > > however Qemu has fix a bug to make qemu user mode honor PT_GNU_STACK[1]= , > > that will cause problem when we test baremetal with qemu. > > > > So the straightforward is enable that as well for non-linux toolchian, > > the price is that will increase few bytes for each binary. > > > > [1] https://github.com/qemu/qemu/commit/872f3d046f2381e3f416519e82df96b= d60818311 > > > > gcc/ChangeLog: > > > > * config/riscv/linux.h (TARGET_ASM_FILE_END): Move ... > > * config/riscv/riscv.cc (TARGET_ASM_FILE_END): to here. > OK. > jeff