From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vs1-xe29.google.com (mail-vs1-xe29.google.com [IPv6:2607:f8b0:4864:20::e29]) by sourceware.org (Postfix) with ESMTPS id CE8D53858CD1 for ; Mon, 31 Jul 2023 13:47:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CE8D53858CD1 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-vs1-xe29.google.com with SMTP id ada2fe7eead31-44758646388so1453837137.1 for ; Mon, 31 Jul 2023 06:47:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1690811228; x=1691416028; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=jtbYcvCUHtBL3nuPrpgVg2Acj86KqgN1F0Fe3fq47TU=; b=SZxHQQ7hUKEiCR1VXdGhyC53CrLqH6IgSB9mOUmsV5cFvtPNNmo1tPSVwY5rA7DDXC VF4d1COh2BYE6tIDQjntYrNsFBQzVslA+sOYa2YD1TW0HT0FQxN8+9yRaurI1NMSPiIN 3/827xbJXBPkLjmvsnVYP5xkdaOWOND//ZZPAM/NLargcAp4JtAj/kU0Yf9TqQYZI7vt PBwE0NS7r69PfKLIzx2Faj2xNdMYgIZGgUdq6P3ERdjAQguq+VlPlQidYIZvedzrAkjb crcabRoxyXs73g+3wE2LXZiaUwAXimmU40a/EkhF4pW1OHvbkZ9PpjLiMeuj46St2c9I Pt2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690811228; x=1691416028; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jtbYcvCUHtBL3nuPrpgVg2Acj86KqgN1F0Fe3fq47TU=; b=FmDeFyXplANBhiY5xHksvTpT03i1CsDwiEe3rYjvSsGPmS8I5RjoiX6EkbmOtCBEw1 tZS4lpg0KBcY5iknBymEewIy7oQ9aL+5aFYT5mM0pUTQfRdjwvwOi4uBdWHw9/nWzjSl xunMuxQDWOOV/v/XIpuHDooy8Ohbt8NPmolxNGZciy1zsWDdrozqaJSaH+YBj3L27cvV jFLMMyI99whXy4YQXOLI4iqNfrYeuq0wHfvZ2eP82C4f2BT2/M6tnHQe4w4Tm/G8EJEQ d4U16xSJ+dh2LwrQFnD4eCkXzkLudYbcYv/zHCKyymqTBJ4CkY+HguMta+Y6np2JU/4+ BoIg== X-Gm-Message-State: ABy/qLaUbqQOwVyA3LpJ/juY+gqQ7FRHk8fpzVtF33cZRj9U2/+L4zOH okZKsQjg3a4SzBhVE6kYmbV351edKlbkJNZtTb0= X-Google-Smtp-Source: APBJJlHN0U/cMktLD5IUS5z7ZKRWZripEPmatPJsSoeTUxzMRVd6GMDqFDQm4crGSfPj/Qfs7eFxVoIQ/HgIWtb3T+0= X-Received: by 2002:a67:cfc5:0:b0:445:5005:d7ab with SMTP id h5-20020a67cfc5000000b004455005d7abmr9769vsm.18.1690811227803; Mon, 31 Jul 2023 06:47:07 -0700 (PDT) MIME-Version: 1.0 References: <20230731065228.69779-1-kito.cheng@sifive.com> In-Reply-To: From: Kito Cheng Date: Mon, 31 Jul 2023 21:46:56 +0800 Message-ID: Subject: Re: [PATCH] RISC-V: Return machine_mode rather than opt_machine_mode for get_mask_mode, NFC To: "Maciej W. Rozycki" Cc: juzhe.zhong@rivai.ai, "Kito.cheng" , gcc-patches , Robin Dapp , "pan2.li" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Maciej: Sorry for disturbing, pushed a fix for that, and...added -Werror=3Dunused-variable to my build script to prevent that happen again :( On Mon, Jul 31, 2023 at 7:08=E2=80=AFPM Maciej W. Rozycki wrote: > > On Mon, 31 Jul 2023, Kito Cheng via Gcc-patches wrote: > > > Pushed, thanks :) > > This breaks compilation: > > .../gcc/config/riscv/riscv-v.cc: In function 'void riscv_vector::expand_v= ec_series(rtx, rtx, rtx)': > .../gcc/config/riscv/riscv-v.cc:1251:16: error: unused variable 'mask_mod= e' [-Werror=3Dunused-variable] > 1251 | machine_mode mask_mode =3D get_mask_mode (mode); > | ^~~~~~~~~ > .../gcc/config/riscv/riscv-v.cc: In function 'void riscv_vector::expand_v= ector_init_insert_elems(rtx, const riscv_vector::rvv_builder&, int)': > .../gcc/config/riscv/riscv-v.cc:2320:16: error: unused variable 'mask_mod= e' [-Werror=3Dunused-variable] > 2320 | machine_mode mask_mode =3D get_mask_mode (mode); > | ^~~~~~~~~ > > Please always at the very least build changes and verify that they cause > no new issues before submitting patches. > > Maciej