public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Kito Cheng <kito.cheng@gmail.com>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: Kito Cheng <kito.cheng@sifive.com>,
	GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH 2/2] RISC-V: Implement TARGET_COMPUTE_MULTILIB
Date: Fri, 9 Sep 2022 17:58:06 +0800	[thread overview]
Message-ID: <CA+yXCZAFkcNJZsUBe1vojHuZiYB-=J-SXqH2R+00owbX8N-RMQ@mail.gmail.com> (raw)
In-Reply-To: <87r10l57zf.fsf@linux-m68k.org>

Hi Andreas:

Hmmmmm, I should change my default gcc on Ubuntu, I didn't got this
when build with GCC 7, and can be reproduced by GCC 11,

Will summit patch once I test done.

On Fri, Sep 9, 2022 at 3:21 PM Andreas Schwab <schwab@linux-m68k.org> wrote:
>
> How did you test that?
>
> ../../gcc/common/config/riscv/riscv-common.cc: In function 'const char* riscv_multi_lib_check(int, const char**)':
> ../../gcc/common/config/riscv/riscv-common.cc:1451:11: error: bare apostrophe ''' in format [-Werror=format-diag]
>  1451 |       "Can't find suitable multilib set for %<-march=%s%>/%<-mabi=%s%>",
>       |           ^
> ../../gcc/common/config/riscv/riscv-common.cc:1451:7: note: if avoiding the apostrophe is not feasible, enclose it in a pair of '%<' and '%>' directives instead
>  1451 |       "Can't find suitable multilib set for %<-march=%s%>/%<-mabi=%s%>",
>       |       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ../../gcc/common/config/riscv/riscv-common.cc: At global scope:
> ../../gcc/common/config/riscv/riscv-common.cc:1492:1: error: 'int riscv_check_conds(const switchstr*, int, int, const std::vector<std::__cxx11::basic_string<char> >&)' defined but not used [-Werror=unused-function]
>  1492 | riscv_check_conds (
>       | ^~~~~~~~~~~~~~~~~
> ../../gcc/common/config/riscv/riscv-common.cc:1374:1: error: 'const char* find_last_appear_switch(const switchstr*, int, const char*)' defined but not used [-Werror=unused-function]
>  1374 | find_last_appear_switch (
>       | ^~~~~~~~~~~~~~~~~~~~~~~
> cc1plus: all warnings being treated as errors
> make[3]: *** [Makefile:2442: riscv-common.o] Error 1
>
> --
> Andreas Schwab, schwab@linux-m68k.org
> GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
> "And now for something completely different."

  reply	other threads:[~2022-09-09  9:58 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-21  9:28 [PATCH 0/2] New target hook TARGET_COMPUTE_MULTILIB and implementation for RISC-V Kito Cheng
2021-07-21  9:28 ` [PATCH 1/2] Add TARGET_COMPUTE_MULTILIB hook to override multi-lib result Kito Cheng
2021-09-01  0:16   ` Jim Wilson
2021-07-21  9:28 ` [PATCH 2/2] RISC-V: Implement TARGET_COMPUTE_MULTILIB Kito Cheng
2021-09-01  0:22   ` Jim Wilson
2021-09-01  0:23     ` Jim Wilson
2021-09-16  4:12     ` Kito Cheng
2022-09-09  7:20   ` Andreas Schwab
2022-09-09  9:58     ` Kito Cheng [this message]
2021-07-29 18:44 ` [PATCH 0/2] New target hook TARGET_COMPUTE_MULTILIB and implementation for RISC-V Kito Cheng
2021-07-29 19:00   ` Palmer Dabbelt
2022-09-02  9:28     ` Kito Cheng
  -- strict thread matches above, loose matches on Subject: below --
2020-12-01  9:29 [PATCH 1/2] Add TARGET_COMPUTE_MULTILIB hook to override multi-lib result Kito Cheng
2020-12-01  9:29 ` [PATCH 2/2] RISC-V: Implement TARGET_COMPUTE_MULTILIB Kito Cheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CA+yXCZAFkcNJZsUBe1vojHuZiYB-=J-SXqH2R+00owbX8N-RMQ@mail.gmail.com' \
    --to=kito.cheng@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=kito.cheng@sifive.com \
    --cc=schwab@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).