From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vs1-xe2c.google.com (mail-vs1-xe2c.google.com [IPv6:2607:f8b0:4864:20::e2c]) by sourceware.org (Postfix) with ESMTPS id 444503858C54 for ; Wed, 24 May 2023 08:07:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 444503858C54 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-vs1-xe2c.google.com with SMTP id ada2fe7eead31-4396800545aso405798137.1 for ; Wed, 24 May 2023 01:07:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684915661; x=1687507661; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=3v1osCKtSPEf9qoC0PtAvfwKTijj0K0/DvGcbTmus9M=; b=iYFks/QrepP/avIsVzXvbKNYVycrpx491ta+8f4EUGurayD9zG37ctyFGWvJ6zK5vT SrdGpNrhvD0fY3GhCflveWUpvyW0oahrNpmutkF4YgsSv6iAYvWzvxKHV3Se+93H8KtK B4TUtzWkMVEMzEPUxxw9F4jfrcoQ39Iz2MU+GHXF99qF6VuwXAxsvPib35qx+wyD1UtZ lCTuYGz5K1iMVCiHUOw80WxhK+42seSx+Sc7IvPoqHUJqk5vdzoClcebj9N7O0oxCOEA ACVSZSygaWLxRKLgIwuiDD6dixqrZlo6tzOfJ55tvg3aZ5xyA+GWyGhvLFLKW1y2kavw yDCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684915661; x=1687507661; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3v1osCKtSPEf9qoC0PtAvfwKTijj0K0/DvGcbTmus9M=; b=DCBvyiMPcGVdYxjmOm2lSgLb3BJmOhttVejpDIzOpvHYRS2ehOPYccZlAhE3SO388O L7CF34f18aXmzbeSd+8nRWgu9mzHy6ZAy/xgARTSOxbLegv83oZ9KDp9XI7qA0dB02zL +93c7pq8kaqGTS1ZjTdrVXGiX2j4IbkCzCuX3W/CJbA7SGCrBxBoAHdSaLklEoF+daqK cqwXH5xVT5p7qOwFxjAivAbLK4tsetFMB6XuUyAae+ucYe18VLYga978GD2yOHiy81S/ 5G0Abo3Er6Ym+rJTZkY1wFI0WJTzIQZvpsXiZfFy23fMX+Hi9X9UIzwuIxspQmbYyMKi rhwA== X-Gm-Message-State: AC+VfDxwo9l7GvT5gRTW1f0kwNZihsEpzo10KVD/GIK65eVFVhjWqU4a KSUn0uTlIpCUJpCySQTrz8ce+fmOIVIVTs8iOck= X-Google-Smtp-Source: ACHHUZ7dFAh60XTxfWIZhgVdJXX4IDhlxI0tXobSLvjaVGgQpjfMGDLilZyz6uTh/K5gaW01DtnsHUtQmYBgFoN/OhA= X-Received: by 2002:a67:db90:0:b0:437:e783:f127 with SMTP id f16-20020a67db90000000b00437e783f127mr4658780vsk.14.1684915661448; Wed, 24 May 2023 01:07:41 -0700 (PDT) MIME-Version: 1.0 References: <20230524072723.1387346-1-juzhe.zhong@rivai.ai> <4AB19BCB8E0F354C+20230524154150475921208@rivai.ai> In-Reply-To: <4AB19BCB8E0F354C+20230524154150475921208@rivai.ai> From: Kito Cheng Date: Wed, 24 May 2023 16:07:30 +0800 Message-ID: Subject: Re: Re: [V2 COMMITTED] RISC-V: Add RVV mask logic auto-vectorization To: "juzhe.zhong@rivai.ai" Cc: gcc-patches , "Kito.cheng" , palmer , palmer , jeffreyalaw , Robin Dapp , "pan2.li" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Oh, never mind, I mean you updated to use define_insn_and_split but comment still define_insn_and_split, but just ignore that if already committed On Wed, May 24, 2023 at 3:42=E2=80=AFPM juzhe.zhong@rivai.ai wrote: > > > > > From: Juzhe-Zhong > > > > This patch is adding mask logic auto-vectorization. > > define the pattern as "define_insn_and_split" to allow > > >don't forgot to update here ^^^^^ > > I notice I missed changeLog here. Is that you want me to fix in the > commit log? > > > > > juzhe.zhong@rivai.ai > > From: Kito Cheng > Date: 2023-05-24 15:31 > To: juzhe.zhong > CC: gcc-patches; kito.cheng; palmer; palmer; jeffreyalaw; rdapp.gcc; pan2= .li > Subject: Re: [V2 COMMITTED] RISC-V: Add RVV mask logic auto-vectorization > LGTM, just one comment in git comment, no need v3, just commit with > the fix is fine :) > > On Wed, May 24, 2023 at 3:28=E2=80=AFPM wrote: > > > > From: Juzhe-Zhong > > > > This patch is adding mask logic auto-vectorization. > > define the pattern as "define_insn_and_split" to allow > > don't forgot to update here ^^^^^ > > > combine PASS easily combine series instructions. > > > > For example: > > combine vmxor.mm + vmnot.m into vmxnor.mm > > > > Build success and regression PASS > > > > And committed. >