From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ua1-x92b.google.com (mail-ua1-x92b.google.com [IPv6:2607:f8b0:4864:20::92b]) by sourceware.org (Postfix) with ESMTPS id B5B933858D1E for ; Tue, 18 Apr 2023 14:26:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B5B933858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ua1-x92b.google.com with SMTP id o2so19808527uao.11 for ; Tue, 18 Apr 2023 07:26:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681828005; x=1684420005; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=SFbO1jZ5MtmUeT8MUUQN6mOnhIv9dc+8doS29q48OfA=; b=loBtN2VlM8KHhrdQgOzbCPVmQzx5fX8WfUSUWC5FrCPCyFJZzMEKVOqf17vbnzPkAt uokzcS3verRScYUBd1Iu7IsQrc613yom0GOoSD+RfXha5LQQh9PwCnh+vGDeyaJk7+r2 1mK7ap5li4QMCNzbIxrzo2BlR/9IIfSSR/bW6CSi9j6PVMZ4aJwFvACLsYYZIbJmgKFx wlYmQP0OpyWAEVYRDyRg5nxVn+cuKp+64dm20xs7TZgUlJN7yMcVBDgblnYSnUEWcA1v cHQinIFIHfvgtZV7nctq1AC++zuI63VJOYT8V5pgtbgQR9vJ3EFp2Cbv2Z4zxM+Cg6KG ptwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681828005; x=1684420005; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SFbO1jZ5MtmUeT8MUUQN6mOnhIv9dc+8doS29q48OfA=; b=J3hdX9dBFPgUJUWUnSxlQxLnZDfjlXf3BWpe2g5dRt0MYS1r//hw8Rc9P/T7btguti H/eAJrNt92RbVs8LevX+2OHlwHwN7cN7cmApGEN08w/qzjlcN9MkKMVNYuMpTBRLYJKG 1l16u4Foda09xOqWmdm1x+cwNPHsIeaVZeCAPKO529QmtACfInB+ZSbqOlDZXnirCHNb 5F0TAfBnffqFRRRRorx439BEvQ1dCc01RgFo+xfy53+BUZ5tsO3SDOaZOd0rBYfleims zbGmWBohx2q6FTZDIOzEYj8Wz3Na9pyXZyPl2QUwoaXVL4VE2iQ0zsHbav42k/tlzTm2 dOXQ== X-Gm-Message-State: AAQBX9eQ8XMvA2MEeYoZ870BetfYiQoFdOFtc5qTf05aslrvKFfWGCe+ ibKPQMZdXemumMctrSINhRRb5PwC3Bo5KUVFRmU= X-Google-Smtp-Source: AKy350bod7D5fsDBoCIpAaIxB+5lHz3adLWHG+n4F5bPwftTLCJUTH4WxuteQZCbR2+74LJ/1gsBdXA6L6OVBvOKdJE= X-Received: by 2002:a1f:3f48:0:b0:43f:b31b:f1d1 with SMTP id m69-20020a1f3f48000000b0043fb31bf1d1mr5219841vka.13.1681828004759; Tue, 18 Apr 2023 07:26:44 -0700 (PDT) MIME-Version: 1.0 References: <20230417183701.2249183-1-collison@rivosinc.com> <20230417183701.2249183-10-collison@rivosinc.com> In-Reply-To: <20230417183701.2249183-10-collison@rivosinc.com> From: Kito Cheng Date: Tue, 18 Apr 2023 22:26:33 +0800 Message-ID: Subject: Re: [PATCH v4 09/10] This patch adds a guard for VNx1 vectors that are present in ports like riscv. To: Michael Collison Cc: gcc-patches@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-8.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: I would prefer drop this patch from this patch series since I believe https://patchwork.ozlabs.org/project/gcc/patch/20230414014518.15458-1-juzhe= .zhong@rivai.ai/ is the right fix for this issue. On Tue, Apr 18, 2023 at 2:40=E2=80=AFAM Michael Collison wrote: > > From: Kevin Lee > > Kevin Lee > gcc/ChangeLog: > > * tree-vect-data-refs.cc (vect_grouped_store_supported): Add new > condition > --- > gcc/tree-vect-data-refs.cc | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/gcc/tree-vect-data-refs.cc b/gcc/tree-vect-data-refs.cc > index 8daf7bd7dd3..df393ba723d 100644 > --- a/gcc/tree-vect-data-refs.cc > +++ b/gcc/tree-vect-data-refs.cc > @@ -5399,6 +5399,8 @@ vect_grouped_store_supported (tree vectype, unsigne= d HOST_WIDE_INT count) > poly_uint64 nelt =3D GET_MODE_NUNITS (mode); > > /* The encoding has 2 interleaved stepped patterns. */ > + if(!multiple_p (nelt, 2)) > + return false; > vec_perm_builder sel (nelt, 2, 3); > sel.quick_grow (6); > for (i =3D 0; i < 3; i++) > -- > 2.34.1 >