From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-x729.google.com (mail-qk1-x729.google.com [IPv6:2607:f8b0:4864:20::729]) by sourceware.org (Postfix) with ESMTPS id 8EBFC3858D28 for ; Sun, 23 Jul 2023 03:35:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8EBFC3858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-qk1-x729.google.com with SMTP id af79cd13be357-7679ea01e16so301340585a.2 for ; Sat, 22 Jul 2023 20:35:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1690083342; x=1690688142; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=zwy6uWNmWZPqF+sjXWfxFD7isXDoR5Yxlqy3pLA03OI=; b=UWee/NlN8rZCO7A2z8GSZ8c0iy8s12wGURgrBwmLtFjXIA8Mq+6HYABN505o67dzG1 KjTgk5owMSzLj1zg8HpHXjNNuRdlk+8GmVS5HlgCOT7qEWob3zGT+qRFtx4Ky32CkJn1 nsTd0o2Fx2pwyKca3HnuP6dnXTwp9M5bfgKzqBvykn+wjRcixm51LeqRUmoGRHfcwpEe kLmSYEPY/T/NQciwZtQZue8qtjaXQ3rLuHjqaSnCrzcRCV8L+E8Z7PQG9Y2V2anqs1Vy slGXkYXcxGwDAnuNn40s8lnCqaOfCIUyn0pKSM32nxxMYeNqg0+vdI2B0xIcbbKGBvSe 4Uaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690083342; x=1690688142; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=zwy6uWNmWZPqF+sjXWfxFD7isXDoR5Yxlqy3pLA03OI=; b=bagkY93Q9RyN41jtUTlgODJzddrCxSVz7sAl9EzyMx62Hk4p4t5ERCjmueeOZu8rHU 5HivGB+b65r8pR4WpuRbGJumYHq9BVBSrmAUTWRco4EYFZtCl43X1jjwowQ/Bhrj7YKS +U9ozrtrAcv34PNZqfnkMcdNPRKm79DoLnHIXY33Z8OgCAKdnOVHN9yXYxVd6wFOfkUx Xzj4iemhnW6Ofx9epO73T9cT2qhO9EUBxcxttdK+/a19MFanPokzEcfjP3cEr4h11Q+O +HAx4t6Qk1obnhSfSxVgP8CBZaB8G3zW2aB7EFKlVkA4s2IhBHpYxkBanxL07dDIfug3 j6aA== X-Gm-Message-State: ABy/qLZyw5GyS6pS/BGdmiTFa5R9bZlHtXB3gKSsjD845jsVTnhHB4jf NJc3+JI2FqdqTJ2IREEcaNDlioG4fdRekZOdCdA= X-Google-Smtp-Source: APBJJlEc1IRBepGBw2XPyoCtnSyBlj9GOb4ZrRmU5tbS0Yn5F65CInSDAFQiS3pQ3Iw8S6UJA+5FVL1N6ZdYvvOCweE= X-Received: by 2002:a05:620a:1536:b0:767:b348:5a9 with SMTP id n22-20020a05620a153600b00767b34805a9mr4519088qkk.21.1690083341948; Sat, 22 Jul 2023 20:35:41 -0700 (PDT) MIME-Version: 1.0 References: <20230723010645.1622083-1-apinski@marvell.com> In-Reply-To: <20230723010645.1622083-1-apinski@marvell.com> From: Kito Cheng Date: Sun, 23 Jul 2023 11:35:29 +0800 Message-ID: Subject: Re: [PATCH 1/2] Fix PR 110066: crash with -pg -static on riscv To: Andrew Pinski Cc: GCC Patches Content-Type: multipart/alternative; boundary="0000000000003cdc8406011f31e3" X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --0000000000003cdc8406011f31e3 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable OK for trunk, thanks:) Andrew Pinski via Gcc-patches =E6=96=BC 2023=E5= =B9=B47=E6=9C=8823=E6=97=A5 =E9=80=B1=E6=97=A5 09:07 =E5=AF=AB=E9=81=93=EF=BC=9A > The problem -fasynchronous-unwind-tables is on by default for riscv linux > We need turn it off for crt*.o because it would make __EH_FRAME_BEGIN__ > point > to .eh_frame data from crtbeginT.o instead of the user-defined object > during static linking. > > This turns it off. > > OK? > > libgcc/ChangeLog: > > * config.host (riscv*-*-linux*): Add t-crtstuff to tmake_file. > (riscv*-*-freebsd*): Likewise. > * config/riscv/t-crtstuff: New file. > --- > libgcc/config.host | 4 ++-- > libgcc/config/riscv/t-crtstuff | 5 +++++ > 2 files changed, 7 insertions(+), 2 deletions(-) > create mode 100644 libgcc/config/riscv/t-crtstuff > > diff --git a/libgcc/config.host b/libgcc/config.host > index 9d7212028d0..c94d69d84b7 100644 > --- a/libgcc/config.host > +++ b/libgcc/config.host > @@ -1304,12 +1304,12 @@ pru-*-*) > tm_file=3D"$tm_file pru/pru-abi.h" > ;; > riscv*-*-linux*) > - tmake_file=3D"${tmake_file} riscv/t-softfp${host_address} t-softfp > riscv/t-elf riscv/t-elf${host_address} t-slibgcc-libgcc" > + tmake_file=3D"${tmake_file} riscv/t-crtstuff > riscv/t-softfp${host_address} t-softfp riscv/t-elf > riscv/t-elf${host_address} t-slibgcc-libgcc" > extra_parts=3D"$extra_parts crtbegin.o crtend.o crti.o crtn.o > crtendS.o crtbeginT.o" > md_unwind_header=3Driscv/linux-unwind.h > ;; > riscv*-*-freebsd*) > - tmake_file=3D"${tmake_file} riscv/t-softfp${host_address} t-softfp > riscv/t-elf riscv/t-elf${host_address} t-slibgcc-libgcc" > + tmake_file=3D"${tmake_file} riscv/t-crtstuff > riscv/t-softfp${host_address} t-softfp riscv/t-elf > riscv/t-elf${host_address} t-slibgcc-libgcc" > extra_parts=3D"$extra_parts crtbegin.o crtend.o crti.o crtn.o > crtendS.o crtbeginT.o" > ;; > riscv*-*-*) > diff --git a/libgcc/config/riscv/t-crtstuff > b/libgcc/config/riscv/t-crtstuff > new file mode 100644 > index 00000000000..685d11b3e66 > --- /dev/null > +++ b/libgcc/config/riscv/t-crtstuff > @@ -0,0 +1,5 @@ > +# -fasynchronous-unwind-tables -funwind-tables is on by default for riscv > linux > +# We turn it off for crt*.o because it would make __EH_FRAME_BEGIN__ poi= nt > +# to .eh_frame data from crtbeginT.o instead of the user-defined object > +# during static linking. > +CRTSTUFF_T_CFLAGS +=3D -fno-asynchronous-unwind-tables -fno-unwind-tables > -- > 2.39.1 > > --0000000000003cdc8406011f31e3--