From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vs1-xe2a.google.com (mail-vs1-xe2a.google.com [IPv6:2607:f8b0:4864:20::e2a]) by sourceware.org (Postfix) with ESMTPS id 3CB403858D20 for ; Fri, 27 Jan 2023 09:41:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3CB403858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-vs1-xe2a.google.com with SMTP id d66so4702158vsd.9 for ; Fri, 27 Jan 2023 01:41:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=FmxkFIf1QswtB6Bec5QKepxgMBdOdCtbN7AEDo5cxMc=; b=U7RPV2qsio2IE77SOReuFbtjLSP8fgOf7b3cg0eMin84of/4roF+VAt2l5IIrRptUd lAZmKj0wzS62zc1gUTAs8fVttfh4tBe/RYpzuKd11baImouBjtBC4Ia6gx6jK68TW1Fa aUmeCyGDXb2Arq0fD4z/tfjs4Oldnp+idwWDssU1gOv39EAoDL672C5moXRnIWc72e1u 1G+MinfXuMsjnmiuL8K+3r+LZiSKKC8MEew0Qv0uSj3YvHZZvvOBHIv1rjmPmG36itMn 1Ebrj+OkZp5nuLVXWPDz9v35z4QOQKqdPieo9b5I7Vmt2fV/RzItQfUF1cL7mfb7vFay yGmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=FmxkFIf1QswtB6Bec5QKepxgMBdOdCtbN7AEDo5cxMc=; b=eA4Jip+EypU8LaIHixS8iTqcI/sjVieLSG6e+Jx6zOf9Pa/EVaQ3XnBYfgaiPbnCXq d7CC7yi/y24tpZRj0oWoJt0WdKJCuNh2P0nX26XMhnsIgBsxjYqnTVpiyj0lpe2sT0Di oQdfXrrfcZntCZPgSrbpVe9yj8UZ8+ziNA6M2D2Ha1luYlO64/U6MleySBq0QU9VtCWB TqFhUnrDpVg4/XZgSI921XOVVpoxq38GC05S4lPaDpB5/35FXlp8kbnz0mNwMDZixvUK Pk/Odjw34N7rmL+DT9K2iByxGGHLbR10CmGkHHR7WuM9GvF38E31VDAhLrUtwMxiQSE1 zVew== X-Gm-Message-State: AFqh2krCNhgdMFQSOqTPq0NlKy9+Dpsuylv0fCrCt4gWW8HPkbVQFHDx hQ3q8+EEtAUYTVOFaVAQtiyO1I4o28JxZyYqkoM= X-Google-Smtp-Source: AMrXdXsh8VTaDDgo5U8P7jfeZPJ5eJQbWRTFMZSXw0OgXxG5pdEHjBOuQMTrnb3EBARecb3bVxWkWa6yzRmoWDn/Uic= X-Received: by 2002:a05:6102:d2:b0:3ce:fc17:8836 with SMTP id u18-20020a05610200d200b003cefc178836mr5006520vsp.71.1674812459495; Fri, 27 Jan 2023 01:40:59 -0800 (PST) MIME-Version: 1.0 References: <20230118030347.68061-1-juzhe.zhong@rivai.ai> In-Reply-To: From: Kito Cheng Date: Fri, 27 Jan 2023 17:40:48 +0800 Message-ID: Subject: Re: [PATCH] RISC-V: Reorder VSETVL PASS location To: Jeff Law Cc: juzhe.zhong@rivai.ai, gcc-patches@gcc.gnu.org, palmer@dabbelt.com Content-Type: multipart/alternative; boundary="000000000000b6b41005f33ba929" X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000b6b41005f33ba929 Content-Type: text/plain; charset="UTF-8" Added more comments and committed, thanks! On Mon, Jan 23, 2023 at 3:36 AM Jeff Law wrote: > > > On 1/17/23 20:03, juzhe.zhong@rivai.ai wrote: > > From: Ju-Zhe Zhong > > > > gcc/ChangeLog: > > > > * config/riscv/riscv-passes.def (INSERT_PASS_BEFORE): Reorder > VSETVL PASS. > It'd be useful to know the motivation here, I could easily see someone > in the future finding a case where the location of the vsetvl gets > influenced by some dead code that would have been removed by the DCE > pass. Then they're going to want to know the motivation behind the > current pass placement. > > So, OK after adding a comment describing why the pass is placed where it > is. > > Jeff > --000000000000b6b41005f33ba929--