From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ua1-x930.google.com (mail-ua1-x930.google.com [IPv6:2607:f8b0:4864:20::930]) by sourceware.org (Postfix) with ESMTPS id 270B73858D28 for ; Thu, 4 May 2023 08:33:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 270B73858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ua1-x930.google.com with SMTP id a1e0cc1a2514c-77d0522feaeso133846241.2 for ; Thu, 04 May 2023 01:33:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683189232; x=1685781232; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=kOmVvOGhL3+hadP9OM4oRLSd5hbSjVf892XaQfu1KJM=; b=CePmE5BEjUCsVz0vfDcZRhelsBND+tQznO9bL3fP0JUCIh3knUl7jGj7pXBqfWeVo+ LWdETlePA5xHZBauqG3ZJkseRgje4WD3cGX4hlVkNzKPXcz+iCJN6rngXjdFyTFghdM9 u8yniJxK/zhKaprpWU6baI8WCUSPkvrgg6KaTCXDfKoQ5sqsyJ0vXZjljTOoTvw8mYUD YRrS9E2Ch+PNt62loq9G8aEiHUXUfmDXjOo9k2jRsGK0u2hQXCapFrN8WMA33jr8FCQj 6V3jVWuyhH0AKLtl7qr3V/6FVn9MKPBVsajeBPBCq9XyiMDkfbm4PTHIpMWYTKCkC//L 2clw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683189232; x=1685781232; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=kOmVvOGhL3+hadP9OM4oRLSd5hbSjVf892XaQfu1KJM=; b=HFNmmsabCXvUKQbmGcoyASnW7OV8DhlgL9JM6r25/GWGQzXtKoYP+oqlyu8GZz5Jg8 IjzcWthsTNMowFhAsxOZ6p4dqKH3ZRj6ABixFsMQkxUAEQqY8//DVTTJcDLQe07pIIjk DoZ4qIj+gNAlbQtDdRKK3C0UgJbgngaquz7vWXtPAmSpsIz1qX+x3qttksVGdNe/ECny 5xyE3X6ghnb9riQKEWT37KnQGANqgOPJxmeYjvefcBre8dEpdpBsn+mTv1gw8zH9wWSh 0Hh/MPEeVr3RBILP2jxlxSmayIOwREioe4458LUmqoQT4ZjqAStPmysXCtmnSe3ET2cg 910w== X-Gm-Message-State: AC+VfDxv6YBVFGXaGfgd24yv1kvopDIZQARZJesbiGc/AqIr4N46Y3cm 3PshJ0+WANqVXbcdPv05Cf0cv/54FpthZXgz2rE= X-Google-Smtp-Source: ACHHUZ7F1MGyJZyMn9oyfCZlCgs5pgRhpi7GQEfh6hZ1LfkO1uiAk9wGAoOkGBat2PK4kPUhevPlh5rjb0KjsAR90UM= X-Received: by 2002:a05:6102:459:b0:434:6978:fdc6 with SMTP id e25-20020a056102045900b004346978fdc6mr854403vsq.11.1683189232507; Thu, 04 May 2023 01:33:52 -0700 (PDT) MIME-Version: 1.0 References: <20230406062118.47431-1-jiawei@iscas.ac.cn> <20230406062118.47431-2-jiawei@iscas.ac.cn> In-Reply-To: <20230406062118.47431-2-jiawei@iscas.ac.cn> From: Kito Cheng Date: Thu, 4 May 2023 16:33:41 +0800 Message-ID: Subject: Re: [PATCH 1/5] RISC-V: Minimal support for ZC extensions. To: Jiawei Cc: gcc-patches@gcc.gnu.org, kito.cheng@sifive.com, palmer@dabbelt.com, christoph.muellner@vrull.eu, jeremy.bennett@embecosm.com, mary.bennett@embecosm.com, nandni.jamnadas@embecosm.com, charlie.keaney@embecosm.com, simon.cook@embecosm.com, tariq.kurd@codasip.com, ibrahim.abu.kharmeh1@huawei.com, sinan.lin@linux.alibaba.com, wuwei2016@iscas.ac.cn, shihua@iscas.ac.cn, shiyulong@iscas.ac.cn, chenyixuan@iscas.ac.cn Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > @@ -1151,14 +1169,26 @@ riscv_subset_list::parse (const char *arch, location_t loc) > subset_list->handle_implied_ext (itr); > } > > + /* Zce only imply zcf when 'f' extension exist. */ Grammarly and gmail told me it should be "Zce only implies zcf when 'f' extension exist." :P > + if (subset_list->lookup ("zce") != NULL > + && subset_list->lookup ("f") != NULL > + && subset_list->lookup ("zcf") == NULL) Wait, add zce if f not implied here, but how about rv64if_zce? it will become rv64if_zce_zcf and then error later. > + subset_list->add ("zcf", false); > + > subset_list->handle_combine_ext (); > > + if (subset_list->lookup ("zcf") && subset_list->m_xlen == 64) > + error_at (loc, "%<-march=%s%>: zcf extension supports in rv32 only" > + , arch); > + > if (subset_list->lookup ("zfinx") && subset_list->lookup ("f")) > error_at (loc, "%<-march=%s%>: z*inx conflicts with floating-point " > "extensions", arch); > > return subset_list; > > + > + Plz drop these two extra blank lines.