From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x530.google.com (mail-ed1-x530.google.com [IPv6:2a00:1450:4864:20::530]) by sourceware.org (Postfix) with ESMTPS id 452CB3858C42 for ; Thu, 18 Jan 2024 08:27:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 452CB3858C42 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 452CB3858C42 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::530 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705566476; cv=none; b=akFVmg+8BO6ThJdEWFs+/oey3wjbrdVHBsjOHu4MESC9MIy1LPn2Agtecru3q8d6Q4ekyU4xVra9ybnr3VSwNs5nCGu9UcL7RVITAuMtQCpPbGlRcPfWZWvXC/sMupzYMM5ZlbD7blwQVw8NAdfXlVkOuwpHfzYeo9/pfQqA56Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705566476; c=relaxed/simple; bh=9VyxjFNUwI0BCahXGFWkw9xYzI9pmQwLjlpOcOZLODM=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=U7/iFaUV9imWT98nIddi6hvtpZt7SI0Z1+2TObIYlvok6pxx/dkcTM8qrogNoOI4+Dbu7aQlIppCSwXpfyh78PfqE+60vMXCgNf8gp5j6TssocEjUhNcxsMelZwaq2Tl15i5ElHEaT3HiqzxllVvLOIhIKyCRKOJOM1dqIOOcoM= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ed1-x530.google.com with SMTP id 4fb4d7f45d1cf-559d0ef3fb5so1884034a12.3 for ; Thu, 18 Jan 2024 00:27:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1705566470; x=1706171270; darn=gcc.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=dI/HAKQoISLoWbk2hWNJNANQgHtc/IpJVvb86VhG7Lk=; b=mO+yVNNgcS1fnV5tWhUmFoGKCGidnleI8EjFoIDguQw24y0oA1hDA5eGLTF1WkHuvn 7D0f95JxPGKqttR4SuMPnk87N81FUBgvUGtkXSUUciV9HhB8KidzwZVwPeUqXTVv2SSp SVlGmN2bHzX+d8495ipE3AxWLae0Mdh26wiJ2NJOZv+/j/E9BMHif8G/lUHDz4Y3i2Ks hj8ZpXbAR1V0RXVak9gCXZV17oZSJ5n+3mtUnSy+wO8wkJCe4M3xy5lsYNYk4/b0LFpC 5hdS4SsM29F1P6i+0hP8E0C+cRgRX5YeXcQuKo8p/EgZCb2rWNLxpgv4x757PEmi1Hwh vTPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705566470; x=1706171270; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dI/HAKQoISLoWbk2hWNJNANQgHtc/IpJVvb86VhG7Lk=; b=I2Lh0HFsqmNRZSF0Re9P8hNehMuWB49ogVEnNCGbeglTWLGNWkPAYaYEzG/fol10gg 9PwXv8biVvEJ7KliEiQHf0YA3QfPfXxJQDWiz/ALtz9gztZnlSFKJCNLxxX77EzeWyaK VPHBieb5TZAI1PGRM+EK+9MCpeKbA6QGVwd9dpty5W7HD4BJsCPd6tXJNBgIsQo6JGkk TZhMfgwyHUUDJ87R/HV3b/7/jTfo2IoLwj8v+Ub8ijhdesblvUevvpeg6PPa8h9mY9XD I5phUy8Aoo7mmJT4l1uHR/2HyjYrAusYAbtNW9RiJRft6K4JlTw3nCUkbWkzv/kj0lGK NUZg== X-Gm-Message-State: AOJu0YxerutFpKIbmaLhoGNjBJNZweVv4s95MEeMhFQpVtVcAGGy9nmh vcZbmt5M8yK2Y7rvyEAVGsCEfENkAaIbm4E5+JKnljWNJDfhQ0kHysN2/RJQmajm9XCMfoOR/6O rMZM3tn0HQP9lMXw5VWb+c7h1v8E= X-Google-Smtp-Source: AGHT+IGNrW3Ltwr4JOXW9929+qFJA1MwDgCngU4gGcKfjKPN2W9EJTM4XwGAJ4zvCrJYNiufh/yW8anrZ8ZSYpcMURc= X-Received: by 2002:a17:906:b52:b0:a27:c6b4:2aad with SMTP id v18-20020a1709060b5200b00a27c6b42aadmr287867ejg.135.1705566469667; Thu, 18 Jan 2024 00:27:49 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Kito Cheng Date: Thu, 18 Jan 2024 16:27:37 +0800 Message-ID: Subject: Re: [PATCH] riscv: Remove Bool keywords from riscv.opt To: Jakub Jelinek Cc: Palmer Dabbelt , Andrew Waterman , Jeff Law , gcc-patches@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: OK, thanks :) On Thu, Jan 18, 2024 at 4:17=E2=80=AFPM Jakub Jelinek wr= ote: > > Hi! > > As I wrote recently, Bool is an undocumented unsupported keyword, as > can be seen by > grep Bool doc/options.texi *.awk > The option parsing just parses and ignores all keywords it doesn't handle= . > But, because it isn't a supported keyword, I think we shouldn't have it i= n > *.opt files, because that just means people copy it over to other places > even when it doesn't have any effect. > > Tested with a cross to riscv64-linux, none of the generated > options.{h,cc} options-{save,urls}.cc > files change with the patch, only optionlist does (but that is just > used as a source for those files). > > Ok for trunk? > > 2024-01-18 Jakub Jelinek > > * config/riscv/riscv.opt (mshorten-memrefs, mrelax, mcsr-check, > minline-strcmp, minline-strncmp, minline-strlen, > -param=3Driscv-vector-abi): Remove Bool keywords. > > --- gcc/config/riscv/riscv.opt.jj 2024-01-18 08:44:33.441919890 +01= 00 > +++ gcc/config/riscv/riscv.opt 2024-01-18 08:58:22.788359898 +0100 > @@ -103,7 +103,7 @@ Target Mask(SAVE_RESTORE) > Use smaller but slower prologue and epilogue code. > > mshorten-memrefs > -Target Bool Var(riscv_mshorten_memrefs) Init(1) > +Target Var(riscv_mshorten_memrefs) Init(1) > Convert BASE + LARGE_OFFSET addresses to NEW_BASE + SMALL_OFFSET to allo= w more > memory accesses to be generated as compressed instructions. Currently t= argets > 32-bit integer load/stores. > @@ -134,12 +134,12 @@ Target Mask(EXPLICIT_RELOCS) > Use %reloc() operators, rather than assembly macros, to load addresses. > > mrelax > -Target Bool Var(riscv_mrelax) Init(1) > +Target Var(riscv_mrelax) Init(1) > Take advantage of linker relaxations to reduce the number of instruction= s > required to materialize symbol addresses. > > mcsr-check > -Target Bool Var(riscv_mcsr_check) Init(0) > +Target Var(riscv_mcsr_check) Init(0) > Enable the CSR checking for the ISA-dependent CRS and the read-only CSR. > The ISA-dependent CSR are only valid when the specific ISA is set. The > read-only CSR can not be written by the CSR instructions. > @@ -483,15 +483,15 @@ Target Var(TARGET_INLINE_SUBWORD_ATOMIC) > Always inline subword atomic operations. > > minline-strcmp > -Target Bool Var(riscv_inline_strcmp) Init(0) > +Target Var(riscv_inline_strcmp) Init(0) > Inline strcmp calls if possible. > > minline-strncmp > -Target Bool Var(riscv_inline_strncmp) Init(0) > +Target Var(riscv_inline_strncmp) Init(0) > Inline strncmp calls if possible. > > minline-strlen > -Target Bool Var(riscv_inline_strlen) Init(0) > +Target Var(riscv_inline_strlen) Init(0) > Inline strlen calls if possible. > > -param=3Driscv-strcmp-inline-limit=3D > @@ -542,7 +542,7 @@ madjust-lmul-cost > Target Var(TARGET_ADJUST_LMUL_COST) Init(0) > > -param=3Driscv-vector-abi > -Target Undocumented Bool Var(riscv_vector_abi) Init(0) > +Target Undocumented Var(riscv_vector_abi) Init(0) > Enable the use of vector registers for function arguments and return val= ue. > This is an experimental switch and may be subject to change in the futur= e. > > > Jakub >