From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [IPv6:2a00:1450:4864:20::536]) by sourceware.org (Postfix) with ESMTPS id A4A1E3858C74 for ; Fri, 1 Mar 2024 08:26:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A4A1E3858C74 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A4A1E3858C74 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::536 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709281642; cv=none; b=CNUkR7/o4T3X4sMi4rpntHuEm9yf5xyCSvNgM45Dozhg89fzlqR3r/A/27WC1w5weI0hawgCt4HBMKqheZHK8fg5RhmdOW+ycLmaE+XwLPr/Fh5PQYI73qZR6xMNv5IcGmUySZ8VZxxFIJGY3NXyks4TgqQfSCyIwFaCgut52I8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709281642; c=relaxed/simple; bh=mZ1bGgHq3gDn6zqidtuMZ3a2E7/5hK9KojNdesQ9eA0=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=vLEG4FHy/nHHKo7gljHfyJammGvAaW/o94Rq0kieY1joBq7x2DkdHrL0EGO/p/nwA383PrmpGMWfre1r6VbQb328RCSgI0DeZehUaFWVtTsi3Iss+lOh05f/XGLh+QPYMCpRHLGcr7p2lJoZv7gD+tnSTm7XF2lN2TpZKkaAerA= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ed1-x536.google.com with SMTP id 4fb4d7f45d1cf-56657bcd555so2537838a12.3 for ; Fri, 01 Mar 2024 00:26:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1709281606; x=1709886406; darn=gcc.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=f5k07mYU/UlIkbknH4BAVH3HwwN7/zRcN1sjE1jC6eM=; b=WIaKb2+F3qtvRF1dR8uP9cO07qFiewA2aWDhlH2pQenUflUZRdyjzgcgmjCAmStBN3 83pxyYtfuJI1d10YeuhQwHnYM6SaCnhcP4d/6cJ0li/NWTn4F/bnE+29P6g5sD5+vI71 /Qivk/sXQRf+RPAyGIffBwZwIaiN9JnTZD4ynmZp9eUQCwlHQZtpOeFgJDR4whX4gEqX o3SBYCjbw242XU3pNsqNk3oUqi/t/bYn5KpmmsOBtyzL8CIi0VQAQBz8tLUxJFj88TSW M6EgKc+3/U4FzUOwdiNK2/xeUCDyz29uyArUFbxvq0X2qyn36Sjb42FNi40rkS9jmCBK kmBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709281606; x=1709886406; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=f5k07mYU/UlIkbknH4BAVH3HwwN7/zRcN1sjE1jC6eM=; b=dBJ/LBcjXV/wBFgpcSYUFw3beGufAV0rJ3cA0y3RIL9TcqQJUc7ymG1dPvjNR6rwg+ JhmV8eM6WWU8KAtFaY4pdk8JoOSwUIZUm2OF7kswGoxWMC3eBpCt/w29Ox8sE1mnVfTa /NKSOZidiX4FDUAcZyE4KViSXsrjiItAjRa1yoaLX2GIepZEY1BgwMAIVWl9w7xjFDtv rJVLiqhvgiRV2zeiQ/2ZrvEtLyVgcq9ZaaqVLjcTfsD1dGpLm4oDY15rJOy+zTd+NisO D9EBCfwwEVzAlRkg315eV9yE9u9+fwZrchmULwuIHX/yGIdB2/pREPHdQKGTXoDjXiU5 5JFg== X-Gm-Message-State: AOJu0YwEI3iCrFMS6XFOKflCjrOmSjbif6NeRY+LtCuVP6aBLfEOykC2 1dblqDSG/vMFnirdc6xZ99Eqwihhjp7ul0k3D2G61B5xAYxDAeo/3XRH/UyEnYLMpFE41E22yk0 O6mbT//+Gp5GC1pQcmyd8IbKOU2kNMsBf+MKL09C9 X-Google-Smtp-Source: AGHT+IEbrFGUqv2g6PVUztF4G4umR0nbn7RLq1BtHRAMVPVpepHUX94EmtZH7E9rHcQk3lka0omP4dTK33Ot0nBCn84= X-Received: by 2002:a17:906:7809:b0:a3f:d7ee:5fdc with SMTP id u9-20020a170906780900b00a3fd7ee5fdcmr729576ejm.46.1709281606064; Fri, 01 Mar 2024 00:26:46 -0800 (PST) MIME-Version: 1.0 References: <20240227011714.25482-1-xuli1@eswincomputing.com> In-Reply-To: <20240227011714.25482-1-xuli1@eswincomputing.com> From: Kito Cheng Date: Fri, 1 Mar 2024 16:26:34 +0800 Message-ID: Subject: Re: [PATCH] RISC-V: Add riscv_vector_cc function attribute To: Li Xu Cc: gcc-patches@gcc.gnu.org, palmer@dabbelt.com, juzhe.zhong@rivai.ai, zhengyu@eswincomputing.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-8.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Thanks for your patch! this is generally in good shape, just a few minor comments :) > diff --git a/gcc/doc/extend.texi b/gcc/doc/extend.texi > index 2135dfde9c8..afe486ba47b 100644 > --- a/gcc/doc/extend.texi > +++ b/gcc/doc/extend.texi > @@ -6314,6 +6314,18 @@ Permissible values for this parameter are @code{user}, @code{supervisor}, > and @code{machine}. If there is no parameter, then it defaults to > @code{machine}. > > +@cindex @code{riscv_vector_cc} function attribute, RISC-V > +@item riscv_vector_cc > +Use this attribute to force the function to use the vector calling > +convention variant. > +For more information on riscv_vector_cc, please see > +@uref{https://github.com/riscv-non-isa/riscv-c-api-doc/pull/67} Please remove above two line, I guess it's not good idea to reference a pull request link here :P > + > +@smallexample > +void foo() __attribute__((riscv_vector_cc)); > +[[riscv::vector_cc]] void foo(); // For C++11 and C23 > +@end smallexample > + > @end table > > The following target-specific function attributes are available for the > diff --git a/gcc/testsuite/gcc.target/riscv/rvv/base/attribute-riscv_vector_cc-callee-saved.c b/gcc/testsuite/gcc.target/riscv/rvv/base/attribute-riscv_vector_cc-callee-saved.c > new file mode 100644 > index 00000000000..7db9d874bcd > --- /dev/null > +++ b/gcc/testsuite/gcc.target/riscv/rvv/base/attribute-riscv_vector_cc-callee-saved.c > @@ -0,0 +1,117 @@ > +/* { dg-do compile } */ > +/* { dg-options "-march=rv64gcv -mabi=lp64d -O1" } */ > +/* { dg-final { check-function-bodies "**" "" } } */ I would like to prevent scanning the asm body if possible, since it might cause problem when we improving code gen, so could you try to scan .variant_cc\t like gcc/testsuite/gcc.target/aarch64/pcs_attribute-3.c? Then we can also drop -O1 in the option :) > + > +#include Drop this. > +void __attribute__((riscv_vector_cc)) > +foo2 (int a) > +{ > + int8_t data[1024]; Just char rather than int8_t, I would like to remove unnecessary header including if possible :)