From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vs1-xe29.google.com (mail-vs1-xe29.google.com [IPv6:2607:f8b0:4864:20::e29]) by sourceware.org (Postfix) with ESMTPS id 200D83858D33 for ; Thu, 9 Nov 2023 07:39:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 200D83858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 200D83858D33 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::e29 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699515560; cv=none; b=Vb/WavrRpyKn+C99athhVJMpPpa4Hq1Sila9g/xwWb2kg8jYTpS1Z4YJq67Zngc1hguop+crmomXqOxJ0DFLw9gkSDaIyikqrz+jeGMm6UiwXoXSVHhLFndXZwMdAvSA8xWj3P8g29t2/70ZfIuFinjuv0hg43KJFsPIBs3GgMI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699515560; c=relaxed/simple; bh=uF8XBruP5g6afkaMFyfSr1nufTHLeyCLzqu4DXVedGc=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=ARX+9E+1eHyCHXZ4A+/2b87miJfJrJEXuhT40Y7GUw1tNyxSYjtksb5UsNsYPcYtDH60M4Y4tDxyg87X/3tru+88sQzcWfDTuVQhwmS3NreFBw4a1LAWar1rEiHKHRS3uWdW8/yE4D1ogGvWjVt8yXY/eBzDP0s+7wuXIg9nuS8= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-vs1-xe29.google.com with SMTP id ada2fe7eead31-45db31f9156so257378137.1 for ; Wed, 08 Nov 2023 23:39:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699515558; x=1700120358; darn=gcc.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=hWzCI9bAK/D43MfimZGYm1Ngyt62fq3C2FkD17ejZdw=; b=iWHfyAkTbRvJ1YQ4ado62JIG0kTgyErt8DzCSe6dVnxwnXkRracD5dvn/sK/UuKzDZ ZETQ3gIs3iTLvHjGN9W2KgGus/heUfR9AZWLAeL2BzYqLni63jGBS4JIB3vZ3mfuCdSt eIZM/qARBBxaIuD/p4j0UCt9lx6uPrFmr4G/kXjCCej/MVcd62CK0QMkI2vhcP0YiQWt mohyx54YfkkzaRfO/YCH/7SganJS0NfPZxn5qQPaCekPMW96WxM4hxGdyOuRZkJxBLVT V7FgyXuKce2LKbWrgHPKd2g6HiquuhlKNQd8rGC5ra8Mo7ZjPkx6tE6cLCR8SjtasKEt f4sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699515558; x=1700120358; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hWzCI9bAK/D43MfimZGYm1Ngyt62fq3C2FkD17ejZdw=; b=Jj+sitnRWiwfCwSSCkzi6HAVMqjXFtOSf5v6Mz7WTOAacZ6EZrql3OArG1tgn0wLHD mJ6WUayjuFh64oxTJsxjAya0SLsIscK4ejZmAqUM1Ido5+TIVGepVp2JtCf+Y7hPcfTq YK6WbnE8+N9+ma+4XlEHlUrZ20VDgGCbSu3DezrzXsn6A4KaeXasi88KOW5KPSJ5hzFd GTig1Yu2X23pZNAL7qUPp5C7brcfykGLWzKhvX36YAhzeLjckv3pH46QSuv0GKZ4lJGe YHWTDpZqSGuHH0RKqIvshoJZpYKvFrMWJmfvSkqGHa9vctDt7mDgFNWh16ZCRLsy4Z8f SeIA== X-Gm-Message-State: AOJu0Yw6WsgklJdd/I9FiBEG8VQgXZNCGB9aAn+25ie2sbHCYISf2XtD Bi7ldU6JcWxQ24vxP5kbOvJ8c/VS+vmJM6toYAA= X-Google-Smtp-Source: AGHT+IF5oyM2Li3J10gTUI92xGCl9uHNnuVIR9iRm5ugyKr7fzqw2scFqWSUpF5U+dvYJVXpYw7Kdq6hp0uJAwxcAMQ= X-Received: by 2002:a05:6102:205a:b0:45d:a279:687c with SMTP id q26-20020a056102205a00b0045da279687cmr4522336vsr.29.1699515558265; Wed, 08 Nov 2023 23:39:18 -0800 (PST) MIME-Version: 1.0 References: <20231108131237.3672914-1-chenyixuan@iscas.ac.cn> In-Reply-To: <20231108131237.3672914-1-chenyixuan@iscas.ac.cn> From: Kito Cheng Date: Thu, 9 Nov 2023 15:39:07 +0800 Message-ID: Subject: Re: [PATCH] minimal support for xtheadv To: chenyixuan@iscas.ac.cn Cc: gcc-patches@gcc.gnu.org, shiyulong@iscas.ac.cn, oriachiuan@gmail.com, shihua@iscas.ac.cn, jiawei@iscas.ac.cn, =?UTF-8?Q?Christoph_M=C3=BCllner?= , Jojo R Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-8.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,FREEMAIL_REPLY,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Yi Xuan: This patch is trivial, and generally LGTM, but I would require putting the spec into https://github.com/riscv-non-isa/riscv-toolchain-conventions before merging this, also don't forget include "RISC-V:" in the title, it would be easier to track during the RISC-V GCC sync meeting :) And I am a little bit confused by the author's info? is it from you or "XYenChi "? or oriachiuan@gmail.com is also your mail address? cc Christoph since I believe you may know more about that process. cc JoJo since you are T-head folk :P On Wed, Nov 8, 2023 at 9:13=E2=80=AFPM wrote: > > From: XYenChi > > This patch is for support xtheadv. > > gcc/ChangeLog: > > 2023-11-08 Chen Yixuan > > * common/config/riscv/riscv-common.cc: Add xthead minimal support= . > > gcc/config/ChangeLog: > > 2023-11-08 Chen Yixuan > > * riscv/riscv.opt: Add xthead minimal support. > --- > gcc/common/config/riscv/riscv-common.cc | 2 ++ > gcc/config/riscv/riscv.opt | 2 ++ > 2 files changed, 4 insertions(+) > > diff --git a/gcc/common/config/riscv/riscv-common.cc b/gcc/common/config/= riscv/riscv-common.cc > index 526dbb7603b..d5ea0ee9b70 100644 > --- a/gcc/common/config/riscv/riscv-common.cc > +++ b/gcc/common/config/riscv/riscv-common.cc > @@ -325,6 +325,7 @@ static const struct riscv_ext_version riscv_ext_versi= on_table[] =3D > {"xtheadmemidx", ISA_SPEC_CLASS_NONE, 1, 0}, > {"xtheadmempair", ISA_SPEC_CLASS_NONE, 1, 0}, > {"xtheadsync", ISA_SPEC_CLASS_NONE, 1, 0}, > + {"xtheadv", ISA_SPEC_CLASS_NONE, 0, 7}, > > {"xventanacondops", ISA_SPEC_CLASS_NONE, 1, 0}, > > @@ -1680,6 +1681,7 @@ static const riscv_ext_flag_table_t riscv_ext_flag_= table[] =3D > {"xtheadmemidx", &gcc_options::x_riscv_xthead_subext, MASK_XTHEADMEMI= DX}, > {"xtheadmempair", &gcc_options::x_riscv_xthead_subext, MASK_XTHEADMEMP= AIR}, > {"xtheadsync", &gcc_options::x_riscv_xthead_subext, MASK_XTHEADSYNC= }, > + {"xtheadv", &gcc_options::x_riscv_xthead_subext, MASK_XTHEADV}, > > {"xventanacondops", &gcc_options::x_riscv_xventana_subext, MASK_XVENTA= NACONDOPS}, > > diff --git a/gcc/config/riscv/riscv.opt b/gcc/config/riscv/riscv.opt > index 70d78151cee..2bbdf680fa2 100644 > --- a/gcc/config/riscv/riscv.opt > +++ b/gcc/config/riscv/riscv.opt > @@ -438,6 +438,8 @@ Mask(XTHEADMEMPAIR) Var(riscv_xthead_subext) > > Mask(XTHEADSYNC) Var(riscv_xthead_subext) > > +Mask(XTHEADV) Var(riscv_xthead_subext) > + > TargetVariable > int riscv_xventana_subext > > -- > 2.42.0 >