From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vs1-xe32.google.com (mail-vs1-xe32.google.com [IPv6:2607:f8b0:4864:20::e32]) by sourceware.org (Postfix) with ESMTPS id 3F11E3858D28 for ; Wed, 11 Oct 2023 21:20:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3F11E3858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-vs1-xe32.google.com with SMTP id ada2fe7eead31-45766b79b14so143652137.1 for ; Wed, 11 Oct 2023 14:20:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697059237; x=1697664037; darn=gcc.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=gXi4a5m1IGinLwWJdeYGJpDa9BEK4vQ86B0DcLM2IGY=; b=T/Z9tXbopQjk1uuaZRZQd9uUVF+BZOmPaV+gEJrSnQ74gXB+EGimwQKnEX8BvgTikK WvbIFjmw8Jqe7xoWkiToLrC7aYmO/Ch6kv8Bvozo1ngn8fhgQeLo3OmzKZRE2RAuhYX7 PAhLyiDz+kuLVnTvht+NU7HwZFzrzV2/v4ukm63muF1Ao9hQF4Hv/EXyyi3q0hm1it5C 0Rpw4WL0w3wPrbxsT07hOQSLcTmGs6U39BSdbcuRKp4ggKxKjRBkn+tZPfBohIvkSQCh I5dzvNCqDpdoJILcN1rUc43nUD4vsxZtjlvCCQnLku2d2uCH67XBHy1JR7HdCx2Kk0b6 A6sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697059237; x=1697664037; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gXi4a5m1IGinLwWJdeYGJpDa9BEK4vQ86B0DcLM2IGY=; b=gS8kHPXCh3k+Sfwti10QFPFVHeu1jyj4jHV3kT2l7Ie3gNVH0JXGEp8ioU+MLRfaeO lZw8NmFwK6vTIE7watQ8YOW2PvYspSyxEiH+sHuLGXD7wwawCygAvujm6JK6LPN5gbq3 dInvk/v2vgYyMmrERe6cHpCT0+E33nI5vN+gC+4fbZ9wQ0xauKVGVyNrMT5RQdAw96Ge JS1cyFHZg8FoIHdIqE7bgdARXjrnYyee2LGWtFPli7LtsppZlBRtyfSxyEvJi5mzZkv2 3ABwqp5bvO/7RbzbzqVmVvWKhyrNJ2Vj6mOsQCqXVCfttDkAWESwMjEvr2laVsvdHDM/ azBA== X-Gm-Message-State: AOJu0Yw4F96qzFKCtRbFOLW2cDTcV8uVyvS5nvI57NQJKs35cFA0iBWr wVbA0mbFrl0IaC1t+R5lEPcJv5nRT9yrwAvVZKY= X-Google-Smtp-Source: AGHT+IGyhrcNzdrK/+wULenx86IAvPpnDq/BaQ/LiCLDMKhX8pMhtl4X+XPUAmrXdLRv9FnaMjsVSBBGKLfdaEmUvZY= X-Received: by 2002:a05:6102:14d:b0:452:bfe3:8941 with SMTP id a13-20020a056102014d00b00452bfe38941mr20768094vsr.21.1697059237551; Wed, 11 Oct 2023 14:20:37 -0700 (PDT) MIME-Version: 1.0 References: <20231010041305.9111-1-kito.cheng@sifive.com> <20231010041305.9111-2-kito.cheng@sifive.com> <85d477f4-4e06-47ec-87ba-c2c8ade47e33@gmail.com> In-Reply-To: <85d477f4-4e06-47ec-87ba-c2c8ade47e33@gmail.com> From: Kito Cheng Date: Wed, 11 Oct 2023 14:20:26 -0700 Message-ID: Subject: Re: [PATCH v2 1/4] options: Define TARGET__P and TARGET__OPTS_P macro for Mask and InverseMask To: Jeff Law Cc: Kito Cheng , gcc-patches@gcc.gnu.org, palmer@dabbelt.com, rdapp@ventanamicro.com, juzhe.zhong@rivai.ai Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Thanks, committed, and just did one more check with x86 again, it works as well, hope no more awk portable issue this time :P On Tue, Oct 10, 2023 at 6:51=E2=80=AFAM Jeff Law wr= ote: > > > > On 10/9/23 22:13, Kito Cheng wrote: > > We TARGET__P marcro to test a Mask and InverseMask with user > > specified target_variable, however we may want to test with specific > > gcc_options variable rather than target_variable. > > > > Like RISC-V has defined lots of Mask with TargetVariable, which is not > > easy to use, because that means we need to known which Mask are associa= te with > > which TargetVariable, so take a gcc_options variable is a better interf= ace > > for such use case. > > > > gcc/ChangeLog: > > > > * doc/options.texi (Mask): Document TARGET__P and > > TARGET__OPTS_P. > > (InverseMask): Ditto. > > * opth-gen.awk (Mask): Generate TARGET__P and > > TARGET__OPTS_P macro. > > (InverseMask): Ditto. > OK assuming it passes a build cycle on x86 or some other common target. > > jeff