From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x535.google.com (mail-ed1-x535.google.com [IPv6:2a00:1450:4864:20::535]) by sourceware.org (Postfix) with ESMTPS id 037E3384640E for ; Thu, 25 Apr 2024 06:24:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 037E3384640E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 037E3384640E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::535 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714026249; cv=none; b=L/7lkzeuv9bu3tSCPow0tdRF3DcPFST0pPow9CfFJl7TetlZQsssxj2CxsfRBPcWSRVUy5uAlxt5CtGzsJshF4qwRxLNSiWFpPOTYScG3ugMAQTXH72GtLxPRJlZ+/ZU1llghPUMP+EQq3NDvg7ZBQNSItS+Td/sV+HFC+6GqZ0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714026249; c=relaxed/simple; bh=NkYpD1QIbGGxZw0POAT5FkAfGkFi1XOS3+2L1jhoNH0=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=GNqONOU1UH5vq0k4bL5nN3PlMQ2lTO3lKJb1wq78i8Le++XAneI+quUIfDLbuBJfds6XqvBE8t4tiU9BNOPpGukpquUCN68u1gsqm2UJmiGnz8bhc6RSsMMSQlWt2RLVU7e/oHcBkv2IdqtJqSxeUCsGkizAvLKVmd/AzQSYL40= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ed1-x535.google.com with SMTP id 4fb4d7f45d1cf-56e6a1edecfso811068a12.1 for ; Wed, 24 Apr 2024 23:24:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1714026246; x=1714631046; darn=gcc.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=V2bt31/NBJ3wBTrKOayOFD4n4k4uIWqIiCwBU24ZPoA=; b=nashQ1X0btuyaPUDoq5+gRbzXm+6yFZRiCU2xBbrmAiwa1tfECJ0KDSzuwxcLxctPE O4v/wRbdentSCmVZYUyhoidY9dQeEWq14zpDyp5R+LUm5f3zILTsEzRNTDrhVQ/WQV4D WaQI3ziyvCHkFwPpuSu+z82IE385Lca1zfkbYSWVmXRx2y/7QV/kdFMZ2xUahCgE46T9 0P+m2NhFVguvSIjgNkziBF+jg0IlDlCy9udNhUcTOKqgpSIsvwZnssD/zOjKiIxep8Xe UetzocRnuxJv4tOdERf9cOJLAgbdCu4z33o02ZCy91eDgr2+Qi5/rUL0UsVCGNQICHR4 ohVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714026246; x=1714631046; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=V2bt31/NBJ3wBTrKOayOFD4n4k4uIWqIiCwBU24ZPoA=; b=JzbBRYwIGgGAM4avt2PHSN+vbsVyeUUKVDOJuwsyjT4FSVL/b32EIB+X2uZm6KJ/vy xt1C1pvKdRpMQ7wijE/lcIv4xSW+WB45Jt/gmE71PyeLmcLNfJ3I6WYVmsurbieHWc5b sb3noqAyY+vuN5D4Yf3xis8/u0YzUD8uBKmgVLKLKzsSfaZA2ddQPf+MWUviU79zGsxM ym8h1SkW9/K+1bfJlnH0BQu+CKe00PUCvSAtn4xLPaeMwtq9OH7YWeKfPIbXM1EmJwSV 65c/WwcWn6tUAO6WI/eIJ8ouEYMpQ/G8TtHmrjBITEBpNsATrEphHytu7gdHxNu68xvA 0LJA== X-Forwarded-Encrypted: i=1; AJvYcCXbPRycFKoOhrTexm9FiXOB9+j+FUZ7lY/3BO4lLc2Kxs9uKAL1LLtm4upF2JtVJ5Ga+IxluhDHIMc/Zk4PTeU0vG081nbbTQ== X-Gm-Message-State: AOJu0Yz7i/s80LSu4LIS8bEEclOoUHXwT0a0mvhdNXAc+fqQMW1EupFh xOCi9Y5yr06Xx9tztpVR2Ir7uowH08eHgFwzPH+pgsd5FFYpiwjJXevorcux0KWDvKtgeajgprk fXANFwu+EITryNjl7GZkJvZBg/jk= X-Google-Smtp-Source: AGHT+IH0j+ZGc0JPaQz/wWTHr8Ji3Wz886T7esAmy+DT8FT49NOwGXBoYIOUwZLAOad4bxW0Isx1nKxS1iZxcbOhkKE= X-Received: by 2002:a17:906:c28f:b0:a55:b487:5676 with SMTP id r15-20020a170906c28f00b00a55b4875676mr3240878ejz.72.1714026245349; Wed, 24 Apr 2024 23:24:05 -0700 (PDT) MIME-Version: 1.0 References: <20240425012508.2079105-1-pan2.li@intel.com> <69621402A90817D5+202404250925505643881@rivai.ai> In-Reply-To: <69621402A90817D5+202404250925505643881@rivai.ai> From: Kito Cheng Date: Thu, 25 Apr 2024 14:23:53 +0800 Message-ID: Subject: Re: [PATCH v1] RISC-V: Add early clobber to the dest of vwsll To: "juzhe.zhong@rivai.ai" Cc: "pan2.li" , gcc-patches , Robin Dapp Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-8.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: LGTM, thanks :) On Thu, Apr 25, 2024 at 9:26=E2=80=AFAM juzhe.zhong@rivai.ai wrote: > > lgtm > > ________________________________ > juzhe.zhong@rivai.ai > > > From: pan2.li > Date: 2024-04-25 09:25 > To: gcc-patches > CC: juzhe.zhong; kito.cheng; rdapp.gcc; Pan Li > Subject: [PATCH v1] RISC-V: Add early clobber to the dest of vwsll > From: Pan Li > > We missed the existing early clobber for the dest operand of vwsll > pattern when resolve the conflict of revert register overlap. Thus > add it back to the pattern. Unfortunately, we have no test to cover > this part and will improve this after GCC-15 open. > > The below tests are passed for this patch: > * The rv64gcv fully regression test with isl build. > > gcc/ChangeLog: > > * config/riscv/vector-crypto.md: Add early clobber to the > dest operand of vwsll. > > Signed-off-by: Pan Li > --- > gcc/config/riscv/vector-crypto.md | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gcc/config/riscv/vector-crypto.md b/gcc/config/riscv/vector-= crypto.md > index 8a4888a7653..e474ddf5da7 100755 > --- a/gcc/config/riscv/vector-crypto.md > +++ b/gcc/config/riscv/vector-crypto.md > @@ -303,7 +303,7 @@ (define_insn "@pred_vwsll" > (set_attr "mode" "")]) > (define_insn "@pred_vwsll_scalar" > - [(set (match_operand:VWEXTI 0 "register_operand" "=3Dvr, = vr") > + [(set (match_operand:VWEXTI 0 "register_operand" "=3D&vr,= &vr") > (if_then_else:VWEXTI > (unspec: > [(match_operand: 1 "vector_mask_operand" "vmWc1, = vmWc1") > -- > 2.34.1 > >