From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ua1-x931.google.com (mail-ua1-x931.google.com [IPv6:2607:f8b0:4864:20::931]) by sourceware.org (Postfix) with ESMTPS id C576A3858D37 for ; Mon, 26 Jun 2023 09:11:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C576A3858D37 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ua1-x931.google.com with SMTP id a1e0cc1a2514c-783f17f0a00so664750241.2 for ; Mon, 26 Jun 2023 02:11:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687770668; x=1690362668; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=c6Zh24ub7OZ8dO9HCjl5jEK/332+tp5h1igzPg+n3iQ=; b=pDQ2B8avy8mPxZ1qZ+YP+fkGLjMXeg70WanjMtS/e6gBz0Akf0tPYK9B8VFpMasO47 35otbdeGCcWa00FdeNJ7PoPG1EbuSyrii1FR+mBAwzqXbkSR8gB0JmfJnRUgD1aRYOnc MfhNNXaUqU2NWrZq3MC5UKhv7ncLlb0/hDPEd8fWu84Lg4PRBtOZK2YJQ6K94GuzZl80 64ptWfpxz6XUmnc5OB6konLe9qN5kNlF0eA0T9+/ndJ3B53bywXh+t9v/qKpZWXU9dKh kAO3kKnbbcdY60sd2NNUQeogC4ZghPI1MniqlC77FKL9Z6CqhlmurPAYEzGbxL7ZOqL9 nrDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687770668; x=1690362668; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=c6Zh24ub7OZ8dO9HCjl5jEK/332+tp5h1igzPg+n3iQ=; b=TpZhkO2U1442oYuo0T0d13t+OXt+MW/MzFV8R9TMi4UERpg6w+d8HuH29aZIe73zu4 R0nOiBxhczJICeZzweGVctd/DRJXpk+jNRkDzg0OhkfvQn9+CEx0iVEbtU7lNqjiCDJ9 x+kZ7QEqRDR1tsezpsL8f4szyZIGWAcNS1liaUemvcZLRC5T0Fks5wh4lrX5m2RHiFEV K90IbBdSNDCoZQwQVk5sH6xPbG9S8XOs2ALMmBnlzMoWJhhAR2aeul94fEG7c6fHSZY3 LSYTAPbTOLz7BsOU91I4Vg87AlX0pMeyJNCwYqWK7Z87Mm/xlr9Qunr+ZgpfxJ81CZPS 9IDw== X-Gm-Message-State: AC+VfDxauBkuTzxchcre99L9Hx6FvqARtUSAgmXyRMkIVAds9sZIx5Cf wMnzKvme8/1trw6rMx2Q90dq/NWIyvJCCX7lj0I= X-Google-Smtp-Source: ACHHUZ4uscviyORTkR1xo0WaXk9fxXeC0IaJmful1XlUkTBUskZ0CT4m7sdfxIu24jV/WuoaB9PW5B6cqpLyCQZdHVU= X-Received: by 2002:a67:ed44:0:b0:43d:6660:581b with SMTP id m4-20020a67ed44000000b0043d6660581bmr11508984vsp.5.1687770668018; Mon, 26 Jun 2023 02:11:08 -0700 (PDT) MIME-Version: 1.0 References: <20230626065101.75459-1-juzhe.zhong@rivai.ai> In-Reply-To: From: Kito Cheng Date: Mon, 26 Jun 2023 17:10:57 +0800 Message-ID: Subject: Re: [PATCH] RISC-V: Enhance RVV VLA SLP auto-vectorization To: Robin Dapp Cc: Juzhe-Zhong , gcc-patches@gcc.gnu.org, kito.cheng@sifive.com, palmer@dabbelt.com, palmer@rivosinc.com, jeffreyalaw@gmail.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Could you re-title this patch into something like "Support const vector expansion with xxx pattern", On Mon, Jun 26, 2023 at 3:52=E2=80=AFPM Robin Dapp via Gcc-patches wrote: > > Hi Juzhe, > > > Currently, we are able to generate step vector with base =3D=3D 0: > > { 0, 0, 2, 2, 4, 4, ... } > > > > ASM: > > > > vid > > vand > > > > However, we do wrong for step vector with base !=3D 0: > > { 1, 1, 3, 3, 5, 5, ... } > > > > Before this patch, such case will run fail. > > > > After this patch, we are able to pass the testcase and generate the ste= p vector with asm: > > > > vid > > vand > > vadd > > Can't we use the first case as long as pow2_p (base) =3D=3D true > and not just for base =3D=3D 0? > > Regards > Robin >